You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "tomvanbussel (via GitHub)" <gi...@apache.org> on 2023/03/29 17:06:48 UTC
[GitHub] [spark] tomvanbussel opened a new pull request, #40590: [SPARK-42631][CONNECT][FOLLOW-UP] Expose Column.expr to extensions
tomvanbussel opened a new pull request, #40590:
URL: https://github.com/apache/spark/pull/40590
### What changes were proposed in this pull request?
This PR is a follow-up to https://github.com/apache/spark/pull/40234, which makes it possible for extensions to create custom `Dataset`s and `Column`s. It exposes `Dataset.plan`, but unfortunately it does not expose `Column.expr`. This means that extensions cannot build custom `Column`s that provide a user provider `Column` as input.
### Why are the changes needed?
See above.
### Does this PR introduce _any_ user-facing change?
No. This only adds a change for a Developer API.
### How was this patch tested?
Existing tests to make sure nothing breaks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #40590: [SPARK-42631][CONNECT][FOLLOW-UP] Expose Column.expr to extensions
Posted by "amaliujia (via GitHub)" <gi...@apache.org>.
amaliujia commented on PR #40590:
URL: https://github.com/apache/spark/pull/40590#issuecomment-1489129059
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell commented on pull request #40590: [SPARK-42631][CONNECT][FOLLOW-UP] Expose Column.expr to extensions
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell commented on PR #40590:
URL: https://github.com/apache/spark/pull/40590#issuecomment-1489181163
Merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell closed pull request #40590: [SPARK-42631][CONNECT][FOLLOW-UP] Expose Column.expr to extensions
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell closed pull request #40590: [SPARK-42631][CONNECT][FOLLOW-UP] Expose Column.expr to extensions
URL: https://github.com/apache/spark/pull/40590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org