You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/09/22 03:37:40 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #4591: net/devif: Remove the unnecessary net lock/unlock in devif_callback
xiaoxiang781216 opened a new pull request #4591:
URL: https://github.com/apache/incubator-nuttx/pull/4591
## Summary
since the caller already hold the net lock before
## Impact
No, remove the redundant lock/unlock
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4591: net/devif: Remove the unnecessary net lock/unlock in devif_callback
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #4591:
URL: https://github.com/apache/incubator-nuttx/pull/4591#issuecomment-945437287
If so, let's close this PR now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 closed pull request #4591: net/devif: Remove the unnecessary net lock/unlock in devif_callback
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 closed pull request #4591:
URL: https://github.com/apache/incubator-nuttx/pull/4591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] hartmannathan commented on pull request #4591: net/devif: Remove the unnecessary net lock/unlock in devif_callback
Posted by GitBox <gi...@apache.org>.
hartmannathan commented on pull request #4591:
URL: https://github.com/apache/incubator-nuttx/pull/4591#issuecomment-945137192
> > since the caller already hold the net lock before.
>
> @xiaoxiang781216 can we be sure of this? I tried to follow the calls, but in some cases I couldn't find a lock.
Also I think we should consider future inadvertent changes. That is, even if all code paths today have a lock, what happens if in the future one of those code paths is changed and doesn't have a lock anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #4591: net/devif: Remove the unnecessary net lock/unlock in devif_callback
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #4591:
URL: https://github.com/apache/incubator-nuttx/pull/4591#issuecomment-945084043
> since the caller already hold the net lock before.
@xiaoxiang781216 can we be sure of this? I tried to follow the calls, but in some cases I couldn't find a lock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org