You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Mesos Reviewbot <re...@mesos.apache.org> on 2019/02/21 12:07:27 UTC
Re: Review Request 68736: Added `task cat` command to new CLI.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68736/#review213023
-----------------------------------------------------------
Bad review!
Reviews applied: [68736, 68711, 68950, 68949]
Error:
2019-02-21 12:07:26 URL:https://reviews.apache.org/r/68711/diff/raw/ [8020/8020] -> "68711.patch" [1]
error: patch failed: src/python/cli_new/lib/cli/mesos.py:22
error: src/python/cli_new/lib/cli/mesos.py: patch does not apply
error: patch failed: src/python/cli_new/lib/cli/plugins/task/main.py:42
error: src/python/cli_new/lib/cli/plugins/task/main.py: patch does not apply
error: patch failed: src/python/cli_new/lib/cli/tests/task.py:18
error: src/python/cli_new/lib/cli/tests/task.py: patch does not apply
- Mesos Reviewbot
On Sept. 17, 2018, 3:46 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68736/
> -----------------------------------------------------------
>
> (Updated Sept. 17, 2018, 3:46 p.m.)
>
>
> Review request for mesos, Eric Chung and Kevin Klues.
>
>
> Bugs: MESOS-8795
> https://issues.apache.org/jira/browse/MESOS-8795
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added `task cat` command to new CLI.
>
>
> Diffs
> -----
>
> src/python/cli_new/lib/cli/plugins/task/main.py 644e256ce898784ce3511c30a373595ace149db9
> src/python/cli_new/lib/cli/tasks.py PRE-CREATION
> src/python/cli_new/lib/cli/tests/task.py b54ade557f579a489e459f6022807146e0211fb0
>
>
> Diff: https://reviews.apache.org/r/68736/diff/1/
>
>
> Testing
> -------
>
> Tested manually and:
> ```
> (mesos-cli) bash-3.2$ mesos-cli-tests
> Running the Mesos CLI unit tests
>
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
>
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
>
> TestTaskPlugin
> test_cat (cli.tests.task.TestTaskPlugin) ... ok
> test_list (cli.tests.task.TestTaskPlugin) ... ok
> test_ls (cli.tests.task.TestTaskPlugin) ... ok
>
> ----------------------------------------------------------------------
> Ran 6 tests in 13.934s
>
> OK
> ```
>
>
> Thanks,
>
> Armand Grillet
>
>