You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "beiwei30 (GitHub)" <gi...@apache.org> on 2019/03/07 05:28:25 UTC
[GitHub] [incubator-dubbo] beiwei30 opened pull request #3606:
simplify zookeeper related dependencies, try to address issue #3426
## What is the purpose of the change
issue #3426, simply 3rd party dependency.
## Brief changelog
XXXXX
## Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3606 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] mercyblitz commented on issue #3606:
simplify zookeeper related dependencies, try to address issue #3426
Posted by "mercyblitz (GitHub)" <gi...@apache.org>.
No Problem for me.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3606 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 commented on issue #3606:
simplify zookeeper related dependencies, try to address issue #3426
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
I reconsider this solution and decided to leave the current dependency as is, and will enhance another related pull request, to introduce a convenient zookeeper related dependency.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3606 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 closed pull request #3606:
simplify zookeeper related dependencies, try to address issue #3426
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
[ pull request closed by beiwei30 ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3606 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org