You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Colin Ma <ju...@intel.com> on 2014/08/18 03:45:20 UTC
Re: Review Request 23917: SENTRY-367 : Add end to end tests for audit
log
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23917/
-----------------------------------------------------------
(Updated Aug. 18, 2014, 1:45 a.m.)
Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.
Repository: sentry
Description
-------
The patch is for end to end test cases of audit log.
Diffs (updated)
-----
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbDDLAuditLog.java PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/resources/log4j.properties d941816
Diff: https://reviews.apache.org/r/23917/diff/
Testing
-------
Thanks,
Colin Ma
Re: Review Request 23917: SENTRY-367 : Add end to end tests for audit
log
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23917/#review50991
-----------------------------------------------------------
Ship it!
Nice work Colin!
- Sravya Tirukkovalur
On Aug. 19, 2014, 2:16 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23917/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2014, 2:16 a.m.)
>
>
> Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> The patch is for end to end test cases of audit log.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbDDLAuditLog.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23917/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
Re: Review Request 23917: SENTRY-367 : Add end to end tests for audit
log
Posted by Colin Ma <ju...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23917/
-----------------------------------------------------------
(Updated Aug. 19, 2014, 2:16 a.m.)
Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.
Repository: sentry
Description
-------
The patch is for end to end test cases of audit log.
Diffs (updated)
-----
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbDDLAuditLog.java PRE-CREATION
Diff: https://reviews.apache.org/r/23917/diff/
Testing
-------
Thanks,
Colin Ma
Re: Review Request 23917: SENTRY-367 : Add end to end tests for audit
log
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23917/#review50918
-----------------------------------------------------------
Looks good to me. Minor comments below.
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbDDLAuditLog.java
<https://reviews.apache.org/r/23917/#comment88801>
Thanks for adding check in the catch block Colin! That helps. Minor suggestion: Would be good to assert that exception was indeed thrown here. Otherwise test would pass even if the exception was not thrown. Like:
try {
statement.execute("CREATE ROLE " + roleName);
fail("Exception should have been thrown");
}
sentry-tests/sentry-tests-hive/src/test/resources/log4j.properties
<https://reviews.apache.org/r/23917/#comment88802>
These changes are not required in log4j.properties file, as you are setting the appenders etc from the test itself.
- Sravya Tirukkovalur
On Aug. 18, 2014, 1:45 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23917/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2014, 1:45 a.m.)
>
>
> Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> The patch is for end to end test cases of audit log.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbDDLAuditLog.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/resources/log4j.properties d941816
>
> Diff: https://reviews.apache.org/r/23917/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>