You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/14 15:42:04 UTC

[GitHub] [flink] StephanEwen opened a new pull request #12156: [FLINK-17701][build] Exclude transitive jdk:tools dependency from all Hadoop dependencies.

StephanEwen opened a new pull request #12156:
URL: https://github.com/apache/flink/pull/12156


   ## What is the purpose of the change
   
   Fixes issues with dependencies when using Java 9+.
   
   The `jdk:tools` dependency is referenced by Hadoop, but not available in Java 9+ any more. Importing the code into an IDE that runs Java 11 fails as a result.
   
   This transitive dependency is not needed when running the code, because the classes are always present anyways. It can be safely excluded form the transitive dependencies.
   
   ## Brief change log
   
   Adds an exclusion for `jdk:tools` to the Hadoop entries in the dependency management section.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **yes!**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: **no**
     - The S3 file system connector: **no**


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] asfgit closed pull request #12156: [FLINK-17701][build] Exclude transitive jdk:tools dependency from all Hadoop dependencies.

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #12156:
URL: https://github.com/apache/flink/pull/12156


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] StephanEwen commented on pull request #12156: [FLINK-17701][build] Exclude transitive jdk:tools dependency from all Hadoop dependencies.

Posted by GitBox <gi...@apache.org>.
StephanEwen commented on pull request #12156:
URL: https://github.com/apache/flink/pull/12156#issuecomment-628881205


   Should I merge this anyways, or wait for @zentol' investigation?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12156: [FLINK-17701][build] Exclude transitive jdk:tools dependency from all Hadoop dependencies.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12156:
URL: https://github.com/apache/flink/pull/12156#issuecomment-628732099


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "970ebae1768db4b2c0447d1e01e734a430d5a97e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "970ebae1768db4b2c0447d1e01e734a430d5a97e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 970ebae1768db4b2c0447d1e01e734a430d5a97e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12156: [FLINK-17701][build] Exclude transitive jdk:tools dependency from all Hadoop dependencies.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12156:
URL: https://github.com/apache/flink/pull/12156#issuecomment-628732099


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "970ebae1768db4b2c0447d1e01e734a430d5a97e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1325",
       "triggerID" : "970ebae1768db4b2c0447d1e01e734a430d5a97e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 970ebae1768db4b2c0447d1e01e734a430d5a97e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1325) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] StephanEwen edited a comment on pull request #12156: [FLINK-17701][build] Exclude transitive jdk:tools dependency from all Hadoop dependencies.

Posted by GitBox <gi...@apache.org>.
StephanEwen edited a comment on pull request #12156:
URL: https://github.com/apache/flink/pull/12156#issuecomment-628881205


   Should I merge this anyways, or wait for @zentol's investigation?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12156: [FLINK-17701][build] Exclude transitive jdk:tools dependency from all Hadoop dependencies.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12156:
URL: https://github.com/apache/flink/pull/12156#issuecomment-628721277


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 970ebae1768db4b2c0447d1e01e734a430d5a97e (Thu May 14 15:46:07 UTC 2020)
   
   **Warnings:**
    * **1 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rmetzger commented on pull request #12156: [FLINK-17701][build] Exclude transitive jdk:tools dependency from all Hadoop dependencies.

Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #12156:
URL: https://github.com/apache/flink/pull/12156#issuecomment-628739060


   Thanks a lot for addressing this issue. Does it make sense to ban this dependency in the java11 profile? 
   https://github.com/apache/flink/blob/master/pom.xml#L1619


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #12156: [FLINK-17701][build] Exclude transitive jdk:tools dependency from all Hadoop dependencies.

Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #12156:
URL: https://github.com/apache/flink/pull/12156#issuecomment-628824630


   @rmetzger I tried that in the past but it wasn't working for some reason; the enforcer still picked them up. You can give it another go though.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12156: [FLINK-17701][build] Exclude transitive jdk:tools dependency from all Hadoop dependencies.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12156:
URL: https://github.com/apache/flink/pull/12156#issuecomment-628732099


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "970ebae1768db4b2c0447d1e01e734a430d5a97e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1325",
       "triggerID" : "970ebae1768db4b2c0447d1e01e734a430d5a97e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 970ebae1768db4b2c0447d1e01e734a430d5a97e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1325) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org