You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/01/05 22:27:00 UTC
[Impala-ASF-CR] Make sure 'errata' page is hidden.
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5625
Change subject: Make sure 'errata' page is hidden.
......................................................................
Make sure 'errata' page is hidden.
The errata page is in an early experimental form and not expected
to be ready for prime time anytime soon. Depends on some
automation that's not practical to put in place during the
transition to Apache infra. That page is chock full of references
to CDH version numbers, so best to make sure it can't possibly
appear in the output.
Using 'Cloudera' condition instead of 'pre-release' to clarify that
the errata topic is experimental and will remain invisible for the
foreseeable future.
Also applying the same attribute to the corresponding <keydef> tag
so the hidden topic doesn't get processed in some unforeseen way.
Will change those conditions to 'hidden' after the other changes
to audience= attributes land.
Change-Id: Id254192b325ba18c415a2cf17e6357800d81c437
---
M docs/impala.ditamap
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/25/5625/1
--
To view, visit http://gerrit.cloudera.org:8080/5625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id254192b325ba18c415a2cf17e6357800d81c437
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] Make sure 'errata' page is hidden.
Posted by "Ambreen Kazi (Code Review)" <ge...@cloudera.org>.
Ambreen Kazi has posted comments on this change.
Change subject: Make sure 'errata' page is hidden.
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id254192b325ba18c415a2cf17e6357800d81c437
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-HasComments: No
[Impala-ASF-CR] Make sure 'errata' page is hidden.
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has submitted this change and it was merged.
Change subject: Make sure 'errata' page is hidden.
......................................................................
Make sure 'errata' page is hidden.
The errata page is in an early experimental form and not expected
to be ready for prime time anytime soon. Depends on some
automation that's not practical to put in place during the
transition to Apache infra. That page is chock full of references
to CDH version numbers, so best to make sure it can't possibly
appear in the output.
Using 'Cloudera' condition instead of 'pre-release' to clarify that
the errata topic is experimental and will remain invisible for the
foreseeable future.
Also applying the same attribute to the corresponding <keydef> tag
so the hidden topic doesn't get processed in some unforeseen way.
Will change those conditions to 'hidden' after the other changes
to audience= attributes land.
Change-Id: Id254192b325ba18c415a2cf17e6357800d81c437
Reviewed-on: http://gerrit.cloudera.org:8080/5625
Reviewed-by: Jim Apple <jb...@apache.org>
Reviewed-by: Ambreen Kazi <am...@cloudera.com>
Tested-by: John Russell <jr...@cloudera.com>
---
M docs/impala.ditamap
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jim Apple: Looks good to me, approved
Ambreen Kazi: Looks good to me, but someone else must approve
John Russell: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id254192b325ba18c415a2cf17e6357800d81c437
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] Make sure 'errata' page is hidden.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: Make sure 'errata' page is hidden.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id254192b325ba18c415a2cf17e6357800d81c437
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-HasComments: No
[Impala-ASF-CR] Make sure 'errata' page is hidden.
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: Make sure 'errata' page is hidden.
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id254192b325ba18c415a2cf17e6357800d81c437
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #250
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No