You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by JustinPihony <gi...@git.apache.org> on 2016/07/07 01:28:42 UTC

[GitHub] spark issue #14077: [SPARK-16402] [SQL] JDBC Source: Implement save API of D...

Github user JustinPihony commented on the issue:

    https://github.com/apache/spark/pull/14077
  
    This may seem simpler, but that's because it seems to be taking some shortcuts to avoid having to refactor. This currently creates a cycle along the lines of `df.save.df.jdbc`. Wouldn't it be better to fix the code than to work around it? Additionally, is moving the `copy` appropriate? Maybe it was put on the outside errantly and it is correct, but I'm not sure it can be moved without researching it properly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org