You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Artem Baranchuk <ab...@hortonworks.com> on 2015/05/18 16:35:02 UTC

Review Request 34314: Ambari - Separate memory configuration for Hive CLI vs HiveServer2 and Hive MetaStore

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34314/
-----------------------------------------------------------

Review request for Ambari, Andrew Onischuk, Mahadev Konar, Vitalyi Brodetskyi, and Yusaku Sako.


Bugs: AMBARI-10714
    https://issues.apache.org/jira/browse/AMBARI-10714


Repository: ambari


Description
-------

Ambari - Separate memory configuration for Hive CLI vs HiveServer2 and Hive MetaStore


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java b10d3a5 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 92373ad 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py fb90b57 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml f542bda 
  ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java 13435e7 

Diff: https://reviews.apache.org/r/34314/diff/


Testing
-------

tests passed!


Thanks,

Artem Baranchuk


Re: Review Request 34314: Ambari - Separate memory configuration for Hive CLI vs HiveServer2 and Hive MetaStore

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34314/#review84153
-----------------------------------------------------------

Ship it!


Ship It!

- Andrew Onischuk


On May 18, 2015, 2:35 p.m., Artem Baranchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34314/
> -----------------------------------------------------------
> 
> (Updated May 18, 2015, 2:35 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Mahadev Konar, Vitalyi Brodetskyi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-10714
>     https://issues.apache.org/jira/browse/AMBARI-10714
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari - Separate memory configuration for Hive CLI vs HiveServer2 and Hive MetaStore
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java b10d3a5 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 92373ad 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py fb90b57 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml f542bda 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java 13435e7 
> 
> Diff: https://reviews.apache.org/r/34314/diff/
> 
> 
> Testing
> -------
> 
> tests passed!
> 
> 
> Thanks,
> 
> Artem Baranchuk
> 
>


Re: Review Request 34314: Ambari - Separate memory configuration for Hive CLI vs HiveServer2 and Hive MetaStore

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34314/#review84163
-----------------------------------------------------------

Ship it!


Ship It!

- Vitalyi Brodetskyi


On Травень 18, 2015, 2:35 після полудня, Artem Baranchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34314/
> -----------------------------------------------------------
> 
> (Updated Травень 18, 2015, 2:35 після полудня)
> 
> 
> Review request for Ambari, Andrew Onischuk, Mahadev Konar, Vitalyi Brodetskyi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-10714
>     https://issues.apache.org/jira/browse/AMBARI-10714
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari - Separate memory configuration for Hive CLI vs HiveServer2 and Hive MetaStore
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java b10d3a5 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 92373ad 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py fb90b57 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml f542bda 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java 13435e7 
> 
> Diff: https://reviews.apache.org/r/34314/diff/
> 
> 
> Testing
> -------
> 
> tests passed!
> 
> 
> Thanks,
> 
> Artem Baranchuk
> 
>


Re: Review Request 34314: Ambari - Separate memory configuration for Hive CLI vs HiveServer2 and Hive MetaStore

Posted by Andrew Onischuk <ao...@hortonworks.com>.

> On May 18, 2015, 2:37 p.m., Andrew Onischuk wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml, line 31
> > <https://reviews.apache.org/r/34314/diff/1/?file=962655#file962655line31>
> >
> >     Why is it true??

Missread the code :) Nevermind


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34314/#review84151
-----------------------------------------------------------


On May 18, 2015, 2:35 p.m., Artem Baranchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34314/
> -----------------------------------------------------------
> 
> (Updated May 18, 2015, 2:35 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Mahadev Konar, Vitalyi Brodetskyi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-10714
>     https://issues.apache.org/jira/browse/AMBARI-10714
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari - Separate memory configuration for Hive CLI vs HiveServer2 and Hive MetaStore
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java b10d3a5 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 92373ad 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py fb90b57 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml f542bda 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java 13435e7 
> 
> Diff: https://reviews.apache.org/r/34314/diff/
> 
> 
> Testing
> -------
> 
> tests passed!
> 
> 
> Thanks,
> 
> Artem Baranchuk
> 
>


Re: Review Request 34314: Ambari - Separate memory configuration for Hive CLI vs HiveServer2 and Hive MetaStore

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34314/#review84151
-----------------------------------------------------------



ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml
<https://reviews.apache.org/r/34314/#comment135276>

    Why is it true??


- Andrew Onischuk


On May 18, 2015, 2:35 p.m., Artem Baranchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34314/
> -----------------------------------------------------------
> 
> (Updated May 18, 2015, 2:35 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Mahadev Konar, Vitalyi Brodetskyi, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-10714
>     https://issues.apache.org/jira/browse/AMBARI-10714
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari - Separate memory configuration for Hive CLI vs HiveServer2 and Hive MetaStore
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java b10d3a5 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml 92373ad 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py fb90b57 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/HIVE/configuration/hive-env.xml f542bda 
>   ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog210Test.java 13435e7 
> 
> Diff: https://reviews.apache.org/r/34314/diff/
> 
> 
> Testing
> -------
> 
> tests passed!
> 
> 
> Thanks,
> 
> Artem Baranchuk
> 
>