[GitHub] [flink] dannycranmer commented on a diff in pull request #21449: [FLINK-30291][Connector/DynamoDB] Update docs to render DynamoDB conn…

[GitBox <gi...@apache.org>]

dannycranmer commented on code in PR #21449:
URL: https://github.com/apache/flink/pull/21449#discussion_r1039307263


##########
docs/data/sql_connectors.yml:
##########
@@ -178,6 +178,14 @@ aws-kinesis-firehose:
   maven: flink-connector-kinesis-firehose
   sql_url: https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-connector-aws-kinesis-firehose/$version/flink-sql-connector-aws-kinesis-firehose-$version.jar
 
+dynamodb:
+    name: Amazon DynamoDB
+    category: connector
+    versions:
+        - version: 3.0.0
+          maven: flink-connector-dynamodb
+          sql_url: https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-connector-dynamodb/3.0.0-1.16/flink-sql-connector-dynamodb-3.0.0-1.16.jar
+

Review Comment:
   @zentol I could not remove this since it is required by the "downloads" table. Additionally we cannot build the SQL download URL in the `sql_connector_download_table` shortcode without knowing the name of the SQL artifact. 
   
   This renders correctly for now, I would like to get it merged to show the DynamoDB docs ready for the release today, can improve incrementally 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org