[jira] [Work logged] (NUMBERS-136) "log10" inconsistent with "log"

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/NUMBERS-136?focusedWorklogId=353666&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-353666 ]

ASF GitHub Bot logged work on NUMBERS-136:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Dec/19 19:05
            Start Date: 04/Dec/19 19:05
    Worklog Time Spent: 10m 
      Work Description: ericbarnhill commented on pull request #71: NUMBERS-136: log10() uses log() functionality
URL: https://github.com/apache/commons-numbers/pull/71
 
 
   log10() greatly simplified and uses log() functionality
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 353666)
    Remaining Estimate: 0h
            Time Spent: 10m

> "log10" inconsistent with "log"
> -------------------------------
>
>                 Key: NUMBERS-136
>                 URL: https://issues.apache.org/jira/browse/NUMBERS-136
>             Project: Commons Numbers
>          Issue Type: Bug
>          Components: complex
>            Reporter: Gilles Sadowski
>            Assignee: Eric Barnhill
>            Priority: Major
>             Fix For: 1.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> For special cases (containing NaN or infinities), method {{log10}} does not return the same values as {{log()}} (cf. case commented out  below).
> {code}
>     @Test
>     public void testLog10Consistency() {
>         // Infinities should map to the same values as computed with "log()".
>         // Assertions.assertEquals(infInf.log(), infInf.log10());
>         Assertions.assertEquals(infNegInf.log(), infNegInf.log10());
>         Assertions.assertEquals(negInfInf.log(), negInfInf.log10());
>         // Assertions.assertEquals(infNaN.log(), infNaN.log10());
>         Assertions.assertEquals(negInfNaN.log(), negInfNaN.log10());
>         // Assertions.assertEquals(nanInf.log(), nanInf.log10());
>         Assertions.assertEquals(nanNegInf.log(), nanNegInf.log10());
>     }
> {code}
> To avoid duplication, I suggest that {{log10}} calls {{log}} as part of its implementation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)