You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jojy Varghese <jo...@mesosphere.io> on 2015/11/25 01:38:12 UTC
Review Request 40681: Changed mesos-local to use posix launcher as
default.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40681/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Timothy Chen.
Repository: mesos
Description
-------
See MESOS-3793 for more details.
Diffs
-----
src/local/local.cpp d714eb148fa8db2cbbe23175ab859e50eec9036f
Diff: https://reviews.apache.org/r/40681/diff/
Testing
-------
Tested the changes in docker (ubuntu:14.04).
Thanks,
Jojy Varghese
Re: Review Request 40681: Changed mesos-local to use posix launcher as
default.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40681/#review107890
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On Nov. 25, 2015, 12:38 a.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40681/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 12:38 a.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See MESOS-3793 for more details.
>
>
> Diffs
> -----
>
> src/local/local.cpp d714eb148fa8db2cbbe23175ab859e50eec9036f
>
> Diff: https://reviews.apache.org/r/40681/diff/
>
>
> Testing
> -------
>
> Tested the changes in docker (ubuntu:14.04).
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 40681: Changed mesos-local to use posix launcher as
default.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40681/#review108021
-----------------------------------------------------------
Ship it!
Will fix the issue Bernd noted and commit.
- Till Toenshoff
On Nov. 25, 2015, 4:01 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40681/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 4:01 p.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Bugs: MESOS-3793
> https://issues.apache.org/jira/browse/MESOS-3793
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See MESOS-3793 for more details.
>
>
> Diffs
> -----
>
> src/local/local.cpp d714eb148fa8db2cbbe23175ab859e50eec9036f
>
> Diff: https://reviews.apache.org/r/40681/diff/
>
>
> Testing
> -------
>
> Tested the changes in docker (ubuntu:14.04).
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 40681: Changed mesos-local to use posix launcher as
default.
Posted by Jojy Varghese <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40681/
-----------------------------------------------------------
(Updated Nov. 25, 2015, 4:01 p.m.)
Review request for mesos, Jie Yu and Timothy Chen.
Bugs: MESOS-3793
https://issues.apache.org/jira/browse/MESOS-3793
Repository: mesos
Description
-------
See MESOS-3793 for more details.
Diffs
-----
src/local/local.cpp d714eb148fa8db2cbbe23175ab859e50eec9036f
Diff: https://reviews.apache.org/r/40681/diff/
Testing
-------
Tested the changes in docker (ubuntu:14.04).
Thanks,
Jojy Varghese
Re: Review Request 40681: Changed mesos-local to use posix launcher as
default.
Posted by Till Toenshoff <to...@me.com>.
> On Nov. 25, 2015, 11:57 a.m., Bernd Mathiske wrote:
> > src/local/local.cpp, line 373
> > <https://reviews.apache.org/r/40681/diff/1/?file=1139379#file1139379line373>
> >
> > !isSome() -> isNone()
Will fix while committing.
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40681/#review107973
-----------------------------------------------------------
On Nov. 25, 2015, 12:38 a.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40681/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 12:38 a.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See MESOS-3793 for more details.
>
>
> Diffs
> -----
>
> src/local/local.cpp d714eb148fa8db2cbbe23175ab859e50eec9036f
>
> Diff: https://reviews.apache.org/r/40681/diff/
>
>
> Testing
> -------
>
> Tested the changes in docker (ubuntu:14.04).
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 40681: Changed mesos-local to use posix launcher as
default.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40681/#review107973
-----------------------------------------------------------
Ship it!
src/local/local.cpp (line 373)
<https://reviews.apache.org/r/40681/#comment167318>
!isSome() -> isNone()
- Bernd Mathiske
On Nov. 24, 2015, 4:38 p.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40681/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2015, 4:38 p.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See MESOS-3793 for more details.
>
>
> Diffs
> -----
>
> src/local/local.cpp d714eb148fa8db2cbbe23175ab859e50eec9036f
>
> Diff: https://reviews.apache.org/r/40681/diff/
>
>
> Testing
> -------
>
> Tested the changes in docker (ubuntu:14.04).
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 40681: Changed mesos-local to use posix launcher as
default.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40681/#review107960
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40681]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Nov. 25, 2015, 12:38 a.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40681/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 12:38 a.m.)
>
>
> Review request for mesos, Jie Yu and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See MESOS-3793 for more details.
>
>
> Diffs
> -----
>
> src/local/local.cpp d714eb148fa8db2cbbe23175ab859e50eec9036f
>
> Diff: https://reviews.apache.org/r/40681/diff/
>
>
> Testing
> -------
>
> Tested the changes in docker (ubuntu:14.04).
>
>
> Thanks,
>
> Jojy Varghese
>
>