You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/08 16:06:03 UTC
[GitHub] [arrow] raulcd opened a new pull request, #12840: ARROW-15905: [Python][C++] Use find_package to add FindPkgConfig.cmak…
raulcd opened a new pull request, #12840:
URL: https://github.com/apache/arrow/pull/12840
Use `find_package` to add `FindPkgConfig.cmake` instead of `include(FindPkgConfig)` to avoid warning being raised.
Before the change when building pyarrow I could see the following warning:
```shell
CMake Warning (dev) at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
The package name passed to `find_package_handle_standard_args` (PkgConfig)
does not match the name of the calling package (Arrow). This can lead to
problems in calling code that expects `find_package` result variables
(e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
/usr/share/cmake/Modules/FindPkgConfig.cmake:99 (find_package_handle_standard_args)
cmake_modules/FindArrow.cmake:39 (include)
cmake_modules/FindArrowPython.cmake:47 (find_package)
CMakeLists.txt:231 (find_package)
This warning is for project developers. Use -Wno-dev to suppress it.
```
With the change the Warning disappears.
The rationale for the change comes from some investigation over the [find_package](https://cmake.org/cmake/help/latest/command/find_package.html?highlight=find_package) and [include](https://cmake.org/cmake/help/latest/command/include.html?highlight=include) documentation and this [stackoverflow thread](https://stackoverflow.com/a/29316084)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #12840: ARROW-15905: [Python][C++] Fix CMake warning when building PyArrow
Posted by GitBox <gi...@apache.org>.
kou closed pull request #12840: ARROW-15905: [Python][C++] Fix CMake warning when building PyArrow
URL: https://github.com/apache/arrow/pull/12840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12840: ARROW-15905: [Python][C++] Use find_package to add FindPkgConfig.cmak…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12840:
URL: https://github.com/apache/arrow/pull/12840#issuecomment-1093045367
https://issues.apache.org/jira/browse/ARROW-15905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12840: ARROW-15905: [Python][C++] Fix CMake warning when building PyArrow
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #12840:
URL: https://github.com/apache/arrow/pull/12840#issuecomment-1094110588
Benchmark runs are scheduled for baseline = d197ad31c3d7c16ecee74cb76a71ce397e905b3b and contender = 29f387344dc03d00ba2c99aaca20faa9d5d35683. 29f387344dc03d00ba2c99aaca20faa9d5d35683 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5198e9b8efad426895b1d387aa91ffd2...c89cb70b70cc46a6b442880efc46d61e/)
[Finished :arrow_down:0.17% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/5d5faa6af0b749e8b892545f4e3981c1...3313f41f92e24e8baa2b8fd07f1a84e4/)
[Failed :arrow_down:1.08% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/58510cab46dc4f12b216360e11b226c1...e643a089264c485da0c140f37305cbe8/)
[Finished :arrow_down:0.13% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/bd6f2814f22e4171aa397a2570335b06...beb21455055a41049df3dc75d78cab14/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/479| `29f38734` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/464| `29f38734` test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/465| `29f38734` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/474| `29f38734` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/478| `d197ad31` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/463| `d197ad31` test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/464| `d197ad31` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/473| `d197ad31` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] amol- commented on pull request #12840: ARROW-15905: [Python][C++] Fix CMake warning when building PyArrow
Posted by GitBox <gi...@apache.org>.
amol- commented on PR #12840:
URL: https://github.com/apache/arrow/pull/12840#issuecomment-1093064574
@kou would you mind checking if we can approve this one and ship it? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org