You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/10/20 09:08:56 UTC

[GitHub] [ignite] rpuch opened a new pull request #9503: IGNITE-15416 False warnings from default Checkpoint and Collision SPIs

rpuch opened a new pull request #9503:
URL: https://github.com/apache/ignite/pull/9503


   - The following warning was written to log when starting with the default CheckpointSpi (NoOpCheckpointSpi):
   WARNING: Checkpoints are disabled (to enable configure any GridCheckpointSpi implementation)
   This happens even if the user does not use checkpointing at all. In such a case, we should not log this message, but instead it was logged as a WARNING which was confusing.
   The change is that now we log it only on the first attempt to actually save/load/remove a checkpoint, not at startup time.
   
   - The following was written to log when starting without collision resolution configuration:
   WARNING: Collision resolution is disabled (all jobs will be activated upon arrival).
   This is the normal mode, and it should not be a warning.
   The change is to log it at INFO level.
   
   Thank you for submitting the pull request to the Apache Ignite.
   
   In order to streamline the review of the contribution 
   we ask you to ensure the following steps have been taken:
   
   ### The Contribution Checklist
   - [ ] There is a single JIRA ticket related to the pull request. 
   - [ ] The web-link to the pull request is attached to the JIRA ticket.
   - [ ] The JIRA ticket has the _Patch Available_ state.
   - [ ] The pull request body describes changes that have been made. 
   The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
   - [ ] The pull request title is treated as the final commit message. 
   The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
   - [ ] A reviewer has been mentioned through the JIRA comments 
   (see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers)) 
   - [ ] The pull request has been checked by the Teamcity Bot and 
   the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
   
   ### Notes
   - [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
   - [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
   - [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
   - [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
   
   If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] rpuch commented on pull request #9503: IGNITE-15416 False warnings from default Checkpoint and Collision SPIs

Posted by GitBox <gi...@apache.org>.
rpuch commented on pull request #9503:
URL: https://github.com/apache/ignite/pull/9503#issuecomment-948776733


   Hello @kukushal 
   
   Thank you for your review and your suggestions. I've made the following changes:
   
   1. Converted the test you mentioned from an integration test to a unit test
   2. Switched from using log4j `Appender` to a mock to assert that the message of interest is logged using an expected log level.
   
   Could you please take a look at the PR again?
   
   The suite including the related test is rerun successfully: https://ci.ignite.apache.org/viewLog.html?buildId=6233444&buildTypeId=IgniteTests24Java8_ComputeGrid


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] asfgit closed pull request #9503: IGNITE-15416 False warnings from default Checkpoint and Collision SPIs

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #9503:
URL: https://github.com/apache/ignite/pull/9503


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org