You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/08/04 21:25:51 UTC
Re: Review Request 23868: Added a ping timeout in the slave to trigger a
re-detection.
> On July 24, 2014, 10:08 p.m., Jiang Yan Xu wrote:
> > src/slave/slave.cpp, line 2366
> > <https://reviews.apache.org/r/23868/diff/2/?file=641177#file641177line2366>
> >
> > Should we check "pingTimer.timeout().expired()?"
> >
> > If the slave receives a ping before the timer times out but its queue backed up and thus the timer isn't cancelled. The timer then times out and dispatches a redetect() that is executed after ping(), we don't really need to redetect right?
Thanks for bringing this case up!
I've added this check with a comment, I've also now renamed 'redetect' to 'pingTimeout' since it is specific to the ping timeout now.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23868/#review48685
-----------------------------------------------------------
On July 24, 2014, 2:55 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23868/
> -----------------------------------------------------------
>
> (Updated July 24, 2014, 2:55 a.m.)
>
>
> Review request for mesos, Vinod Kone and Jiang Yan Xu.
>
>
> Bugs: MESOS-1529
> https://issues.apache.org/jira/browse/MESOS-1529
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This is the first step in MESOS-1529.
>
> If we get into a situation where the slave thinks it is registered, but the master does not, then the slave should re-register. This situation can be often be detected on the slave side when the slave is no longer receiving pings from the master.
>
>
> Diffs
> -----
>
> src/master/constants.hpp 8ace682bc58e4fae65038906a4abec5879f35020
> src/slave/constants.hpp 97dc1b30fa81000ea60223c4059a0a64d27e91c4
> src/slave/constants.cpp a75b1ef8eddeb55350810b36ac35136d2e5d6f9d
> src/slave/slave.hpp a896bb66db5d8cd27ef02b6498c9db93cb0d525f
> src/slave/slave.cpp 1d5691836822c8587e1aa8ed24860a8012c67a6e
> src/tests/slave_tests.cpp e45255a6f699e51bf09397da95a5a11edbabe591
>
> Diff: https://reviews.apache.org/r/23868/diff/
>
>
> Testing
> -------
>
> Added tests.
>
>
> Thanks,
>
> Ben Mahler
>
>