[GitHub] [yunikorn-k8shim] wilfred-s commented on pull request #532: [YUNIKORN-1555] Filter out terminated pods during recovery

["wilfred-s (via GitHub)" <gi...@apache.org>]

wilfred-s commented on PR #532:
URL: https://github.com/apache/yunikorn-k8shim/pull/532#issuecomment-1441839673

   The pod event handler will only be called if there is a new, updated or deleted pod while we are recovering the pods on the  list. The pods events that get cached during the recovery are not processed until after the recovery is done (see `PodEventHandlerRecoveryDone()`). At that point filtering out pod that have finished could mean that you miss a valid event. A pod received as part of the list might be running. While the pod recovery is processing the pod exits and thus goes into a finished state. You need that event to correctly delete the allocation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org