[GitHub] [hadoop] ayushtkn commented on a change in pull request #4067: HDFS-16503. Should verify whether the path name is valid in the WebHDFS

[GitBox <gi...@apache.org>]

ayushtkn commented on a change in pull request #4067:
URL: https://github.com/apache/hadoop/pull/4067#discussion_r825919814



##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/TestWebHDFS.java
##########
@@ -522,6 +523,38 @@ public void testCreateWithNoDN() throws Exception {
     }
   }
 
+  @Test
+  public void testWebHdfsCreateWithInvalidPath() throws Exception {
+    final Configuration conf = WebHdfsTestUtil.createConf();
+    cluster = new MiniDFSCluster.Builder(conf).numDataNodes(1).build();

Review comment:
       do you need a datanode, if you aren't writing any data, you can survive with 0 datanodes as well?
   btw if not, the default is 1 only, you don't need to explicitly put one there. IIRC




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org