You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/08 08:34:51 UTC

[GitHub] [incubator-superset] kgabryje opened a new pull request #11960: fix: Altered button crashing and title not updating on Explore view

kgabryje opened a new pull request #11960:
URL: https://github.com/apache/incubator-superset/pull/11960


   ### SUMMARY
   Fixes bugs https://github.com/apache/incubator-superset/issues/11623 and https://github.com/apache/incubator-superset/issues/11835. `AlteredSliceTag` was crashing because it was using a `ListView` component, which requires access to React Router to work (which Explore view doesn't have). I replaced it with newer `TableView` to display a table.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   Manually verify that bugs don't occur anymore.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: https://github.com/apache/incubator-superset/issues/11623, https://github.com/apache/incubator-superset/issues/11835
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   CC: @junlincc
   @adam-stasiak Can you please test it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io commented on pull request #11960: fix: Altered button crashing and title not updating on Explore view

Posted by GitBox <gi...@apache.org>.

codecov-io commented on pull request #11960:
URL: https://github.com/apache/incubator-superset/pull/11960#issuecomment-740481964


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=h1) Report
   > Merging [#11960](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=desc) (f98f783) into [master](https://codecov.io/gh/apache/incubator-superset/commit/05258ebc6cb680b41b0cd1868555e6766c0eb35c?el=desc) (05258eb) will **decrease** coverage by `3.39%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11960/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11960      +/-   ##
   ==========================================
   - Coverage   66.69%   63.30%   -3.40%     
   ==========================================
     Files         941      465     -476     
     Lines       45657    28584   -17073     
     Branches     4360        0    -4360     
   ==========================================
   - Hits        30453    18094   -12359     
   + Misses      15075    10490    -4585     
   + Partials      129        0     -129     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.30% <ø> (-0.96%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `32.65% <0.00%> (-59.19%)` | :arrow_down: |
   | [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
   | [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `83.80% <0.00%> (-5.27%)` | :arrow_down: |
   | ... and [495 more](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=footer). Last update [05258eb...f98f783](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #11960: fix: Altered button crashing and title not updating on Explore view

Posted by GitBox <gi...@apache.org>.

graceguo-supercat edited a comment on pull request #11960:
URL: https://github.com/apache/incubator-superset/pull/11960#issuecomment-747123333


   Click-edit chart title is correct behavior:
   - when you done edit, title change is not saved to database.
   - when you click on Save Button, title change will be saved to database.
   
   We had this behavior for a long time (before Properties Modal exists). Why do we want to change this behavior?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] kgabryje commented on pull request #11960: fix: Altered button crashing and title not updating on Explore view

Posted by GitBox <gi...@apache.org>.

kgabryje commented on pull request #11960:
URL: https://github.com/apache/incubator-superset/pull/11960#issuecomment-742401177


   @junlincc Fixed
   ![ezgif com-gif-maker (5)](https://user-images.githubusercontent.com/15073128/101753718-3f555700-3ad3-11eb-8c2b-e822cf7432e1.gif)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11960: fix: Altered button crashing and title not updating on Explore view

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11960:
URL: https://github.com/apache/incubator-superset/pull/11960#issuecomment-740481964


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=h1) Report
   > Merging [#11960](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=desc) (876be6a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/05258ebc6cb680b41b0cd1868555e6766c0eb35c?el=desc) (05258eb) will **decrease** coverage by `3.47%`.
   > The diff coverage is `66.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11960/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11960      +/-   ##
   ==========================================
   - Coverage   66.69%   63.22%   -3.48%     
   ==========================================
     Files         941      942       +1     
     Lines       45657    45814     +157     
     Branches     4360     4398      +38     
   ==========================================
   - Hits        30453    28967    -1486     
   - Misses      15075    16671    +1596     
   - Partials      129      176      +47     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `62.73% <66.66%> (-0.17%)` | :arrow_down: |
   | python | `63.51% <ø> (-0.74%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `96.00% <ø> (+10.60%)` | :arrow_up: |
   | [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `32.14% <0.00%> (-9.68%)` | :arrow_down: |
   | [...rontend/src/explore/components/PropertiesModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Qcm9wZXJ0aWVzTW9kYWwudHN4) | `56.94% <100.00%> (-3.06%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [181 more](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=footer). Last update [05258eb...876be6a](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #11960: fix: Altered button crashing and title not updating on Explore view

Posted by GitBox <gi...@apache.org>.

graceguo-supercat edited a comment on pull request #11960:
URL: https://github.com/apache/incubator-superset/pull/11960#issuecomment-747123333


   Click-edit chart title is correct behavior:
   - when you done edit, title change is front-end only, it is not saved to database.
   - when you click on Save Button, title change will be saved to database.
   
   We had this behavior for a long time (before Properties Modal exists). Why do we want to change this behavior?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #11960: fix: Altered button crashing and title not updating on Explore view

Posted by GitBox <gi...@apache.org>.

graceguo-supercat edited a comment on pull request #11960:
URL: https://github.com/apache/incubator-superset/pull/11960#issuecomment-747123333

Click-edit chart title is correct behavior:
- when you done edit, title change is front-end only, it is not saved to database.
- when you open Save Modal, the changed title will show in the Save Modal.
- when you click on Save button, title change will be saved to database.

We had this behavior for a long time (before Properties Modal exists). Why do we want to change this behavior?

I think the problem is the Properties Modal: chart title and Save Modal all read/update content from redux store, while Properties Modal didn't. That's the reason its content is always out of sync with global redux store. Please check how redux work in explore view.

Or, you can remove edit chart title from Properties Modal? I feel there are so many places we can edit chart title, this seems a little redundant.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11960: fix: Altered button crashing and title not updating on Explore view

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11960:
URL: https://github.com/apache/incubator-superset/pull/11960#issuecomment-740481964


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=h1) Report
   > Merging [#11960](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=desc) (876be6a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/05258ebc6cb680b41b0cd1868555e6766c0eb35c?el=desc) (05258eb) will **decrease** coverage by `3.18%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11960/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11960      +/-   ##
   ==========================================
   - Coverage   66.69%   63.51%   -3.19%     
   ==========================================
     Files         941      466     -475     
     Lines       45657    28697   -16960     
     Branches     4360        0    -4360     
   ==========================================
   - Hits        30453    18228   -12225     
   + Misses      15075    10469    -4606     
   + Partials      129        0     -129     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.51% <ø> (-0.74%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/examples/energy.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZW5lcmd5LnB5) | `27.50% <0.00%> (-72.50%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/reports/commands/execute.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.50% <0.00%> (-3.80%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/reports/commands/alert.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `88.67% <0.00%> (-3.33%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | ... and [494 more](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=footer). Last update [05258eb...876be6a](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11960: fix: Altered button crashing and title not updating on Explore view

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11960:
URL: https://github.com/apache/incubator-superset/pull/11960#issuecomment-740481964






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] adam-stasiak commented on pull request #11960: fix: Altered button crashing and title not updating on Explore view

Posted by GitBox <gi...@apache.org>.

adam-stasiak commented on pull request #11960:
URL: https://github.com/apache/incubator-superset/pull/11960#issuecomment-743205153


   I can see one issue with current flow.
   I am able to modify title for chart without modal:
   ![image](https://user-images.githubusercontent.com/25153919/101911012-1363cf80-3bc0-11eb-84d1-c27bf99d5547.png)
   But then change is not populated to edit chart modals:
   ![image](https://user-images.githubusercontent.com/25153919/101911104-342c2500-3bc0-11eb-82ad-14b1e2e103be.png)
   
   When I open SAVE modal then I can see name change populated there. 
   ![image](https://user-images.githubusercontent.com/25153919/101911409-9d139d00-3bc0-11eb-9440-20dcb0a7663c.png)
   
   I think when this operation needs save step it should be displayed in ALTERED description that user changed popup at least to show that SAVE operation is needed.
   
   Could you @junlincc describe how it should work?
   My proposals are:
   - remove edit title without modal option
   - add altered information when user modified title without save to indicate need of save step
   - fix showing this edited title in edit modals as well
   
   I think it is needed to create seperated PR for this.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] junlincc commented on pull request #11960: fix: Altered button crashing and title not updating on Explore view

Posted by GitBox <gi...@apache.org>.

junlincc commented on pull request #11960:
URL: https://github.com/apache/incubator-superset/pull/11960#issuecomment-740850914


   manul tested, LGTM. @nytai can you help review and merge this PR? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11960: fix: Altered button crashing and title not updating on Explore view

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11960:
URL: https://github.com/apache/incubator-superset/pull/11960#issuecomment-740481964


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=h1) Report
   > Merging [#11960](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=desc) (f98f783) into [master](https://codecov.io/gh/apache/incubator-superset/commit/05258ebc6cb680b41b0cd1868555e6766c0eb35c?el=desc) (05258eb) will **decrease** coverage by `2.74%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11960/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11960      +/-   ##
   ==========================================
   - Coverage   66.69%   63.95%   -2.75%     
   ==========================================
     Files         941      465     -476     
     Lines       45657    28599   -17058     
     Branches     4360        0    -4360     
   ==========================================
   - Hits        30453    18290   -12163     
   + Misses      15075    10309    -4766     
   + Partials      129        0     -129     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.95% <ø> (-0.31%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-8.59%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `82.14% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
   | [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `87.44% <0.00%> (-1.62%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.80% <0.00%> (-1.09%)` | :arrow_down: |
   | ... and [479 more](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=footer). Last update [05258eb...f98f783](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #11960: fix: Altered button crashing and title not updating on Explore view

Posted by GitBox <gi...@apache.org>.

graceguo-supercat edited a comment on pull request #11960:
URL: https://github.com/apache/incubator-superset/pull/11960#issuecomment-747123333


   Click-edit chart title is correct behavior:
   - when you done edit, title change is not saved to database.
   - when you click on Save Button, title change will be saved to database.
   We had this behavior for a long time (before Properties Modal exists). Why do we want to change this behavior?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] junlincc removed a comment on pull request #11960: fix: Altered button crashing and title not updating on Explore view

Posted by GitBox <gi...@apache.org>.

junlincc removed a comment on pull request #11960:
URL: https://github.com/apache/incubator-superset/pull/11960#issuecomment-740850914


   manul tested, LGTM. @nytai can you help review and merge this PR? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11960: fix: Altered button crashing and title not updating on Explore view

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11960:
URL: https://github.com/apache/incubator-superset/pull/11960#issuecomment-740481964


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=h1) Report
   > Merging [#11960](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=desc) (876be6a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/05258ebc6cb680b41b0cd1868555e6766c0eb35c?el=desc) (05258eb) will **decrease** coverage by `3.33%`.
   > The diff coverage is `66.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11960/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11960      +/-   ##
   ==========================================
   - Coverage   66.69%   63.36%   -3.34%     
   ==========================================
     Files         941      942       +1     
     Lines       45657    45814     +157     
     Branches     4360     4398      +38     
   ==========================================
   - Hits        30453    29032    -1421     
   - Misses      15075    16606    +1531     
   - Partials      129      176      +47     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `62.73% <66.66%> (-0.17%)` | :arrow_down: |
   | python | `63.74% <ø> (-0.52%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `96.00% <ø> (+10.60%)` | :arrow_up: |
   | [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `32.14% <0.00%> (-9.68%)` | :arrow_down: |
   | [...rontend/src/explore/components/PropertiesModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Qcm9wZXJ0aWVzTW9kYWwudHN4) | `56.94% <100.00%> (-3.06%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [178 more](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=footer). Last update [05258eb...876be6a](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11960: fix: Altered button crashing and title not updating on Explore view

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11960:
URL: https://github.com/apache/incubator-superset/pull/11960#issuecomment-740481964


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=h1) Report
   > Merging [#11960](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=desc) (f98f783) into [master](https://codecov.io/gh/apache/incubator-superset/commit/05258ebc6cb680b41b0cd1868555e6766c0eb35c?el=desc) (05258eb) will **increase** coverage by `0.80%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11960/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11960      +/-   ##
   ==========================================
   + Coverage   66.69%   67.50%   +0.80%     
   ==========================================
     Files         941      941              
     Lines       45657    45644      -13     
     Branches     4360     4386      +26     
   ==========================================
   + Hits        30453    30810     +357     
   + Misses      15075    14727     -348     
   + Partials      129      107      -22     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `54.18% <0.00%> (+7.02%)` | :arrow_up: |
   | javascript | `62.94% <0.00%> (+0.03%)` | :arrow_up: |
   | python | `64.12% <ø> (-0.14%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `98.66% <ø> (+13.27%)` | :arrow_up: |
   | [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `53.57% <0.00%> (+11.75%)` | :arrow_up: |
   | [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-7.60%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `76.12% <0.00%> (-5.17%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `60.25% <0.00%> (-4.06%)` | :arrow_down: |
   | ... and [74 more](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=footer). Last update [05258eb...f98f783](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #11960: fix: Altered button crashing and title not updating on Explore view

Posted by GitBox <gi...@apache.org>.

graceguo-supercat edited a comment on pull request #11960:
URL: https://github.com/apache/incubator-superset/pull/11960#issuecomment-747123333


   Click-edit chart title is correct behavior:
   - when you done edit, title change is front-end only, it is not saved to database.
   - when you open Save Modal, the changed title will show in the Save Modal.
   - when you click on Save button, title change will be saved to database.
   
   We had this behavior for a long time (before Properties Modal exists). Why do we want to change this behavior?
   
   I think the problem is the Properties Modal: chart title and Save Modal all read/update content from redux store, while Properties Modal didn't. That's the reason its content is always out of sync with global redux store. Please check how redux work in explore view. 
   
   Or, you can remove edit chart title from Properties Modal? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas merged pull request #11960: fix: Altered button crashing and title not updating on Explore view

Posted by GitBox <gi...@apache.org>.

rusackas merged pull request #11960:
URL: https://github.com/apache/incubator-superset/pull/11960


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11960: fix: Altered button crashing and title not updating on Explore view

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11960:
URL: https://github.com/apache/incubator-superset/pull/11960#issuecomment-740481964


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=h1) Report
   > Merging [#11960](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=desc) (f98f783) into [master](https://codecov.io/gh/apache/incubator-superset/commit/05258ebc6cb680b41b0cd1868555e6766c0eb35c?el=desc) (05258eb) will **increase** coverage by `0.92%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11960/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11960      +/-   ##
   ==========================================
   + Coverage   66.69%   67.62%   +0.92%     
   ==========================================
     Files         941      941              
     Lines       45657    45644      -13     
     Branches     4360     4386      +26     
   ==========================================
   + Hits        30453    30866     +413     
   + Misses      15075    14675     -400     
   + Partials      129      103      -26     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `54.75% <0.00%> (+7.60%)` | :arrow_up: |
   | javascript | `62.94% <0.00%> (+0.03%)` | :arrow_up: |
   | python | `64.12% <ø> (-0.14%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `98.66% <ø> (+13.27%)` | :arrow_up: |
   | [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `53.57% <0.00%> (+11.75%)` | :arrow_up: |
   | [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `83.67% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
   | [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `87.44% <0.00%> (-1.62%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.07% <0.00%> (-0.82%)` | :arrow_down: |
   | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `79.51% <0.00%> (-0.49%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.24% <0.00%> (-0.47%)` | :arrow_down: |
   | ... and [66 more](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=footer). Last update [05258eb...f98f783](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] graceguo-supercat commented on pull request #11960: fix: Altered button crashing and title not updating on Explore view

Posted by GitBox <gi...@apache.org>.

graceguo-supercat commented on pull request #11960:
URL: https://github.com/apache/incubator-superset/pull/11960#issuecomment-747123333


   Click-edit chart title is correct behavior, and it should be saved to database when you done edit.
   We had this behavior for a long time (before Properties Modal exists). why do we want to change this behavior?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11960: fix: Altered button crashing and title not updating on Explore view

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11960:
URL: https://github.com/apache/incubator-superset/pull/11960#issuecomment-740481964


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=h1) Report
   > Merging [#11960](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=desc) (f98f783) into [master](https://codecov.io/gh/apache/incubator-superset/commit/05258ebc6cb680b41b0cd1868555e6766c0eb35c?el=desc) (05258eb) will **decrease** coverage by `3.01%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11960/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11960      +/-   ##
   ==========================================
   - Coverage   66.69%   63.68%   -3.02%     
   ==========================================
     Files         941      941              
     Lines       45657    45634      -23     
     Branches     4360     4386      +26     
   ==========================================
   - Hits        30453    29060    -1393     
   - Misses      15075    16397    +1322     
   - Partials      129      177      +48     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `62.94% <0.00%> (+0.03%)` | :arrow_up: |
   | python | `64.12% <ø> (-0.14%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...perset-frontend/src/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `96.00% <ø> (+10.60%)` | :arrow_up: |
   | [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `32.14% <0.00%> (-9.68%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [149 more](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=footer). Last update [05258eb...f98f783](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11960: fix: Altered button crashing and title not updating on Explore view

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #11960:
URL: https://github.com/apache/incubator-superset/pull/11960#issuecomment-740481964


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=h1) Report
   > Merging [#11960](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=desc) (876be6a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/05258ebc6cb680b41b0cd1868555e6766c0eb35c?el=desc) (05258eb) will **decrease** coverage by `3.17%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11960/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11960      +/-   ##
   ==========================================
   - Coverage   66.69%   63.51%   -3.18%     
   ==========================================
     Files         941      466     -475     
     Lines       45657    28695   -16962     
     Branches     4360        0    -4360     
   ==========================================
   - Hits        30453    18227   -12226     
   + Misses      15075    10468    -4607     
   + Partials      129        0     -129     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | cypress | `?` | |
   | javascript | `?` | |
   | python | `63.51% <ø> (-0.74%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/examples/energy.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZW5lcmd5LnB5) | `27.50% <0.00%> (-72.50%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
   | [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
   | [superset/reports/commands/execute.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `92.50% <0.00%> (-3.80%)` | :arrow_down: |
   | [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
   | [superset/reports/commands/alert.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9hbGVydC5weQ==) | `88.67% <0.00%> (-3.33%)` | :arrow_down: |
   | [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
   | ... and [495 more](https://codecov.io/gh/apache/incubator-superset/pull/11960/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=footer). Last update [05258eb...876be6a](https://codecov.io/gh/apache/incubator-superset/pull/11960?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #11960: fix: Altered button crashing and title not updating on Explore view

Posted by GitBox <gi...@apache.org>.

graceguo-supercat edited a comment on pull request #11960:
URL: https://github.com/apache/incubator-superset/pull/11960#issuecomment-747123333


   Click-edit chart title is correct behavior:
   - when you done edit, title change is front-end only, it is not saved to database.
   - when you open Save Modal, the changed title will show in the Save Modal.
   - when you click on Save button, title change will be saved to database.
   
   We had this behavior for a long time (before Properties Modal exists). Why do we want to change this behavior?
   
   I think the problem is the Properties Modal: chart title and Save Modal all read/update content from redux store, while Properties Modal didn't. That's the reason its content is always out of sync with global redux store. Please check how redux work in explore view. 
   
   Or, you can remove edit chart title from Properties Modal. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] kgabryje commented on pull request #11960: fix: Altered button crashing and title not updating on Explore view

Posted by GitBox <gi...@apache.org>.

kgabryje commented on pull request #11960:
URL: https://github.com/apache/incubator-superset/pull/11960#issuecomment-742606247


   closes #11623 #11835


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org