You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@fineract.apache.org by Lionel Raymundi - Poincenot <li...@poincenot.com> on 2017/02/16 15:01:46 UTC
Loan Topup disburse when loan to be closed has transactions made on
the same date
Hi guys,
There is a business validation on a loan topup operation, which prevents
you to set the disbusement date of the new loan if the previous one has
transactions on the same date (or later):
error.msg.loan.disbursal.date.should.be.after.last.
transaction.date.of.loan.to.be.closed
It is not that unusual that we ask the client to settle some overdued
installments before we disbuse the new loan, as a willingness to
pay demonstration. And is not that unusual that the repayments are done the
same day of the disbursement of the new Loan.
So the question is: Could the validation be modified to check only for
transactions made later than the disbursement date, but not on the same
date? Or is it a business validation that must remain as is?
I hope I made myself clear, please dont hesitate on asking me if I didn't...
Regards
Lionel
Re: Loan Topup disburse when loan to be closed has transactions made
on the same date
Posted by Lionel Raymundi - Poincenot <li...@poincenot.com>.
Hi,
I've opened the PR #298 with the required modifications. Let me know if its
OK
Regards
Lionel
2017-02-23 10:02 GMT-03:00 Nazeer Shaik <
nazeer.shaik@confluxtechnologies.com>:
> Yes these changes should be applicable for create, modify, approve,
> disburse. We will review and merge the changes once you send PR.
>
> Thanks Lionel.
>
> Thanks,
> Nazeer
>
> *Principal Architect, **Conflux Technologies Pvt Ltd
> <http://www.confluxtechnologies.com/>*
>
> *Address*: #304, 2nd Floor, 7th Main Road, HRBR Layout 1st Block,
> Bengaluru, Karnataka, 560043 INDIA
>
>
> Disclaimer: The information contained in this e-mail message and any
> files/attachment transmitted with it is confidential and for the sole use
> of the intended recipient(s) or entity identified. If you are not the
> intended recipient, please email: support@confluxtechnologies.com and
> destroy/delete all copies and attachment thereto along with the original
> message. Any unauthorized review, use, disclosure, dissemination,
> forwarding, printing or copying of this email or any action taken in
> reliance on this e-mail is strictly prohibited and is unlawful. The
> recipient acknowledges that Conflux Technologies Private Limited or its
> subsidiaries and associated companies are unable to exercise control or
> ensure or guarantee the integrity of/over the contents of the information
> contained in e-mail transmissions. Before opening any attachments, please
> check.
>
> On Thu, Feb 23, 2017 at 6:24 PM, Lionel Raymundi - Poincenot <
> lionel@poincenot.com> wrote:
>
> > Great, thanks. I added a comment to the jira issue because it also
> happens
> > when trying to approve, modify or finally disburse the topup loan.
> > If you agree, we can commit the changes and create a new pull request
> >
> > Regards
> >
> > Lionel
> >
> > 2017-02-23 9:15 GMT-03:00 Santosh Math <santosh@confluxtechnologies.com
> >:
> >
> > > Hi Nazeer,
> > >
> > > I have rised the issue in the following link as improvement
> > >
> > > https://issues.apache.org/jira/browse/FINERACT-406
> > >
> > > On Thu, Feb 23, 2017 at 5:34 PM, Nazeer Shaik <
> > > nazeer.shaik@confluxtechnologies.com> wrote:
> > >
> > > > Hi Lionel,
> > > >
> > > > I agree with your opinion. New loan disbursement date should be on or
> > > after
> > > > the last transaction date of previous loan.
> > > >
> > > > @Santosh, can you please raise a jira issue for the same.
> > > >
> > > > Thanks,
> > > > Nazeer
> > > >
> > > > Thanks,
> > > > Nazeer
> > > >
> > > > *Principal Architect, **Conflux Technologies Pvt Ltd
> > > > <http://www.confluxtechnologies.com/>*
> > > >
> > > > *Address*: #304, 2nd Floor, 7th Main Road, HRBR Layout 1st Block,
> > > > Bengaluru, Karnataka, 560043 INDIA
> > > >
> > > >
> > > > Disclaimer: The information contained in this e-mail message and any
> > > > files/attachment transmitted with it is confidential and for the sole
> > use
> > > > of the intended recipient(s) or entity identified. If you are not the
> > > > intended recipient, please email: support@confluxtechnologies.com
> and
> > > > destroy/delete all copies and attachment thereto along with the
> > original
> > > > message. Any unauthorized review, use, disclosure, dissemination,
> > > > forwarding, printing or copying of this email or any action taken in
> > > > reliance on this e-mail is strictly prohibited and is unlawful. The
> > > > recipient acknowledges that Conflux Technologies Private Limited or
> its
> > > > subsidiaries and associated companies are unable to exercise control
> or
> > > > ensure or guarantee the integrity of/over the contents of the
> > information
> > > > contained in e-mail transmissions. Before opening any attachments,
> > please
> > > > check.
> > > >
> > > > On Tue, Feb 21, 2017 at 6:14 PM, Lionel Raymundi - Poincenot <
> > > > lionel@poincenot.com> wrote:
> > > >
> > > > > Hello devs,
> > > > >
> > > > > Did you have the chance to look at my previous email?
> > > > > We can make the modification (we did, in fact), but I don't know if
> > it
> > > > has
> > > > > deeper implications. Do you think its a change to be pushed to the
> > > > > mainstream?
> > > > >
> > > > > Thanks
> > > > >
> > > > > Lionel
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > 2017-02-16 12:01 GMT-03:00 Lionel Raymundi - Poincenot <
> > > > > lionel@poincenot.com
> > > > > >:
> > > > >
> > > > > > Hi guys,
> > > > > >
> > > > > > There is a business validation on a loan topup operation, which
> > > > prevents
> > > > > > you to set the disbusement date of the new loan if the previous
> one
> > > has
> > > > > > transactions on the same date (or later):
> > > > > >
> > > > > > error.msg.loan.disbursal.date.should.be.after.last.transacti
> > > > > > on.date.of.loan.to.be.closed
> > > > > >
> > > > > > It is not that unusual that we ask the client to settle some
> > overdued
> > > > > > installments before we disbuse the new loan, as a willingness to
> > > > > > pay demonstration. And is not that unusual that the repayments
> are
> > > done
> > > > > the
> > > > > > same day of the disbursement of the new Loan.
> > > > > >
> > > > > > So the question is: Could the validation be modified to check
> only
> > > for
> > > > > > transactions made later than the disbursement date, but not on
> the
> > > same
> > > > > > date? Or is it a business validation that must remain as is?
> > > > > >
> > > > > > I hope I made myself clear, please dont hesitate on asking me if
> I
> > > > > > didn't...
> > > > > >
> > > > > > Regards
> > > > > >
> > > > > > Lionel
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Thanks and Regards
> > > Santosh
> > > QA Team
> > > Conflux Technologies Pvt Ltd, Bengaluru
> > > Skype:santoshmath99
> > >
> >
>
Re: Loan Topup disburse when loan to be closed has transactions made
on the same date
Posted by Nazeer Shaik <na...@confluxtechnologies.com>.
Yes these changes should be applicable for create, modify, approve,
disburse. We will review and merge the changes once you send PR.
Thanks Lionel.
Thanks,
Nazeer
*Principal Architect, **Conflux Technologies Pvt Ltd
<http://www.confluxtechnologies.com/>*
*Address*: #304, 2nd Floor, 7th Main Road, HRBR Layout 1st Block,
Bengaluru, Karnataka, 560043 INDIA
Disclaimer: The information contained in this e-mail message and any
files/attachment transmitted with it is confidential and for the sole use
of the intended recipient(s) or entity identified. If you are not the
intended recipient, please email: support@confluxtechnologies.com and
destroy/delete all copies and attachment thereto along with the original
message. Any unauthorized review, use, disclosure, dissemination,
forwarding, printing or copying of this email or any action taken in
reliance on this e-mail is strictly prohibited and is unlawful. The
recipient acknowledges that Conflux Technologies Private Limited or its
subsidiaries and associated companies are unable to exercise control or
ensure or guarantee the integrity of/over the contents of the information
contained in e-mail transmissions. Before opening any attachments, please
check.
On Thu, Feb 23, 2017 at 6:24 PM, Lionel Raymundi - Poincenot <
lionel@poincenot.com> wrote:
> Great, thanks. I added a comment to the jira issue because it also happens
> when trying to approve, modify or finally disburse the topup loan.
> If you agree, we can commit the changes and create a new pull request
>
> Regards
>
> Lionel
>
> 2017-02-23 9:15 GMT-03:00 Santosh Math <sa...@confluxtechnologies.com>:
>
> > Hi Nazeer,
> >
> > I have rised the issue in the following link as improvement
> >
> > https://issues.apache.org/jira/browse/FINERACT-406
> >
> > On Thu, Feb 23, 2017 at 5:34 PM, Nazeer Shaik <
> > nazeer.shaik@confluxtechnologies.com> wrote:
> >
> > > Hi Lionel,
> > >
> > > I agree with your opinion. New loan disbursement date should be on or
> > after
> > > the last transaction date of previous loan.
> > >
> > > @Santosh, can you please raise a jira issue for the same.
> > >
> > > Thanks,
> > > Nazeer
> > >
> > > Thanks,
> > > Nazeer
> > >
> > > *Principal Architect, **Conflux Technologies Pvt Ltd
> > > <http://www.confluxtechnologies.com/>*
> > >
> > > *Address*: #304, 2nd Floor, 7th Main Road, HRBR Layout 1st Block,
> > > Bengaluru, Karnataka, 560043 INDIA
> > >
> > >
> > > Disclaimer: The information contained in this e-mail message and any
> > > files/attachment transmitted with it is confidential and for the sole
> use
> > > of the intended recipient(s) or entity identified. If you are not the
> > > intended recipient, please email: support@confluxtechnologies.com and
> > > destroy/delete all copies and attachment thereto along with the
> original
> > > message. Any unauthorized review, use, disclosure, dissemination,
> > > forwarding, printing or copying of this email or any action taken in
> > > reliance on this e-mail is strictly prohibited and is unlawful. The
> > > recipient acknowledges that Conflux Technologies Private Limited or its
> > > subsidiaries and associated companies are unable to exercise control or
> > > ensure or guarantee the integrity of/over the contents of the
> information
> > > contained in e-mail transmissions. Before opening any attachments,
> please
> > > check.
> > >
> > > On Tue, Feb 21, 2017 at 6:14 PM, Lionel Raymundi - Poincenot <
> > > lionel@poincenot.com> wrote:
> > >
> > > > Hello devs,
> > > >
> > > > Did you have the chance to look at my previous email?
> > > > We can make the modification (we did, in fact), but I don't know if
> it
> > > has
> > > > deeper implications. Do you think its a change to be pushed to the
> > > > mainstream?
> > > >
> > > > Thanks
> > > >
> > > > Lionel
> > > >
> > > >
> > > >
> > > >
> > > > 2017-02-16 12:01 GMT-03:00 Lionel Raymundi - Poincenot <
> > > > lionel@poincenot.com
> > > > >:
> > > >
> > > > > Hi guys,
> > > > >
> > > > > There is a business validation on a loan topup operation, which
> > > prevents
> > > > > you to set the disbusement date of the new loan if the previous one
> > has
> > > > > transactions on the same date (or later):
> > > > >
> > > > > error.msg.loan.disbursal.date.should.be.after.last.transacti
> > > > > on.date.of.loan.to.be.closed
> > > > >
> > > > > It is not that unusual that we ask the client to settle some
> overdued
> > > > > installments before we disbuse the new loan, as a willingness to
> > > > > pay demonstration. And is not that unusual that the repayments are
> > done
> > > > the
> > > > > same day of the disbursement of the new Loan.
> > > > >
> > > > > So the question is: Could the validation be modified to check only
> > for
> > > > > transactions made later than the disbursement date, but not on the
> > same
> > > > > date? Or is it a business validation that must remain as is?
> > > > >
> > > > > I hope I made myself clear, please dont hesitate on asking me if I
> > > > > didn't...
> > > > >
> > > > > Regards
> > > > >
> > > > > Lionel
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
> >
> >
> > --
> > Thanks and Regards
> > Santosh
> > QA Team
> > Conflux Technologies Pvt Ltd, Bengaluru
> > Skype:santoshmath99
> >
>
Re: Loan Topup disburse when loan to be closed has transactions made
on the same date
Posted by Lionel Raymundi - Poincenot <li...@poincenot.com>.
Great, thanks. I added a comment to the jira issue because it also happens
when trying to approve, modify or finally disburse the topup loan.
If you agree, we can commit the changes and create a new pull request
Regards
Lionel
2017-02-23 9:15 GMT-03:00 Santosh Math <sa...@confluxtechnologies.com>:
> Hi Nazeer,
>
> I have rised the issue in the following link as improvement
>
> https://issues.apache.org/jira/browse/FINERACT-406
>
> On Thu, Feb 23, 2017 at 5:34 PM, Nazeer Shaik <
> nazeer.shaik@confluxtechnologies.com> wrote:
>
> > Hi Lionel,
> >
> > I agree with your opinion. New loan disbursement date should be on or
> after
> > the last transaction date of previous loan.
> >
> > @Santosh, can you please raise a jira issue for the same.
> >
> > Thanks,
> > Nazeer
> >
> > Thanks,
> > Nazeer
> >
> > *Principal Architect, **Conflux Technologies Pvt Ltd
> > <http://www.confluxtechnologies.com/>*
> >
> > *Address*: #304, 2nd Floor, 7th Main Road, HRBR Layout 1st Block,
> > Bengaluru, Karnataka, 560043 INDIA
> >
> >
> > Disclaimer: The information contained in this e-mail message and any
> > files/attachment transmitted with it is confidential and for the sole use
> > of the intended recipient(s) or entity identified. If you are not the
> > intended recipient, please email: support@confluxtechnologies.com and
> > destroy/delete all copies and attachment thereto along with the original
> > message. Any unauthorized review, use, disclosure, dissemination,
> > forwarding, printing or copying of this email or any action taken in
> > reliance on this e-mail is strictly prohibited and is unlawful. The
> > recipient acknowledges that Conflux Technologies Private Limited or its
> > subsidiaries and associated companies are unable to exercise control or
> > ensure or guarantee the integrity of/over the contents of the information
> > contained in e-mail transmissions. Before opening any attachments, please
> > check.
> >
> > On Tue, Feb 21, 2017 at 6:14 PM, Lionel Raymundi - Poincenot <
> > lionel@poincenot.com> wrote:
> >
> > > Hello devs,
> > >
> > > Did you have the chance to look at my previous email?
> > > We can make the modification (we did, in fact), but I don't know if it
> > has
> > > deeper implications. Do you think its a change to be pushed to the
> > > mainstream?
> > >
> > > Thanks
> > >
> > > Lionel
> > >
> > >
> > >
> > >
> > > 2017-02-16 12:01 GMT-03:00 Lionel Raymundi - Poincenot <
> > > lionel@poincenot.com
> > > >:
> > >
> > > > Hi guys,
> > > >
> > > > There is a business validation on a loan topup operation, which
> > prevents
> > > > you to set the disbusement date of the new loan if the previous one
> has
> > > > transactions on the same date (or later):
> > > >
> > > > error.msg.loan.disbursal.date.should.be.after.last.transacti
> > > > on.date.of.loan.to.be.closed
> > > >
> > > > It is not that unusual that we ask the client to settle some overdued
> > > > installments before we disbuse the new loan, as a willingness to
> > > > pay demonstration. And is not that unusual that the repayments are
> done
> > > the
> > > > same day of the disbursement of the new Loan.
> > > >
> > > > So the question is: Could the validation be modified to check only
> for
> > > > transactions made later than the disbursement date, but not on the
> same
> > > > date? Or is it a business validation that must remain as is?
> > > >
> > > > I hope I made myself clear, please dont hesitate on asking me if I
> > > > didn't...
> > > >
> > > > Regards
> > > >
> > > > Lionel
> > > >
> > > >
> > > >
> > >
> >
>
>
>
> --
> Thanks and Regards
> Santosh
> QA Team
> Conflux Technologies Pvt Ltd, Bengaluru
> Skype:santoshmath99
>
Re: Loan Topup disburse when loan to be closed has transactions made
on the same date
Posted by Santosh Math <sa...@confluxtechnologies.com>.
Hi Nazeer,
I have rised the issue in the following link as improvement
https://issues.apache.org/jira/browse/FINERACT-406
On Thu, Feb 23, 2017 at 5:34 PM, Nazeer Shaik <
nazeer.shaik@confluxtechnologies.com> wrote:
> Hi Lionel,
>
> I agree with your opinion. New loan disbursement date should be on or after
> the last transaction date of previous loan.
>
> @Santosh, can you please raise a jira issue for the same.
>
> Thanks,
> Nazeer
>
> Thanks,
> Nazeer
>
> *Principal Architect, **Conflux Technologies Pvt Ltd
> <http://www.confluxtechnologies.com/>*
>
> *Address*: #304, 2nd Floor, 7th Main Road, HRBR Layout 1st Block,
> Bengaluru, Karnataka, 560043 INDIA
>
>
> Disclaimer: The information contained in this e-mail message and any
> files/attachment transmitted with it is confidential and for the sole use
> of the intended recipient(s) or entity identified. If you are not the
> intended recipient, please email: support@confluxtechnologies.com and
> destroy/delete all copies and attachment thereto along with the original
> message. Any unauthorized review, use, disclosure, dissemination,
> forwarding, printing or copying of this email or any action taken in
> reliance on this e-mail is strictly prohibited and is unlawful. The
> recipient acknowledges that Conflux Technologies Private Limited or its
> subsidiaries and associated companies are unable to exercise control or
> ensure or guarantee the integrity of/over the contents of the information
> contained in e-mail transmissions. Before opening any attachments, please
> check.
>
> On Tue, Feb 21, 2017 at 6:14 PM, Lionel Raymundi - Poincenot <
> lionel@poincenot.com> wrote:
>
> > Hello devs,
> >
> > Did you have the chance to look at my previous email?
> > We can make the modification (we did, in fact), but I don't know if it
> has
> > deeper implications. Do you think its a change to be pushed to the
> > mainstream?
> >
> > Thanks
> >
> > Lionel
> >
> >
> >
> >
> > 2017-02-16 12:01 GMT-03:00 Lionel Raymundi - Poincenot <
> > lionel@poincenot.com
> > >:
> >
> > > Hi guys,
> > >
> > > There is a business validation on a loan topup operation, which
> prevents
> > > you to set the disbusement date of the new loan if the previous one has
> > > transactions on the same date (or later):
> > >
> > > error.msg.loan.disbursal.date.should.be.after.last.transacti
> > > on.date.of.loan.to.be.closed
> > >
> > > It is not that unusual that we ask the client to settle some overdued
> > > installments before we disbuse the new loan, as a willingness to
> > > pay demonstration. And is not that unusual that the repayments are done
> > the
> > > same day of the disbursement of the new Loan.
> > >
> > > So the question is: Could the validation be modified to check only for
> > > transactions made later than the disbursement date, but not on the same
> > > date? Or is it a business validation that must remain as is?
> > >
> > > I hope I made myself clear, please dont hesitate on asking me if I
> > > didn't...
> > >
> > > Regards
> > >
> > > Lionel
> > >
> > >
> > >
> >
>
--
Thanks and Regards
Santosh
QA Team
Conflux Technologies Pvt Ltd, Bengaluru
Skype:santoshmath99
Re: Loan Topup disburse when loan to be closed has transactions made
on the same date
Posted by Nazeer Shaik <na...@confluxtechnologies.com>.
Hi Lionel,
I agree with your opinion. New loan disbursement date should be on or after
the last transaction date of previous loan.
@Santosh, can you please raise a jira issue for the same.
Thanks,
Nazeer
Thanks,
Nazeer
*Principal Architect, **Conflux Technologies Pvt Ltd
<http://www.confluxtechnologies.com/>*
*Address*: #304, 2nd Floor, 7th Main Road, HRBR Layout 1st Block,
Bengaluru, Karnataka, 560043 INDIA
Disclaimer: The information contained in this e-mail message and any
files/attachment transmitted with it is confidential and for the sole use
of the intended recipient(s) or entity identified. If you are not the
intended recipient, please email: support@confluxtechnologies.com and
destroy/delete all copies and attachment thereto along with the original
message. Any unauthorized review, use, disclosure, dissemination,
forwarding, printing or copying of this email or any action taken in
reliance on this e-mail is strictly prohibited and is unlawful. The
recipient acknowledges that Conflux Technologies Private Limited or its
subsidiaries and associated companies are unable to exercise control or
ensure or guarantee the integrity of/over the contents of the information
contained in e-mail transmissions. Before opening any attachments, please
check.
On Tue, Feb 21, 2017 at 6:14 PM, Lionel Raymundi - Poincenot <
lionel@poincenot.com> wrote:
> Hello devs,
>
> Did you have the chance to look at my previous email?
> We can make the modification (we did, in fact), but I don't know if it has
> deeper implications. Do you think its a change to be pushed to the
> mainstream?
>
> Thanks
>
> Lionel
>
>
>
>
> 2017-02-16 12:01 GMT-03:00 Lionel Raymundi - Poincenot <
> lionel@poincenot.com
> >:
>
> > Hi guys,
> >
> > There is a business validation on a loan topup operation, which prevents
> > you to set the disbusement date of the new loan if the previous one has
> > transactions on the same date (or later):
> >
> > error.msg.loan.disbursal.date.should.be.after.last.transacti
> > on.date.of.loan.to.be.closed
> >
> > It is not that unusual that we ask the client to settle some overdued
> > installments before we disbuse the new loan, as a willingness to
> > pay demonstration. And is not that unusual that the repayments are done
> the
> > same day of the disbursement of the new Loan.
> >
> > So the question is: Could the validation be modified to check only for
> > transactions made later than the disbursement date, but not on the same
> > date? Or is it a business validation that must remain as is?
> >
> > I hope I made myself clear, please dont hesitate on asking me if I
> > didn't...
> >
> > Regards
> >
> > Lionel
> >
> >
> >
>
Re: Loan Topup disburse when loan to be closed has transactions made
on the same date
Posted by Lionel Raymundi - Poincenot <li...@poincenot.com>.
Hello devs,
Did you have the chance to look at my previous email?
We can make the modification (we did, in fact), but I don't know if it has
deeper implications. Do you think its a change to be pushed to the
mainstream?
Thanks
Lionel
2017-02-16 12:01 GMT-03:00 Lionel Raymundi - Poincenot <lionel@poincenot.com
>:
> Hi guys,
>
> There is a business validation on a loan topup operation, which prevents
> you to set the disbusement date of the new loan if the previous one has
> transactions on the same date (or later):
>
> error.msg.loan.disbursal.date.should.be.after.last.transacti
> on.date.of.loan.to.be.closed
>
> It is not that unusual that we ask the client to settle some overdued
> installments before we disbuse the new loan, as a willingness to
> pay demonstration. And is not that unusual that the repayments are done the
> same day of the disbursement of the new Loan.
>
> So the question is: Could the validation be modified to check only for
> transactions made later than the disbursement date, but not on the same
> date? Or is it a business validation that must remain as is?
>
> I hope I made myself clear, please dont hesitate on asking me if I
> didn't...
>
> Regards
>
> Lionel
>
>
>