You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/05/19 08:12:38 UTC

[GitHub] [maven-release] bguerin commented on a change in pull request #56: [MRELEASE-1042] releaseProfiles get overriden by activeProfiles

bguerin commented on a change in pull request #56:
URL: https://github.com/apache/maven-release/pull/56#discussion_r427111609



##########
File path: maven-release-manager/src/main/java/org/apache/maven/shared/release/config/ReleaseDescriptorBuilder.java
##########
@@ -58,7 +59,9 @@ public ReleaseDescriptorBuilder addCheckModificationExclude( String string )
 
     public ReleaseDescriptorBuilder setActivateProfiles( List<String> profiles )
     {
-        releaseDescriptor.setActivateProfiles( profiles );
+        List<String> copy = new ArrayList<>();
+        copy.addAll( profiles );

Review comment:
       This is not a merge, I do not keel the old value. It is a defensive setter, ensuring that the list implementation used is not read only / immuable




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org