You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2015/01/08 18:55:09 UTC
Review Request 29715: Storm service components should indicate
security state
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29715/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, and Yusaku Sako.
Bugs: AMBARI-9037
https://issues.apache.org/jira/browse/AMBARI-9037
Repository: ambari
Description
-------
The Storm service components should indicate security state when queried by Ambari Agent via STATUS_COMMAND.
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py 91d55f0
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/drpc_server.py 149b212
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 6d68f3e
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/status_params.py 5eaa446
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/ui_server.py 6a9d923
ambari-server/src/test/python/stacks/2.1/STORM/test_storm_drpc_server.py 336aded
ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py d9887d4
ambari-server/src/test/python/stacks/2.1/STORM/test_storm_ui_server.py becd591
ambari-server/src/test/python/stacks/2.1/configs/secured.json 0ba831d
Diff: https://reviews.apache.org/r/29715/diff/
Testing
-------
Manually tested in test cluster
Added unit tests
#Jenkins test results
Running tests for stack:2.1 service:STORM
test_configure_default (test_storm_supervisor_prod.TestStormSupervisor) ... ok
test_start_default (test_storm_supervisor_prod.TestStormSupervisor) ... ok
test_start_secured (test_storm_supervisor_prod.TestStormSupervisor) ... ok
test_stop_default (test_storm_supervisor_prod.TestStormSupervisor) ... ok
test_stop_secured (test_storm_supervisor_prod.TestStormSupervisor) ... ok
test_configure_default (test_storm_drpc_server.TestStormDrpcServer) ... ok
test_configure_secured (test_storm_drpc_server.TestStormDrpcServer) ... ok
**test_security_status (test_storm_drpc_server.TestStormDrpcServer) ... ok**
test_start_default (test_storm_drpc_server.TestStormDrpcServer) ... ok
test_start_secured (test_storm_drpc_server.TestStormDrpcServer) ... ok
test_stop_default (test_storm_drpc_server.TestStormDrpcServer) ... ok
test_stop_secured (test_storm_drpc_server.TestStormDrpcServer) ... ok
test_configure_default (test_storm_nimbus.TestStormNimbus) ... ok
test_configure_secured (test_storm_nimbus.TestStormNimbus) ... ok
**test_security_status (test_storm_nimbus.TestStormNimbus) ... ok**
test_start_default (test_storm_nimbus.TestStormNimbus) ... ok
test_start_secured (test_storm_nimbus.TestStormNimbus) ... ok
test_stop_default (test_storm_nimbus.TestStormNimbus) ... ok
test_stop_secured (test_storm_nimbus.TestStormNimbus) ... ok
test_service_check (test_service_check.TestStormServiceCheck) ... ok
test_configure_default (test_storm_nimbus_prod.TestStormNimbus) ... ok
test_configure_secured (test_storm_nimbus_prod.TestStormNimbus) ... ok
test_start_default (test_storm_nimbus_prod.TestStormNimbus) ... ok
test_start_secured (test_storm_nimbus_prod.TestStormNimbus) ... ok
test_stop_default (test_storm_nimbus_prod.TestStormNimbus) ... ok
test_stop_secured (test_storm_nimbus_prod.TestStormNimbus) ... ok
test_configure_default (test_storm_supervisor.TestStormSupervisor) ... ok
test_configure_secured (test_storm_supervisor.TestStormSupervisor) ... ok
test_start_default (test_storm_supervisor.TestStormSupervisor) ... ok
test_start_secured (test_storm_supervisor.TestStormSupervisor) ... ok
test_stop_default (test_storm_supervisor.TestStormSupervisor) ... ok
test_stop_secured (test_storm_supervisor.TestStormSupervisor) ... ok
test_configure_default (test_storm_ui_server.TestStormUiServer) ... ok
test_configure_secured (test_storm_ui_server.TestStormUiServer) ... ok
**test_security_status (test_storm_ui_server.TestStormUiServer) ... ok**
test_start_default (test_storm_ui_server.TestStormUiServer) ... ok
test_start_secured (test_storm_ui_server.TestStormUiServer) ... ok
test_stop_default (test_storm_ui_server.TestStormUiServer) ... ok
...
test_stop_default (test_storm_rest_api_service.TestStormRestApi) ... ok
test_stop_secured (test_storm_rest_api_service.TestStormRestApi) ... ok
----------------------------------------------------------------------
Ran 49 tests in 1.787s
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:08 h
[INFO] Finished at: 2015-01-08T16:55:40+00:00
[INFO] Final Memory: 44M/475M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
Re: Review Request 29715: Storm service components should indicate
security state
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29715/#review67294
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 8, 2015, 5:55 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29715/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2015, 5:55 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, and Yusaku Sako.
>
>
> Bugs: AMBARI-9037
> https://issues.apache.org/jira/browse/AMBARI-9037
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The Storm service components should indicate security state when queried by Ambari Agent via STATUS_COMMAND.
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py 91d55f0
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/drpc_server.py 149b212
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 6d68f3e
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/status_params.py 5eaa446
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/ui_server.py 6a9d923
> ambari-server/src/test/python/stacks/2.1/STORM/test_storm_drpc_server.py 336aded
> ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py d9887d4
> ambari-server/src/test/python/stacks/2.1/STORM/test_storm_ui_server.py becd591
> ambari-server/src/test/python/stacks/2.1/configs/secured.json 0ba831d
>
> Diff: https://reviews.apache.org/r/29715/diff/
>
>
> Testing
> -------
>
> Manually tested in test cluster
>
> Added unit tests
>
> #Jenkins test results
>
> Running tests for stack:2.1 service:STORM
> test_configure_default (test_storm_supervisor_prod.TestStormSupervisor) ... ok
> test_start_default (test_storm_supervisor_prod.TestStormSupervisor) ... ok
> test_start_secured (test_storm_supervisor_prod.TestStormSupervisor) ... ok
> test_stop_default (test_storm_supervisor_prod.TestStormSupervisor) ... ok
> test_stop_secured (test_storm_supervisor_prod.TestStormSupervisor) ... ok
> test_configure_default (test_storm_drpc_server.TestStormDrpcServer) ... ok
> test_configure_secured (test_storm_drpc_server.TestStormDrpcServer) ... ok
> **test_security_status (test_storm_drpc_server.TestStormDrpcServer) ... ok**
> test_start_default (test_storm_drpc_server.TestStormDrpcServer) ... ok
> test_start_secured (test_storm_drpc_server.TestStormDrpcServer) ... ok
> test_stop_default (test_storm_drpc_server.TestStormDrpcServer) ... ok
> test_stop_secured (test_storm_drpc_server.TestStormDrpcServer) ... ok
> test_configure_default (test_storm_nimbus.TestStormNimbus) ... ok
> test_configure_secured (test_storm_nimbus.TestStormNimbus) ... ok
> **test_security_status (test_storm_nimbus.TestStormNimbus) ... ok**
> test_start_default (test_storm_nimbus.TestStormNimbus) ... ok
> test_start_secured (test_storm_nimbus.TestStormNimbus) ... ok
> test_stop_default (test_storm_nimbus.TestStormNimbus) ... ok
> test_stop_secured (test_storm_nimbus.TestStormNimbus) ... ok
> test_service_check (test_service_check.TestStormServiceCheck) ... ok
> test_configure_default (test_storm_nimbus_prod.TestStormNimbus) ... ok
> test_configure_secured (test_storm_nimbus_prod.TestStormNimbus) ... ok
> test_start_default (test_storm_nimbus_prod.TestStormNimbus) ... ok
> test_start_secured (test_storm_nimbus_prod.TestStormNimbus) ... ok
> test_stop_default (test_storm_nimbus_prod.TestStormNimbus) ... ok
> test_stop_secured (test_storm_nimbus_prod.TestStormNimbus) ... ok
> test_configure_default (test_storm_supervisor.TestStormSupervisor) ... ok
> test_configure_secured (test_storm_supervisor.TestStormSupervisor) ... ok
> test_start_default (test_storm_supervisor.TestStormSupervisor) ... ok
> test_start_secured (test_storm_supervisor.TestStormSupervisor) ... ok
> test_stop_default (test_storm_supervisor.TestStormSupervisor) ... ok
> test_stop_secured (test_storm_supervisor.TestStormSupervisor) ... ok
> test_configure_default (test_storm_ui_server.TestStormUiServer) ... ok
> test_configure_secured (test_storm_ui_server.TestStormUiServer) ... ok
> **test_security_status (test_storm_ui_server.TestStormUiServer) ... ok**
> test_start_default (test_storm_ui_server.TestStormUiServer) ... ok
> test_start_secured (test_storm_ui_server.TestStormUiServer) ... ok
> test_stop_default (test_storm_ui_server.TestStormUiServer) ... ok
> ...
> test_stop_default (test_storm_rest_api_service.TestStormRestApi) ... ok
> test_stop_secured (test_storm_rest_api_service.TestStormRestApi) ... ok
>
> ----------------------------------------------------------------------
> Ran 49 tests in 1.787s
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:08 h
> [INFO] Finished at: 2015-01-08T16:55:40+00:00
> [INFO] Final Memory: 44M/475M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 29715: Storm service components should indicate
security state
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29715/
-----------------------------------------------------------
(Updated Jan. 13, 2015, 1:24 p.m.)
Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, and Yusaku Sako.
Bugs: AMBARI-9037
https://issues.apache.org/jira/browse/AMBARI-9037
Repository: ambari
Description
-------
The Storm service components should indicate security state when queried by Ambari Agent via STATUS_COMMAND.
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py 91d55f0
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/drpc_server.py 09406e1
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/nimbus.py 6af4010
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/status_params.py 570cd53
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/ui_server.py 64ad379
ambari-server/src/test/python/stacks/2.1/STORM/test_storm_drpc_server.py f3223dd
ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py 7583d77
ambari-server/src/test/python/stacks/2.1/STORM/test_storm_ui_server.py 3bec89d
ambari-server/src/test/python/stacks/2.1/configs/secured.json 0ba831d
Diff: https://reviews.apache.org/r/29715/diff/
Testing
-------
Manually tested in test cluster
Added unit tests
#Jenkins test results
Running tests for stack:2.1 service:STORM
test_configure_default (test_storm_supervisor_prod.TestStormSupervisor) ... ok
test_start_default (test_storm_supervisor_prod.TestStormSupervisor) ... ok
test_start_secured (test_storm_supervisor_prod.TestStormSupervisor) ... ok
test_stop_default (test_storm_supervisor_prod.TestStormSupervisor) ... ok
test_stop_secured (test_storm_supervisor_prod.TestStormSupervisor) ... ok
test_configure_default (test_storm_drpc_server.TestStormDrpcServer) ... ok
test_configure_secured (test_storm_drpc_server.TestStormDrpcServer) ... ok
**test_security_status (test_storm_drpc_server.TestStormDrpcServer) ... ok**
test_start_default (test_storm_drpc_server.TestStormDrpcServer) ... ok
test_start_secured (test_storm_drpc_server.TestStormDrpcServer) ... ok
test_stop_default (test_storm_drpc_server.TestStormDrpcServer) ... ok
test_stop_secured (test_storm_drpc_server.TestStormDrpcServer) ... ok
test_configure_default (test_storm_nimbus.TestStormNimbus) ... ok
test_configure_secured (test_storm_nimbus.TestStormNimbus) ... ok
**test_security_status (test_storm_nimbus.TestStormNimbus) ... ok**
test_start_default (test_storm_nimbus.TestStormNimbus) ... ok
test_start_secured (test_storm_nimbus.TestStormNimbus) ... ok
test_stop_default (test_storm_nimbus.TestStormNimbus) ... ok
test_stop_secured (test_storm_nimbus.TestStormNimbus) ... ok
test_service_check (test_service_check.TestStormServiceCheck) ... ok
test_configure_default (test_storm_nimbus_prod.TestStormNimbus) ... ok
test_configure_secured (test_storm_nimbus_prod.TestStormNimbus) ... ok
test_start_default (test_storm_nimbus_prod.TestStormNimbus) ... ok
test_start_secured (test_storm_nimbus_prod.TestStormNimbus) ... ok
test_stop_default (test_storm_nimbus_prod.TestStormNimbus) ... ok
test_stop_secured (test_storm_nimbus_prod.TestStormNimbus) ... ok
test_configure_default (test_storm_supervisor.TestStormSupervisor) ... ok
test_configure_secured (test_storm_supervisor.TestStormSupervisor) ... ok
test_start_default (test_storm_supervisor.TestStormSupervisor) ... ok
test_start_secured (test_storm_supervisor.TestStormSupervisor) ... ok
test_stop_default (test_storm_supervisor.TestStormSupervisor) ... ok
test_stop_secured (test_storm_supervisor.TestStormSupervisor) ... ok
test_configure_default (test_storm_ui_server.TestStormUiServer) ... ok
test_configure_secured (test_storm_ui_server.TestStormUiServer) ... ok
**test_security_status (test_storm_ui_server.TestStormUiServer) ... ok**
test_start_default (test_storm_ui_server.TestStormUiServer) ... ok
test_start_secured (test_storm_ui_server.TestStormUiServer) ... ok
test_stop_default (test_storm_ui_server.TestStormUiServer) ... ok
...
test_stop_default (test_storm_rest_api_service.TestStormRestApi) ... ok
test_stop_secured (test_storm_rest_api_service.TestStormRestApi) ... ok
----------------------------------------------------------------------
Ran 49 tests in 1.787s
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:08 h
[INFO] Finished at: 2015-01-08T16:55:40+00:00
[INFO] Final Memory: 44M/475M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas