You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Hans Bakker (JIRA)" <ji...@apache.org> on 2013/07/08 11:13:48 UTC
[jira] [Closed] (OFBIZ-5257) Method isInvoiceInForeignCurrency in
InvoiceServices.xml is named wrong
[ https://issues.apache.org/jira/browse/OFBIZ-5257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hans Bakker closed OFBIZ-5257.
------------------------------
Resolution: Won't Fix
please check the service reference for other examples that start with 'is'
perhaps you did not notice the name is : "is Invoice In Foreign Currency"?
the output is yes/no,
Regards,
hans
> Method isInvoiceInForeignCurrency in InvoiceServices.xml is named wrong
> -----------------------------------------------------------------------
>
> Key: OFBIZ-5257
> URL: https://issues.apache.org/jira/browse/OFBIZ-5257
> Project: OFBiz
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Pierre Smits
> Fix For: SVN trunk
>
>
> The name of this method in accounting services doesn't tell what it does.
> You have to go into the description what the functionality of the method is, namely checking whether an invoice is a foreign currency.
> Best practice is to have the name of the function reflect the functionality.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira