[jira] [Commented] (LOG4J2-2683) Rename PluginVisitor to more appropriate name

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LOG4J2-2683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16916132#comment-16916132 ] 

ASF subversion and git services commented on LOG4J2-2683:
---------------------------------------------------------

Commit 33009e1163227a20b526ac04b9af79b90d439bf5 in logging-log4j2's branch refs/heads/master from Matt Sicker
[ https://gitbox.apache.org/repos/asf?p=logging-log4j2.git;h=33009e1 ]

[LOG4J2-2683] Rename PluginVisitor

This cleans up an unfortunately named set of classes from 2.x to more
appropriately reflect their purpose. This also cleans up some of the
related code.


> Rename PluginVisitor to more appropriate name
> ---------------------------------------------
>
>                 Key: LOG4J2-2683
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-2683
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: Core, Plugins
>    Affects Versions: 3.0.0
>            Reporter: Matt Sicker
>            Assignee: Matt Sicker
>            Priority: Major
>
> Given a few more years of experience, after taking a look at {{PluginVisitor}} again, I've finally decided it's time to name it more appropriately. This class is following a builder pattern, not a visitor, and it's for injection strategies. Thus, this class can be renamed to something like {{PluginInjectionBuilder}} along with some cleanups to make the rest of the parameters that were previously passed to {{visit()}} to instead be added as builder properties. The 2.x implementation shims should be updated to use this renamed class as well.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)