[GitHub] [beam] lukecwik commented on a change in pull request #12511: Upgrade to Netty 4.1.50.Final and Netty_tcnative 2.0.31.Final

[GitBox <gi...@apache.org>]

lukecwik commented on a change in pull request #12511:
URL: https://github.com/apache/beam/pull/12511#discussion_r468747932



##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/GrpcVendoring_1_26_0.groovy
##########
@@ -27,7 +27,7 @@ class GrpcVendoring_1_26_0 {
   static def protobuf_version = "3.11.0"
   static def grpc_version = "1.26.0"
   static def gson_version = "2.8.6"
-  static def netty_version = "4.1.42.Final"
+  static def netty_version = "4.1.50.Final"

Review comment:
       We should update the version of gRPC we are vendoring instead of changing the versions we are using here.

##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -581,7 +581,7 @@ class BeamModulePlugin implements Plugin<Project> {
         maven_exec_plugin    : "maven-plugins:maven-exec-plugin:1.6.0",
         maven_jar_plugin     : "maven-plugins:maven-jar-plugin:3.0.2",
         maven_shade_plugin   : "maven-plugins:maven-shade-plugin:3.1.0",
-        maven_surefire_plugin: "maven-plugins:maven-surefire-plugin:2.21.0",
+        maven_surefire_plugin: "maven-plugins:maven-surefire-plugin:3.0.0-M5",

Review comment:
       why did this need to change?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org