You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/03 07:55:09 UTC

[GitHub] [flink] hequn8128 opened a new pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

hequn8128 opened a new pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995
 
 
   
   ## What is the purpose of the change
   
   This pull request adds the jar of flink-ml into the opt folder so that users can directly use the jars with the binary release. For example, users can move the jars into the `lib` folder or use -j to upload the jar.
   
   
   ## Brief change log
   
     - Adds `maven-shade-plugin` in the pom of flink-ml-lib module
     - Adds a file config similar to sql-client in flink-dist/src/main/assemblies/opt.xml
   
   
   ## Verifying this change
   
    - This change is a trivial rework / code cleanup without any test coverage.
    - Build Flink locally and check jars in opt.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#discussion_r374016678
 
 

 ##########
 File path: flink-ml-parent/flink-ml-lib/pom.xml
 ##########
 @@ -57,4 +57,30 @@ under the License.
 			<version>1.1.2</version>
 		</dependency>
 	</dependencies>
+
+	<build>
+		<plugins>
+			<!-- Build flink-ml-lib jar -->
+			<plugin>
+				<groupId>org.apache.maven.plugins</groupId>
+				<artifactId>maven-shade-plugin</artifactId>
+				<executions>
+					<execution>
+						<id>shade-flink</id>
+						<phase>package</phase>
+						<goals>
+							<goal>shade</goal>
+						</goals>
+						<configuration>
+							<artifactSet>
+								<includes combine.children="append">
+									<include>com.github.fommil.netlib:core</include>
 
 Review comment:
   licensing needs to be updated

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#issuecomment-581294934
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "65debfebc1bad896666160a6375b9c78ea8eb063",
       "status" : "FAILURE",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/147155607",
       "triggerID" : "65debfebc1bad896666160a6375b9c78ea8eb063",
       "triggerType" : "PUSH"
     }, {
       "hash" : "65debfebc1bad896666160a6375b9c78ea8eb063",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4764",
       "triggerID" : "65debfebc1bad896666160a6375b9c78ea8eb063",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1385f42a76ba0060d37022873064e736d52ea0af",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/147163976",
       "triggerID" : "1385f42a76ba0060d37022873064e736d52ea0af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1385f42a76ba0060d37022873064e736d52ea0af",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4766",
       "triggerID" : "1385f42a76ba0060d37022873064e736d52ea0af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1edd078c466ee56f2aed16ce9098e35bfae69e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5194",
       "triggerID" : "9c1edd078c466ee56f2aed16ce9098e35bfae69e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1edd078c466ee56f2aed16ce9098e35bfae69e",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/149075460",
       "triggerID" : "9c1edd078c466ee56f2aed16ce9098e35bfae69e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 65debfebc1bad896666160a6375b9c78ea8eb063 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147155607) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4764) 
   * 1385f42a76ba0060d37022873064e736d52ea0af Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147163976) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4766) 
   * 9c1edd078c466ee56f2aed16ce9098e35bfae69e Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149075460) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5194) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#issuecomment-581294934
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "65debfebc1bad896666160a6375b9c78ea8eb063",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/147155607",
       "triggerID" : "65debfebc1bad896666160a6375b9c78ea8eb063",
       "triggerType" : "PUSH"
     }, {
       "hash" : "65debfebc1bad896666160a6375b9c78ea8eb063",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4764",
       "triggerID" : "65debfebc1bad896666160a6375b9c78ea8eb063",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1385f42a76ba0060d37022873064e736d52ea0af",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/147163976",
       "triggerID" : "1385f42a76ba0060d37022873064e736d52ea0af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1385f42a76ba0060d37022873064e736d52ea0af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4766",
       "triggerID" : "1385f42a76ba0060d37022873064e736d52ea0af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1edd078c466ee56f2aed16ce9098e35bfae69e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5194",
       "triggerID" : "9c1edd078c466ee56f2aed16ce9098e35bfae69e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1edd078c466ee56f2aed16ce9098e35bfae69e",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/149075460",
       "triggerID" : "9c1edd078c466ee56f2aed16ce9098e35bfae69e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "478491bde663e58f1e84753bf6fac3a7367ef195",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150771112",
       "triggerID" : "478491bde663e58f1e84753bf6fac3a7367ef195",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9c1edd078c466ee56f2aed16ce9098e35bfae69e Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149075460) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5194) 
   * 478491bde663e58f1e84753bf6fac3a7367ef195 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150771112) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#discussion_r379951593
 
 

 ##########
 File path: flink-dist/src/main/assemblies/opt.xml
 ##########
 @@ -168,6 +168,14 @@
 			<destName>flink-python_${scala.binary.version}-${project.version}.jar</destName>
 			<fileMode>0644</fileMode>
 		</file>
+
+		<!-- ML (API & LIB)  -->
+		<file>
 
 Review comment:
   For the table module, it makes no sense to let any sub-modules to bundle cep, so a uber module is used to create the bundle jar. but for ml module, it makes sense to let flink-ml-lib to bundle the flink-ml-api module, so that we can simply put the flink-ml-lib jar into the opt. 
   
   Anyway, I have created an uber module for the flink-ml in the latest pr. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#discussion_r384484556
 
 

 ##########
 File path: flink-ml-parent/flink-ml-lib/pom.xml
 ##########
 @@ -57,4 +60,30 @@ under the License.
 			<version>1.1.2</version>
 		</dependency>
 	</dependencies>
+
+	<build>
+		<plugins>
+			<!-- Build flink-ml-lib jar -->
+			<plugin>
+				<groupId>org.apache.maven.plugins</groupId>
+				<artifactId>maven-shade-plugin</artifactId>
 
 Review comment:
   I would move this (and the corresponding NOTICE) into the `uber` module.
   
   The basic idea is that the `uber` module is responsible for all things related to the distribution. The individual modules usually shouldn't have to shade dependencies; users should set flink-ml dependencies to provided anyways so we don't have to concerned about them accidently bundling this dependency.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#issuecomment-591779672
 
 
   @zentol Thanks for the review. The PR has been updated accordingly. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#issuecomment-581283499
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 478491bde663e58f1e84753bf6fac3a7367ef195 (Fri Feb 28 21:49:20 UTC 2020)
   
   **Warnings:**
    * **5 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#discussion_r380036167
 
 

 ##########
 File path: flink-dist/src/main/assemblies/opt.xml
 ##########
 @@ -168,6 +168,14 @@
 			<destName>flink-python_${scala.binary.version}-${project.version}.jar</destName>
 			<fileMode>0644</fileMode>
 		</file>
+
+		<!-- ML (API & LIB)  -->
+		<file>
 
 Review comment:
   the table-uber module existed before it bundled cep though.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#issuecomment-581294934
 
 
   <!--
   Meta data
   Hash:65debfebc1bad896666160a6375b9c78ea8eb063 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147155607 TriggerType:PUSH TriggerID:65debfebc1bad896666160a6375b9c78ea8eb063
   Hash:65debfebc1bad896666160a6375b9c78ea8eb063 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4764 TriggerType:PUSH TriggerID:65debfebc1bad896666160a6375b9c78ea8eb063
   Hash:1385f42a76ba0060d37022873064e736d52ea0af Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147163976 TriggerType:PUSH TriggerID:1385f42a76ba0060d37022873064e736d52ea0af
   Hash:1385f42a76ba0060d37022873064e736d52ea0af Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4766 TriggerType:PUSH TriggerID:1385f42a76ba0060d37022873064e736d52ea0af
   -->
   ## CI report:
   
   * 65debfebc1bad896666160a6375b9c78ea8eb063 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147155607) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4764) 
   * 1385f42a76ba0060d37022873064e736d52ea0af Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147163976) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4766) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#issuecomment-586566224
 
 
   @dianfu @zentol Thanks a lot for your review. The PR has been updated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] walterddr commented on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
walterddr commented on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#issuecomment-590026589
 
 
   @hequn8128 yeah. I thought so too. the revert should only be on 1.10 branch IMO. thanks for the explanation and follow up.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#issuecomment-581283499
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 65debfebc1bad896666160a6375b9c78ea8eb063 (Mon Feb 03 07:57:52 UTC 2020)
   
   **Warnings:**
    * **1 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#issuecomment-581294934
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "65debfebc1bad896666160a6375b9c78ea8eb063",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/147155607",
       "triggerID" : "65debfebc1bad896666160a6375b9c78ea8eb063",
       "triggerType" : "PUSH"
     }, {
       "hash" : "65debfebc1bad896666160a6375b9c78ea8eb063",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4764",
       "triggerID" : "65debfebc1bad896666160a6375b9c78ea8eb063",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1385f42a76ba0060d37022873064e736d52ea0af",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/147163976",
       "triggerID" : "1385f42a76ba0060d37022873064e736d52ea0af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1385f42a76ba0060d37022873064e736d52ea0af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4766",
       "triggerID" : "1385f42a76ba0060d37022873064e736d52ea0af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1edd078c466ee56f2aed16ce9098e35bfae69e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5194",
       "triggerID" : "9c1edd078c466ee56f2aed16ce9098e35bfae69e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1edd078c466ee56f2aed16ce9098e35bfae69e",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/149075460",
       "triggerID" : "9c1edd078c466ee56f2aed16ce9098e35bfae69e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "478491bde663e58f1e84753bf6fac3a7367ef195",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "478491bde663e58f1e84753bf6fac3a7367ef195",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9c1edd078c466ee56f2aed16ce9098e35bfae69e Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149075460) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5194) 
   * 478491bde663e58f1e84753bf6fac3a7367ef195 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#issuecomment-581294934
 
 
   <!--
   Meta data
   Hash:65debfebc1bad896666160a6375b9c78ea8eb063 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147155607 TriggerType:PUSH TriggerID:65debfebc1bad896666160a6375b9c78ea8eb063
   Hash:65debfebc1bad896666160a6375b9c78ea8eb063 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4764 TriggerType:PUSH TriggerID:65debfebc1bad896666160a6375b9c78ea8eb063
   Hash:1385f42a76ba0060d37022873064e736d52ea0af Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147163976 TriggerType:PUSH TriggerID:1385f42a76ba0060d37022873064e736d52ea0af
   Hash:1385f42a76ba0060d37022873064e736d52ea0af Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4766 TriggerType:PUSH TriggerID:1385f42a76ba0060d37022873064e736d52ea0af
   Hash:9c1edd078c466ee56f2aed16ce9098e35bfae69e Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5194 TriggerType:PUSH TriggerID:9c1edd078c466ee56f2aed16ce9098e35bfae69e
   Hash:9c1edd078c466ee56f2aed16ce9098e35bfae69e Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149075460 TriggerType:PUSH TriggerID:9c1edd078c466ee56f2aed16ce9098e35bfae69e
   -->
   ## CI report:
   
   * 65debfebc1bad896666160a6375b9c78ea8eb063 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147155607) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4764) 
   * 1385f42a76ba0060d37022873064e736d52ea0af Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147163976) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4766) 
   * 9c1edd078c466ee56f2aed16ce9098e35bfae69e Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149075460) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5194) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#discussion_r379713878
 
 

 ##########
 File path: flink-ml-parent/flink-ml-lib/pom.xml
 ##########
 @@ -57,4 +57,30 @@ under the License.
 			<version>1.1.2</version>
 		</dependency>
 	</dependencies>
+
+	<build>
+		<plugins>
+			<!-- Build flink-ml-lib jar -->
+			<plugin>
+				<groupId>org.apache.maven.plugins</groupId>
+				<artifactId>maven-shade-plugin</artifactId>
+				<executions>
+					<execution>
+						<id>shade-flink</id>
+						<phase>package</phase>
+						<goals>
+							<goal>shade</goal>
+						</goals>
+						<configuration>
+							<artifactSet>
+								<includes combine.children="append">
+									<include>com.github.fommil.netlib:core</include>
 
 Review comment:
   @zentol The license has already been added by this commit https://github.com/apache/flink/pull/8631/files
   
   Or do you mean we should remove the licensing for release-1.10? I think we can create a fix in another PR. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#issuecomment-581294934
 
 
   <!--
   Meta data
   Hash:65debfebc1bad896666160a6375b9c78ea8eb063 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147155607 TriggerType:PUSH TriggerID:65debfebc1bad896666160a6375b9c78ea8eb063
   Hash:65debfebc1bad896666160a6375b9c78ea8eb063 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4764 TriggerType:PUSH TriggerID:65debfebc1bad896666160a6375b9c78ea8eb063
   Hash:1385f42a76ba0060d37022873064e736d52ea0af Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147163976 TriggerType:PUSH TriggerID:1385f42a76ba0060d37022873064e736d52ea0af
   Hash:1385f42a76ba0060d37022873064e736d52ea0af Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4766 TriggerType:PUSH TriggerID:1385f42a76ba0060d37022873064e736d52ea0af
   Hash:9c1edd078c466ee56f2aed16ce9098e35bfae69e Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:9c1edd078c466ee56f2aed16ce9098e35bfae69e
   -->
   ## CI report:
   
   * 65debfebc1bad896666160a6375b9c78ea8eb063 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147155607) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4764) 
   * 1385f42a76ba0060d37022873064e736d52ea0af Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147163976) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4766) 
   * 9c1edd078c466ee56f2aed16ce9098e35bfae69e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#discussion_r379951593
 
 

 ##########
 File path: flink-dist/src/main/assemblies/opt.xml
 ##########
 @@ -168,6 +168,14 @@
 			<destName>flink-python_${scala.binary.version}-${project.version}.jar</destName>
 			<fileMode>0644</fileMode>
 		</file>
+
+		<!-- ML (API & LIB)  -->
+		<file>
 
 Review comment:
   For the table module, it makes no sense to let any sub-modules to bundle cep, so a uber module is used to create the bundled jar. but for ml module, it makes sense to let flink-ml-lib to bundle the flink-ml-api module, so that we can simply put the flink-ml-lib jar into the opt. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dianfu commented on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
dianfu commented on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#issuecomment-591220343
 
 
   @becketqin Would you like to take a final look at this PR?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#discussion_r382961514
 
 

 ##########
 File path: flink-ml-parent/flink-ml-lib/pom.xml
 ##########
 @@ -57,4 +57,30 @@ under the License.
 			<version>1.1.2</version>
 		</dependency>
 	</dependencies>
+
+	<build>
+		<plugins>
+			<!-- Build flink-ml-lib jar -->
+			<plugin>
+				<groupId>org.apache.maven.plugins</groupId>
+				<artifactId>maven-shade-plugin</artifactId>
+				<executions>
+					<execution>
+						<id>shade-flink</id>
+						<phase>package</phase>
+						<goals>
+							<goal>shade</goal>
+						</goals>
+						<configuration>
+							<artifactSet>
+								<includes combine.children="append">
+									<include>com.github.fommil.netlib:core</include>
 
 Review comment:
   @walterddr Hi, flink-ml-* are released by jar artifacts and the flink-ml-lib jar should not contain the license and notice file as it actually does not bundle the related dependencies. I have fired another issue([FLINK-16241](https://issues.apache.org/jira/browse/FLINK-16241)) and will open a corresponding PR to address the problem on release-1.10. :-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#discussion_r379443429
 
 

 ##########
 File path: flink-ml-parent/flink-ml-lib/pom.xml
 ##########
 @@ -57,4 +57,30 @@ under the License.
 			<version>1.1.2</version>
 		</dependency>
 	</dependencies>
+
+	<build>
+		<plugins>
+			<!-- Build flink-ml-lib jar -->
+			<plugin>
+				<groupId>org.apache.maven.plugins</groupId>
+				<artifactId>maven-shade-plugin</artifactId>
+				<executions>
+					<execution>
+						<id>shade-flink</id>
+						<phase>package</phase>
+						<goals>
+							<goal>shade</goal>
+						</goals>
+						<configuration>
+							<artifactSet>
+								<includes combine.children="append">
+									<include>com.github.fommil.netlib:core</include>
 
 Review comment:
   Why was the license already included if the dependency wasn't bundled so far?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#issuecomment-581294934
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "65debfebc1bad896666160a6375b9c78ea8eb063",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/147155607",
       "triggerID" : "65debfebc1bad896666160a6375b9c78ea8eb063",
       "triggerType" : "PUSH"
     }, {
       "hash" : "65debfebc1bad896666160a6375b9c78ea8eb063",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4764",
       "triggerID" : "65debfebc1bad896666160a6375b9c78ea8eb063",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1385f42a76ba0060d37022873064e736d52ea0af",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/147163976",
       "triggerID" : "1385f42a76ba0060d37022873064e736d52ea0af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1385f42a76ba0060d37022873064e736d52ea0af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4766",
       "triggerID" : "1385f42a76ba0060d37022873064e736d52ea0af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1edd078c466ee56f2aed16ce9098e35bfae69e",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5194",
       "triggerID" : "9c1edd078c466ee56f2aed16ce9098e35bfae69e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1edd078c466ee56f2aed16ce9098e35bfae69e",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/149075460",
       "triggerID" : "9c1edd078c466ee56f2aed16ce9098e35bfae69e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "478491bde663e58f1e84753bf6fac3a7367ef195",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150771112",
       "triggerID" : "478491bde663e58f1e84753bf6fac3a7367ef195",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 478491bde663e58f1e84753bf6fac3a7367ef195 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150771112) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#issuecomment-581294934
 
 
   <!--
   Meta data
   Hash:65debfebc1bad896666160a6375b9c78ea8eb063 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147155607 TriggerType:PUSH TriggerID:65debfebc1bad896666160a6375b9c78ea8eb063
   Hash:65debfebc1bad896666160a6375b9c78ea8eb063 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4764 TriggerType:PUSH TriggerID:65debfebc1bad896666160a6375b9c78ea8eb063
   -->
   ## CI report:
   
   * 65debfebc1bad896666160a6375b9c78ea8eb063 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147155607) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4764) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#discussion_r379933502
 
 

 ##########
 File path: flink-ml-parent/flink-ml-lib/pom.xml
 ##########
 @@ -57,4 +57,30 @@ under the License.
 			<version>1.1.2</version>
 		</dependency>
 	</dependencies>
+
+	<build>
+		<plugins>
+			<!-- Build flink-ml-lib jar -->
+			<plugin>
+				<groupId>org.apache.maven.plugins</groupId>
+				<artifactId>maven-shade-plugin</artifactId>
+				<executions>
+					<execution>
+						<id>shade-flink</id>
+						<phase>package</phase>
+						<goals>
+							<goal>shade</goal>
+						</goals>
+						<configuration>
+							<artifactSet>
+								<includes combine.children="append">
+									<include>com.github.fommil.netlib:core</include>
 
 Review comment:
   If the dependency is not bundled in 1.10 then yes, the licensing part of the commit should be reverted.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#discussion_r374521265
 
 

 ##########
 File path: flink-ml-parent/flink-ml-lib/pom.xml
 ##########
 @@ -57,4 +57,30 @@ under the License.
 			<version>1.1.2</version>
 		</dependency>
 	</dependencies>
+
+	<build>
+		<plugins>
+			<!-- Build flink-ml-lib jar -->
+			<plugin>
+				<groupId>org.apache.maven.plugins</groupId>
+				<artifactId>maven-shade-plugin</artifactId>
+				<executions>
+					<execution>
+						<id>shade-flink</id>
+						<phase>package</phase>
+						<goals>
+							<goal>shade</goal>
+						</goals>
+						<configuration>
+							<artifactSet>
+								<includes combine.children="append">
+									<include>com.github.fommil.netlib:core</include>
 
 Review comment:
   Hi, I'm not sure if I get your point. The license of `com.github.fommil.netlib:core` has already been included?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#discussion_r379444141
 
 

 ##########
 File path: flink-dist/src/main/assemblies/opt.xml
 ##########
 @@ -168,6 +168,14 @@
 			<destName>flink-python_${scala.binary.version}-${project.version}.jar</destName>
 			<fileMode>0644</fileMode>
 		</file>
+
+		<!-- ML (API & LIB)  -->
+		<file>
 
 Review comment:
   I agree that there should be an uber module. The current packaging also appears to be incorrect since flink-ml-api is _not_ bundled in flink-ml-lib anyway.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dianfu commented on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
dianfu commented on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#issuecomment-591964501
 
 
   Thanks @zentol @walterddr for the review and thanks @hequn8128 for the PR. Merging...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dianfu commented on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
dianfu commented on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#issuecomment-588021516
 
 
   @hequn8128 Thanks for the update. LGTM.
   
   @zentol Do you have any other comments?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#discussion_r379713878
 
 

 ##########
 File path: flink-ml-parent/flink-ml-lib/pom.xml
 ##########
 @@ -57,4 +57,30 @@ under the License.
 			<version>1.1.2</version>
 		</dependency>
 	</dependencies>
+
+	<build>
+		<plugins>
+			<!-- Build flink-ml-lib jar -->
+			<plugin>
+				<groupId>org.apache.maven.plugins</groupId>
+				<artifactId>maven-shade-plugin</artifactId>
+				<executions>
+					<execution>
+						<id>shade-flink</id>
+						<phase>package</phase>
+						<goals>
+							<goal>shade</goal>
+						</goals>
+						<configuration>
+							<artifactSet>
+								<includes combine.children="append">
+									<include>com.github.fommil.netlib:core</include>
 
 Review comment:
   @zentol The license has already been added by this commit https://github.com/apache/flink/pull/8631/files
   
   Or do you mean we should remove the licensing for release-1.10 and release-1.9? I think we can create a fix in another PR. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#discussion_r379278971
 
 

 ##########
 File path: flink-ml-parent/flink-ml-lib/pom.xml
 ##########
 @@ -57,4 +57,30 @@ under the License.
 			<version>1.1.2</version>
 		</dependency>
 	</dependencies>
+
+	<build>
+		<plugins>
+			<!-- Build flink-ml-lib jar -->
+			<plugin>
+				<groupId>org.apache.maven.plugins</groupId>
+				<artifactId>maven-shade-plugin</artifactId>
+				<executions>
+					<execution>
+						<id>shade-flink</id>
+						<phase>package</phase>
+						<goals>
+							<goal>shade</goal>
+						</goals>
+						<configuration>
+							<artifactSet>
+								<includes combine.children="append">
+									<include>com.github.fommil.netlib:core</include>
 
 Review comment:
   @zentol cc

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#discussion_r380194129
 
 

 ##########
 File path: flink-dist/src/main/assemblies/opt.xml
 ##########
 @@ -168,6 +168,14 @@
 			<destName>flink-python_${scala.binary.version}-${project.version}.jar</destName>
 			<fileMode>0644</fileMode>
 		</file>
+
+		<!-- ML (API & LIB)  -->
+		<file>
 
 Review comment:
   ok, let's add the uber module.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#discussion_r379933420
 
 

 ##########
 File path: flink-dist/src/main/assemblies/opt.xml
 ##########
 @@ -168,6 +168,14 @@
 			<destName>flink-python_${scala.binary.version}-${project.version}.jar</destName>
 			<fileMode>0644</fileMode>
 		</file>
+
+		<!-- ML (API & LIB)  -->
+		<file>
 
 Review comment:
   Where exactly do they differ? They both have multiple sub-modules that you want to ship as a single jar.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#issuecomment-581294934
 
 
   <!--
   Meta data
   Hash:65debfebc1bad896666160a6375b9c78ea8eb063 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147155607 TriggerType:PUSH TriggerID:65debfebc1bad896666160a6375b9c78ea8eb063
   Hash:65debfebc1bad896666160a6375b9c78ea8eb063 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4764 TriggerType:PUSH TriggerID:65debfebc1bad896666160a6375b9c78ea8eb063
   Hash:1385f42a76ba0060d37022873064e736d52ea0af Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147163976 TriggerType:PUSH TriggerID:1385f42a76ba0060d37022873064e736d52ea0af
   Hash:1385f42a76ba0060d37022873064e736d52ea0af Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4766 TriggerType:PUSH TriggerID:1385f42a76ba0060d37022873064e736d52ea0af
   -->
   ## CI report:
   
   * 65debfebc1bad896666160a6375b9c78ea8eb063 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147155607) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4764) 
   * 1385f42a76ba0060d37022873064e736d52ea0af Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147163976) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4766) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dianfu commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#discussion_r379294175
 
 

 ##########
 File path: flink-dist/src/main/assemblies/opt.xml
 ##########
 @@ -168,6 +168,14 @@
 			<destName>flink-python_${scala.binary.version}-${project.version}.jar</destName>
 			<fileMode>0644</fileMode>
 		</file>
+
+		<!-- ML (API & LIB)  -->
+		<file>
 
 Review comment:
   Should we add a module "flink-ml-uber" just like "flink-table-uber" to create a fat job for flink ml module? Currently it assumes that the flink-ml-api is packaged in the fat jar of flink-ml-lib. This seems a little wired for me. It would be great if more people could share the thoughts on this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#discussion_r379951593
 
 

 ##########
 File path: flink-dist/src/main/assemblies/opt.xml
 ##########
 @@ -168,6 +168,14 @@
 			<destName>flink-python_${scala.binary.version}-${project.version}.jar</destName>
 			<fileMode>0644</fileMode>
 		</file>
+
+		<!-- ML (API & LIB)  -->
+		<file>
 
 Review comment:
   For the table module, it makes no sense to let any sub-modules to bundle cep, so a uber module is used to create the bundled jar. but for ml module, it makes sense to let flink-ml-lib to bundle the flink-ml-api module, so that we can simply put the flink-ml-lib jar into the opt. 
   
   Anyway, I have created an uber module for the flink-ml in the latest pr. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] dianfu merged pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
dianfu merged pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#discussion_r379713304
 
 

 ##########
 File path: flink-dist/src/main/assemblies/opt.xml
 ##########
 @@ -168,6 +168,14 @@
 			<destName>flink-python_${scala.binary.version}-${project.version}.jar</destName>
 			<fileMode>0644</fileMode>
 		</file>
+
+		<!-- ML (API & LIB)  -->
+		<file>
 
 Review comment:
   Hi @dianfu @zentol Thanks for your advice.
   I would fine with adding an uber module. But I think there are some differences between the table module and the ml module. For table module, it needs a uber module to packages all table sub-modules plus other modules, e.g., cep. While for ml, there are no such requirements. 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#issuecomment-581294934
 
 
   <!--
   Meta data
   Hash:65debfebc1bad896666160a6375b9c78ea8eb063 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147155607 TriggerType:PUSH TriggerID:65debfebc1bad896666160a6375b9c78ea8eb063
   Hash:65debfebc1bad896666160a6375b9c78ea8eb063 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4764 TriggerType:PUSH TriggerID:65debfebc1bad896666160a6375b9c78ea8eb063
   Hash:1385f42a76ba0060d37022873064e736d52ea0af Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:1385f42a76ba0060d37022873064e736d52ea0af
   -->
   ## CI report:
   
   * 65debfebc1bad896666160a6375b9c78ea8eb063 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147155607) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4764) 
   * 1385f42a76ba0060d37022873064e736d52ea0af UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#issuecomment-581294934
 
 
   <!--
   Meta data
   Hash:65debfebc1bad896666160a6375b9c78ea8eb063 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147155607 TriggerType:PUSH TriggerID:65debfebc1bad896666160a6375b9c78ea8eb063
   Hash:65debfebc1bad896666160a6375b9c78ea8eb063 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4764 TriggerType:PUSH TriggerID:65debfebc1bad896666160a6375b9c78ea8eb063
   Hash:1385f42a76ba0060d37022873064e736d52ea0af Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147163976 TriggerType:PUSH TriggerID:1385f42a76ba0060d37022873064e736d52ea0af
   Hash:1385f42a76ba0060d37022873064e736d52ea0af Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4766 TriggerType:PUSH TriggerID:1385f42a76ba0060d37022873064e736d52ea0af
   -->
   ## CI report:
   
   * 65debfebc1bad896666160a6375b9c78ea8eb063 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147155607) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4764) 
   * 1385f42a76ba0060d37022873064e736d52ea0af Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147163976) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4766) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] walterddr commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
walterddr commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#discussion_r382748084
 
 

 ##########
 File path: flink-ml-parent/flink-ml-lib/pom.xml
 ##########
 @@ -57,4 +57,30 @@ under the License.
 			<version>1.1.2</version>
 		</dependency>
 	</dependencies>
+
+	<build>
+		<plugins>
+			<!-- Build flink-ml-lib jar -->
+			<plugin>
+				<groupId>org.apache.maven.plugins</groupId>
+				<artifactId>maven-shade-plugin</artifactId>
+				<executions>
+					<execution>
+						<id>shade-flink</id>
+						<phase>package</phase>
+						<goals>
+							<goal>shade</goal>
+						</goals>
+						<configuration>
+							<artifactSet>
+								<includes combine.children="append">
+									<include>com.github.fommil.netlib:core</include>
 
 Review comment:
   hmm. in fact the flink-ml-* packages are never release/bundled anyway. we should revert the LICENSE notice (in fact it shouldn't contain any LICENSE since only source codes were released: https://repo1.maven.org/maven2/org/apache/flink/flink-ml-lib_2.12/1.10.0/.
   
   How should we proceed? should we have a revert in release-1.10 branch only and keep this PR intact? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#issuecomment-581294934
 
 
   <!--
   Meta data
   Hash:65debfebc1bad896666160a6375b9c78ea8eb063 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147155607 TriggerType:PUSH TriggerID:65debfebc1bad896666160a6375b9c78ea8eb063
   Hash:65debfebc1bad896666160a6375b9c78ea8eb063 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4764 TriggerType:PUSH TriggerID:65debfebc1bad896666160a6375b9c78ea8eb063
   Hash:1385f42a76ba0060d37022873064e736d52ea0af Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/147163976 TriggerType:PUSH TriggerID:1385f42a76ba0060d37022873064e736d52ea0af
   Hash:1385f42a76ba0060d37022873064e736d52ea0af Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4766 TriggerType:PUSH TriggerID:1385f42a76ba0060d37022873064e736d52ea0af
   Hash:9c1edd078c466ee56f2aed16ce9098e35bfae69e Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5194 TriggerType:PUSH TriggerID:9c1edd078c466ee56f2aed16ce9098e35bfae69e
   Hash:9c1edd078c466ee56f2aed16ce9098e35bfae69e Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149075460 TriggerType:PUSH TriggerID:9c1edd078c466ee56f2aed16ce9098e35bfae69e
   -->
   ## CI report:
   
   * 65debfebc1bad896666160a6375b9c78ea8eb063 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147155607) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4764) 
   * 1385f42a76ba0060d37022873064e736d52ea0af Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/147163976) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4766) 
   * 9c1edd078c466ee56f2aed16ce9098e35bfae69e Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149075460) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5194) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on a change in pull request #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#discussion_r379951593
 
 

 ##########
 File path: flink-dist/src/main/assemblies/opt.xml
 ##########
 @@ -168,6 +168,14 @@
 			<destName>flink-python_${scala.binary.version}-${project.version}.jar</destName>
 			<fileMode>0644</fileMode>
 		</file>
+
+		<!-- ML (API & LIB)  -->
+		<file>
 
 Review comment:
   For the table module, it makes no sense to let any sub-modules to bundle cep, so a uber module is used to create the bundled jar. but for ml module, it makes sense to let flink-ml-lib to bundle the flink-ml-api module, so that we can simply put the flink-ml-lib jar into the opt. 
   
   However, as I said, I'm also fine with an uber module and have created an uber module for the flink-ml in the latest pr. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#issuecomment-581294934
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "65debfebc1bad896666160a6375b9c78ea8eb063",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/147155607",
       "triggerID" : "65debfebc1bad896666160a6375b9c78ea8eb063",
       "triggerType" : "PUSH"
     }, {
       "hash" : "65debfebc1bad896666160a6375b9c78ea8eb063",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4764",
       "triggerID" : "65debfebc1bad896666160a6375b9c78ea8eb063",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1385f42a76ba0060d37022873064e736d52ea0af",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/147163976",
       "triggerID" : "1385f42a76ba0060d37022873064e736d52ea0af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1385f42a76ba0060d37022873064e736d52ea0af",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4766",
       "triggerID" : "1385f42a76ba0060d37022873064e736d52ea0af",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1edd078c466ee56f2aed16ce9098e35bfae69e",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5194",
       "triggerID" : "9c1edd078c466ee56f2aed16ce9098e35bfae69e",
       "triggerType" : "PUSH"
     }, {
       "hash" : "9c1edd078c466ee56f2aed16ce9098e35bfae69e",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/149075460",
       "triggerID" : "9c1edd078c466ee56f2aed16ce9098e35bfae69e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9c1edd078c466ee56f2aed16ce9098e35bfae69e Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149075460) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5194) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#issuecomment-581294934
 
 
   <!--
   Meta data
   Hash:65debfebc1bad896666160a6375b9c78ea8eb063 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:65debfebc1bad896666160a6375b9c78ea8eb063
   -->
   ## CI report:
   
   * 65debfebc1bad896666160a6375b9c78ea8eb063 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] hequn8128 commented on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on issue #10995: [FLINK-15847][ml] Include flink-ml-api and flink-ml-lib in opt
URL: https://github.com/apache/flink/pull/10995#issuecomment-590023573
 
 
   @walterddr Hi, flink-ml-* are released by jar artifacts and the flink-ml-lib jar should not contain the license and notice file as it actually does not bundle the related dependencies. I have fired another issue([FLINK-16241](https://issues.apache.org/jira/browse/FLINK-16241)) and will open a corresponding PR to address the problem on release-1.10. :-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services