You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "easyice (via GitHub)" <gi...@apache.org> on 2026/09/21 11:42:31 UTC
[PR] Fix block-max support of DoubleValuesSource [lucene]
easyice opened a new pull request, #16697:
URL: https://github.com/apache/lucene/pull/16697
This change fixes two problems:
* `advanceShallow` advanced the skipper on every call, including when the target was still inside the current block, which may cause the skipper to move to the next block.
* `getMaxScore`,`getMinScore` only looked at level 0 of the skipper, including when `upTo` was beyond the current block, in which case the returned value only covers the current block, not the requested range.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Fix block-max support of DoubleValuesSource [lucene]
Posted by "easyice (via GitHub)" <gi...@apache.org>.
easyice commented on PR #16697:
URL: https://github.com/apache/lucene/pull/16697#issuecomment-5926114542
@rajat315315 @uschindler @msokolov This is a follow-up to #16431. Would you mind taking a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Fix block-max support of DoubleValuesSource [lucene]
Posted by "easyice (via GitHub)" <gi...@apache.org>.
easyice commented on PR #16697:
URL: https://github.com/apache/lucene/pull/16697#issuecomment-6080555078
No objections, merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Fix block-max support of DoubleValuesSource [lucene]
Posted by "easyice (via GitHub)" <gi...@apache.org>.
easyice merged PR #16697:
URL: https://github.com/apache/lucene/pull/16697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org