[GitHub] [dolphinscheduler] kezhenxu94 commented on a change in pull request #8179: [IMPROVEMENT-8178] Add Netty processor in Spring container

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #8179:
URL: https://github.com/apache/dolphinscheduler/pull/8179#discussion_r791552678



##########
File path: dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/alert/AlertClientService.java
##########
@@ -28,7 +28,7 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-public class AlertClientService {
+public class AlertClientService implements AutoCloseable {

Review comment:
       > does it add component annotation?
   
   This component depends on something that are not inside this module, so we have to initialize it in the module where needed, check `dolphinscheduler-worker/src/main/java/org/apache/dolphinscheduler/server/worker/config/BeanConfig.java`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org