Re: [PR] fix(backend): export API no longer returns stale resources [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #41689:
URL: https://github.com/apache/superset/pull/41689#issuecomment-4885072645

   The fix seems right, having`config.py` sett `SEND_FILE_MAX_AGE_DEFAULT` to a year for static assets and these exports inherit it, but it looks like a couple of call sites got missed though. The database export in `superset/databases/api.py` and the dashboard export-example endpoint in `superset/dashboards/api.py` use the same `send_file` pattern. Might be worth a small shared helper at this point. Ping me when it's out of draft and I'll take another look!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org