You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/04/19 21:01:29 UTC
Review Request: Fixed the slave to do disk usage calculations on the
filesystem on which the slave work directory is mounted.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10661/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Description
-------
See summary.
Diffs
-----
src/slave/slave.cpp a84ef902bfabe6cb70bb7001e895f89fec0c694e
Diff: https://reviews.apache.org/r/10661/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request: Fixed the slave to do disk usage calculations on the
filesystem on which the slave work directory is mounted.
Posted by Vinod Kone <vi...@gmail.com>.
> On April 19, 2013, 7:08 p.m., Ben Mahler wrote:
> > I would be good to update the documentation in stout/fs.hpp to reflect that the paths passed in are "the pathname of any file within the mounted file system".
done
> On April 19, 2013, 7:08 p.m., Ben Mahler wrote:
> > src/slave/slave.cpp, lines 154-155
> > <https://reviews.apache.org/r/10661/diff/1/?file=282788#file282788line154>
> >
> > I don't think this needs to be a note.
ah. but i like it :)
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10661/#review19465
-----------------------------------------------------------
On April 19, 2013, 7:44 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10661/
> -----------------------------------------------------------
>
> (Updated April 19, 2013, 7:44 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp a84ef902bfabe6cb70bb7001e895f89fec0c694e
> third_party/libprocess/third_party/stout/include/stout/fs.hpp 9f5a41605416f23ae96117a4dd9f48ed4f229c5c
>
> Diff: https://reviews.apache.org/r/10661/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fixed the slave to do disk usage calculations on the
filesystem on which the slave work directory is mounted.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10661/#review19465
-----------------------------------------------------------
Ship it!
I would be good to update the documentation in stout/fs.hpp to reflect that the paths passed in are "the pathname of any file within the mounted file system".
src/slave/slave.cpp
<https://reviews.apache.org/r/10661/#comment40208>
I don't think this needs to be a note.
src/slave/slave.cpp
<https://reviews.apache.org/r/10661/#comment40209>
ditto
- Ben Mahler
On April 19, 2013, 7:01 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10661/
> -----------------------------------------------------------
>
> (Updated April 19, 2013, 7:01 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp a84ef902bfabe6cb70bb7001e895f89fec0c694e
>
> Diff: https://reviews.apache.org/r/10661/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fixed the slave to do disk usage calculations on the
filesystem on which the slave work directory is mounted.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10661/
-----------------------------------------------------------
(Updated April 19, 2013, 7:44 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
bnem's. no need for review.
Description
-------
See summary.
Diffs (updated)
-----
src/slave/slave.cpp a84ef902bfabe6cb70bb7001e895f89fec0c694e
third_party/libprocess/third_party/stout/include/stout/fs.hpp 9f5a41605416f23ae96117a4dd9f48ed4f229c5c
Diff: https://reviews.apache.org/r/10661/diff/
Testing
-------
make check
Thanks,
Vinod Kone