You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/04/26 07:39:04 UTC

[GitHub] [iotdb] xuesyn opened a new pull request #3068: [IOTDB-1326] keep IoTDBConfig.java and iotdb-engine.properties consistent

xuesyn opened a new pull request #3068:
URL: https://github.com/apache/iotdb/pull/3068


   ## Description
    
   This PR solves issue in IOTDB-1326.
   
   <hr>
   
   This PR has:
   - [ ] been self-reviewed.
       - [ ] concurrent read
       - [ ] concurrent write
       - [ ] concurrent read and write 
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. 
   - [ ] added or updated version, __license__, or notice information
   - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious 
     for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold 
     for code coverage.
   - [ ] added integration tests.
   - [ ] been tested in a test IoTDB cluster.
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items 
   apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items 
   from the checklist above are strictly necessary, but it would be very helpful if you at least 
   self-review the PR. -->
   
   <hr>
   
   ##### Key changed/added classes (or packages if there are too many classes) in this PR
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] xuesyn commented on pull request #3068: [IOTDB-1326] keep IoTDBConfig.java and iotdb-engine.properties consistent

Posted by GitBox <gi...@apache.org>.
xuesyn commented on pull request #3068:
URL: https://github.com/apache/iotdb/pull/3068#issuecomment-826653828


   > There are some configurations in iotdb-cluster.properties that still not consistent with the code, could you please correct them together?
   
   ok


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] neuyilan closed pull request #3068: [IOTDB-1326] keep IoTDBConfig.java and iotdb-engine.properties consistent

Posted by GitBox <gi...@apache.org>.
neuyilan closed pull request #3068:
URL: https://github.com/apache/iotdb/pull/3068


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] neuyilan commented on pull request #3068: [IOTDB-1326] keep IoTDBConfig.java and iotdb-engine.properties consistent

Posted by GitBox <gi...@apache.org>.
neuyilan commented on pull request #3068:
URL: https://github.com/apache/iotdb/pull/3068#issuecomment-826597032


   There are some configurations in iotdb-cluster.properties that still not consistent with the code, could you please correct them together?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] neuyilan commented on pull request #3068: [IOTDB-1326] keep IoTDBConfig.java and iotdb-engine.properties consistent

Posted by GitBox <gi...@apache.org>.
neuyilan commented on pull request #3068:
URL: https://github.com/apache/iotdb/pull/3068#issuecomment-828879370


   Hi, as this pr is duplicate with https://github.com/apache/iotdb/pull/3071, I will close this PR.
   Thanks again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org