[GitHub] [druid] paul-rogers commented on a diff in pull request #13906: Report engine as a dimension for sqlQuery metrics

["paul-rogers (via GitHub)" <gi...@apache.org>]

paul-rogers commented on code in PR #13906:
URL: https://github.com/apache/druid/pull/13906#discussion_r1131433727


##########
sql/src/main/java/org/apache/druid/sql/SqlExecutionReporter.java:
##########
@@ -94,6 +94,9 @@ public void emit()
         metricBuilder.setDimension("id", plannerContext.getSqlQueryId());
         metricBuilder.setDimension("nativeQueryIds", plannerContext.getNativeQueryIds().toString());
       }
+      if (stmt.sqlToolbox.engine != null) {
+        metricBuilder.setDimension("engine", stmt.sqlToolbox.engine.name());

Review Comment:
   The toolbox is never null. The engine is also never null, so no need for the `null` check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org