You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/26 23:58:37 UTC

[GitHub] [superset] eschutho commented on pull request #19855: feat(explore): Frontend implementation of dataset creation from infobox

eschutho commented on PR #19855:
URL: https://github.com/apache/superset/pull/19855#issuecomment-1139160022

   looking good. I think there are a few more places where we don't need the type coercion or more specifically only when there's a property that doesn't exist on datasource. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org