[GitHub] [incubator-superset] merkliopas commented on issue #8306: Add GroupyBy field to the Big Number

[GitBox <gi...@apache.org>]

merkliopas commented on issue #8306: Add GroupyBy field to the Big Number
URL: https://github.com/apache/incubator-superset/issues/8306#issuecomment-576178360
 
 
   > @villebro I will try that, thank you. Is there a reason superset doesn't include group by for big number query? I see a cypress test that checks it is not there... and it would seem pretty easy to add BigNumber.js under controls just add the 'groupby' to the query controls. I forked the repo and tested this out and it works... were there some side effects that caused you to remove the groupby from the control set for big number?
   
   I second the above question. could any body elaborate on the reasons?
   
   @timurista - could you share your code with the changes? that would be helpful, as I'm trying to make sense of superset code and change to suit my usecases

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org