You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by GitBox <gi...@apache.org> on 2022/05/24 22:03:48 UTC
[GitHub] [karaf-cellar] CMoH opened a new pull request, #86: [KARAF-7145] Add kube namespace config option
CMoH opened a new pull request, #86:
URL: https://github.com/apache/karaf-cellar/pull/86
I still have to test this, but I will certainly have to. Any notes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf-cellar] CMoH commented on pull request #86: [KARAF-7145] Add kube namespace config option
Posted by "CMoH (via GitHub)" <gi...@apache.org>.
CMoH commented on PR #86:
URL: https://github.com/apache/karaf-cellar/pull/86#issuecomment-1427184913
I added a kube-client autoconfiguration facility and made this work (avoiding some NPE traps). Also added some docs which I would have found useful while putting the Kubernetes discovery mechanism in use.
Keep me posted if you find this interesting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf-cellar] CMoH commented on pull request #86: [KARAF-7145] Add kube namespace config option
Posted by "CMoH (via GitHub)" <gi...@apache.org>.
CMoH commented on PR #86:
URL: https://github.com/apache/karaf-cellar/pull/86#issuecomment-1465172465
Rebased. Seems all tests pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf-cellar] jbonofre commented on pull request #86: [KARAF-7145] Add kube namespace config option
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #86:
URL: https://github.com/apache/karaf-cellar/pull/86#issuecomment-1465218297
@CMoH thanks ! Let me do a new pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf-cellar] jbonofre commented on pull request #86: [KARAF-7145] Add kube namespace config option
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #86:
URL: https://github.com/apache/karaf-cellar/pull/86#issuecomment-1459613980
FYI, there is a complete refactoring of Cellar ongoing (Cellar 3.x).
This kind of change is valid only for Cellar 2.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf-cellar] CMoH commented on pull request #86: [KARAF-7145] Add kube namespace config option
Posted by "CMoH (via GitHub)" <gi...@apache.org>.
CMoH commented on PR #86:
URL: https://github.com/apache/karaf-cellar/pull/86#issuecomment-1460903320
> FYI, there is a complete refactoring of Cellar ongoing (Cellar 3.x). This kind of change is valid only for Cellar 2.x.
You might be using these version references (3.x, 2.x) internally. The current patch(es) were made against the main branch of the cellar repo, which is supposed to build 4.2.2-SNAPSHOT. Will these refactorings bump the version to 5.x.x? Or to 4.3.x?
@fpapon I will squash the commits and rebase on the current main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [karaf-cellar] jbonofre commented on pull request #86: [KARAF-7145] Add kube namespace config option
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #86:
URL: https://github.com/apache/karaf-cellar/pull/86#issuecomment-1461404544
Sorry I wasn't clear: I will create cellar 4.x branch. Mail will become cellar 5.x and will welcome the big refactoring (locally on my machine for now).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org