You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by franz1981 <gi...@git.apache.org> on 2018/12/10 09:57:24 UTC

[GitHub] activemq-artemis pull request #2457: ARTEMIS-2193 Artemis fails on OutOfMemo...

GitHub user franz1981 opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2457

    ARTEMIS-2193 Artemis fails on OutOfMemoryError with fast producers

    Large messages pendingRecordID is not accessed atomically, leading
    to races that would lead to records that cannot been found on the
    journal for deletion: it would lead to cause NPE that won't clean
    the pending tasks on the current OperationContextImpl.
    Adding a cleanup on error of those tasks and avoiding the race
    to happen by adding proper synchronization will both enforce
    correct clean up when something bad happen and avoid NPE.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/franz1981/activemq-artemis ARTEMIS-2193

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2457.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2457
    
----
commit e35288d0d984ed03b0995c4f6432825acc698b74
Author: Francesco Nigro <ni...@...>
Date:   2018-12-07T08:35:08Z

    ARTEMIS-2193 Artemis fails on OutOfMemoryError with fast producers
    
    Large messages pendingRecordID is not accessed atomically, leading
    to races that would lead to records that cannot been found on the
    journal for deletion: it would lead to cause NPE that won't clean
    the pending tasks on the current OperationContextImpl.
    Adding a cleanup on error of those tasks and avoiding the race
    to happen by adding proper synchronization will both enforce
    correct clean up when something bad happen and avoid NPE.

----


---

[GitHub] activemq-artemis issue #2457: ARTEMIS-2193 Artemis fails on OutOfMemoryError...

Posted by franz1981 <gi...@git.apache.org>.

Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2457
  
    @wy96f @clebertsuconic Guys, you're very deep inside the large messages mechanics so I bring this one to your attention, if you can take a look :+1: 


---

[GitHub] activemq-artemis pull request #2457: ARTEMIS-2193 Artemis fails on OutOfMemo...

Posted by franz1981 <gi...@git.apache.org>.

Github user franz1981 closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/2457


---

[GitHub] activemq-artemis issue #2457: ARTEMIS-2193 Artemis fails on OutOfMemoryError...

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2457
  
    Is this specific to drop ?


---

[GitHub] activemq-artemis issue #2457: ARTEMIS-2193 Artemis fails on OutOfMemoryError...

Posted by franz1981 <gi...@git.apache.org>.

Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2457
  
    @clebertsuconic Seems that both drop/fail policies are racing on the large message while deleting the record from the journal


---

[GitHub] activemq-artemis issue #2457: ARTEMIS-2193 Artemis fails on OutOfMemoryError...

Posted by franz1981 <gi...@git.apache.org>.

Github user franz1981 commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2457
  
    I'm closing this one that will be replaced by https://github.com/apache/activemq-artemis/pull/2459


---