You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org> on 2022/04/20 09:32:08 UTC

[Impala-ASF-CR] IMPALA-11233: Unset all query option When using jdbc connection pool, a connection set some query option, after query finished, connection is closed and put back to the connection pool. When connection used again, the last query option also come into affe

Xiaoqing Gao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18430


Change subject: IMPALA-11233: Unset all query option When using jdbc connection pool, a connection set some query option, after query finished, connection is closed and put back to the connection pool. When connection used again, the last query option also come into affe
......................................................................

IMPALA-11233: Unset all query option
When using jdbc connection pool, a connection set some query option,
after query finished, connection is closed and put back to the connection pool.
When connection used again, the last query option also come into affect.
We need a feature that a set statement can reset all query option without restart impalad.

Support UNSET statements in SQL dialect. UNSET ALL can unset all query option.

Testing:
  - add unset all query option in test_hs2.py

Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
---
M be/src/service/client-request-state.cc
M be/src/service/query-options.cc
M be/src/service/query-options.h
M common/thrift/Frontend.thrift
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/SetStmt.java
M shell/impala_shell.py
M tests/hs2/test_hs2.py
8 files changed, 68 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/18430/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 1
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Anonymous Coward (339) has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 8: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 8
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Anonymous Coward (339)
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 30 May 2022 11:06:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Jian Zhang, Gabor Kaszab, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18430

to look at the new patch set (#9).

Change subject: IMPALA-11233: Unset all query option
......................................................................

IMPALA-11233: Unset all query option

When using jdbc connection pool, a connection set some query options,
after query finished, connection is closed and put back to the connection
pool. When connection used again, the last query option also come into
effect. We need a feature that a set statement can reset all query option
without recreating a new connection.

Support UNSET statements in SQL dialect. UNSET ALL can unset all query
option.

Testing:
  - add unset all query option in test_hs2.py

Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
---
M be/src/service/client-request-state.cc
M be/src/service/query-options.cc
M be/src/service/query-options.h
M common/thrift/Frontend.thrift
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/SetStmt.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M shell/impala_shell.py
M tests/custom_cluster/test_set_and_unset.py
M tests/hs2/test_hs2.py
M tests/shell/test_shell_interactive.py
11 files changed, 133 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/18430/9
-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 9
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 13:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8224/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 13
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 13 Jun 2022 12:29:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 13:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8240/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 13
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Thu, 16 Jun 2022 06:45:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 13:

Merging this. Thanks for your contribution, Xiaoqing!


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 13
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 20 Jun 2022 12:35:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 14:

(1 comment)

We recently add tests on Python3. Please fix the test failures on this patch.

http://gerrit.cloudera.org:8080/#/c/18430/14/tests/shell/test_shell_interactive.py
File tests/shell/test_shell_interactive.py:

http://gerrit.cloudera.org:8080/#/c/18430/14/tests/shell/test_shell_interactive.py@706
PS14, Line 706:     assert "\tMT_DOP: " in result.stdout
This fails in Python3:
https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/5879/testReport/shell.test_shell_interactive/TestImpalaShellInteractive/test_query_option_configuration_impala_shell__python3___strict_hs2_protocol__False___protocol__hs2___exec_option____test_replan___1___batch_size___0___num_nodes___0___disable_codegen_rows_threshold___5000___disable_codegen___False___abort_on_error___1___exec_single_node_rows_threshold___0____table_format__text_none_/



-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 14
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Tue, 21 Jun 2022 03:08:01 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 16: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 16
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Thu, 23 Jun 2022 05:59:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 13:

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8240/


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 13
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Thu, 16 Jun 2022 11:16:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 9:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10728/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 9
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Wed, 08 Jun 2022 10:26:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 6:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10649/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 6
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Fri, 27 May 2022 12:11:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 16:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8264/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 16
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Thu, 23 Jun 2022 01:16:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18430

to look at the new patch set (#4).

Change subject: IMPALA-11233: Unset all query option
......................................................................

IMPALA-11233: Unset all query option

When using jdbc connection pool, a connection set some query option,
after query finished, connection is closed and put back to the connection
pool. When connection used again, the last query option also come into
affect. We need a feature that a set statement can reset all query option
without restart impalad.

Support UNSET statements in SQL dialect. UNSET ALL can unset all query
option.

Testing:
  - add unset all query option in test_hs2.py

Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
---
M be/src/service/client-request-state.cc
M be/src/service/query-options.cc
M be/src/service/query-options.h
M common/thrift/Frontend.thrift
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/SetStmt.java
M shell/impala_shell.py
M tests/hs2/test_hs2.py
8 files changed, 69 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/18430/4
-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 4
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 10:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10729/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 10
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Wed, 08 Jun 2022 10:27:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 12:

(1 comment)

There is a FE test failure. You can rerun it individually by

 (pushd fe && mvn test -Dtest=ParserTest#TestGetErrorMsg)

http://gerrit.cloudera.org:8080/#/c/18430/12/fe/src/test/java/org/apache/impala/analysis/ParserTest.java
File fe/src/test/java/org/apache/impala/analysis/ParserTest.java:

http://gerrit.cloudera.org:8080/#/c/18430/12/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3508
PS12, Line 3508: TRUNCATE, UPDATE
The test failure means we should add "UNSET" here, i.e. "TRUNCATE, UPDATE" -> "TRUNCATE, UNSET, UPDATE"

https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/16698/testReport/junit/org.apache.impala.analysis/ParserTest/TestGetErrorMsg_2/



-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 12
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 13 Jun 2022 01:28:31 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 15: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 15
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 12:49:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 13: Code-Review+2

> Patch Set 13:
> 
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8240/

The failure is due to IMPALA-11160 and is unrelated to this patch:
https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/5864


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 13
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 20 Jun 2022 12:35:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18430

to look at the new patch set (#3).

Change subject: IMPALA-11233: Unset all query option
......................................................................

IMPALA-11233: Unset all query option

When using jdbc connection pool, a connection set some query option,
after query finished, connection is closed and put back to the
connection pool. When connection used again, the last query option
also come into affect. We need a feature that a set statement can
reset all query option without restart impalad.

Support UNSET statements in SQL dialect. UNSET ALL can unset all query option.

Testing:
  - add unset all query option in test_hs2.py

Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
---
M be/src/service/client-request-state.cc
M be/src/service/query-options.cc
M be/src/service/query-options.h
M common/thrift/Frontend.thrift
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/SetStmt.java
M shell/impala_shell.py
M tests/hs2/test_hs2.py
8 files changed, 69 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/18430/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 3
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 3:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/18430/3/be/src/service/query-options.cc
File be/src/service/query-options.cc:

http://gerrit.cloudera.org:8080/#/c/18430/3/be/src/service/query-options.cc@1301
PS3, Line 1301: Status impala::ResetAllQueryOptions(TQueryOptions* query_options, QueryOptionsMask* mask) 
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/18430/3/tests/hs2/test_hs2.py
File tests/hs2/test_hs2.py:

http://gerrit.cloudera.org:8080/#/c/18430/3/tests/hs2/test_hs2.py@147
PS3, Line 147:     
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/18430/3/tests/hs2/test_hs2.py@147
PS3, Line 147:     
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/18430/3/tests/hs2/test_hs2.py@148
PS3, Line 148: )
flake8: E999 IndentationError: unindent does not match any outer indentation level



-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 3
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Apr 2022 09:48:55 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 15:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10835/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 15
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 08:14:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.
Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 14:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18430/14/tests/shell/test_shell_interactive.py
File tests/shell/test_shell_interactive.py:

http://gerrit.cloudera.org:8080/#/c/18430/14/tests/shell/test_shell_interactive.py@706
PS14, Line 706:     assert "\tMT_DOP: " in result.stdout
> This fails in Python3:
Thanks for your help. I fixed this case and triggered jenkins job again.



-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 14
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 07:59:37 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Anonymous Coward (339), Gabor Kaszab, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18430

to look at the new patch set (#7).

Change subject: IMPALA-11233: Unset all query option
......................................................................

IMPALA-11233: Unset all query option

When using jdbc connection pool, a connection set some query option,
after query finished, connection is closed and put back to the connection
pool. When connection used again, the last query option also come into
affect. We need a feature that a set statement can reset all query option
without restart impalad.

Support UNSET statements in SQL dialect. UNSET ALL can unset all query
option.

Testing:
  - add unset all query option in test_hs2.py

Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
---
M be/src/service/client-request-state.cc
M be/src/service/query-options.cc
M be/src/service/query-options.h
M common/thrift/Frontend.thrift
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/SetStmt.java
M shell/impala_shell.py
M tests/hs2/test_hs2.py
8 files changed, 91 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/18430/7
-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 7
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Anonymous Coward (339)
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Anonymous Coward (339), Gabor Kaszab, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18430

to look at the new patch set (#8).

Change subject: IMPALA-11233: Unset all query option
......................................................................

IMPALA-11233: Unset all query option

When using jdbc connection pool, a connection set some query option,
after query finished, connection is closed and put back to the connection
pool. When connection used again, the last query option also come into
affect. We need a feature that a set statement can reset all query option
without restart impalad.

Support UNSET statements in SQL dialect. UNSET ALL can unset all query
option.

Testing:
  - add unset all query option in test_hs2.py

Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
---
M be/src/service/client-request-state.cc
M be/src/service/query-options.cc
M be/src/service/query-options.h
M common/thrift/Frontend.thrift
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/SetStmt.java
M shell/impala_shell.py
M tests/hs2/test_hs2.py
8 files changed, 90 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/18430/8
-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 8
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Anonymous Coward (339)
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 14:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8251/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 14
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 20 Jun 2022 12:36:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Jian Zhang, Gabor Kaszab, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18430

to look at the new patch set (#10).

Change subject: IMPALA-11233: Unset all query option
......................................................................

IMPALA-11233: Unset all query option

When using jdbc connection pool, a connection set some query options,
after query finished, connection is closed and put back to the connection
pool. When connection used again, the last query option also come into
effect. We need a feature that a set statement can reset all query option
without recreating a new connection.

Support UNSET statements in SQL dialect. UNSET ALL can unset all query
option.

Testing:
  - add unset all query option in test_hs2.py

Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
---
M be/src/service/client-request-state.cc
M be/src/service/query-options.cc
M be/src/service/query-options.h
M common/thrift/Frontend.thrift
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/SetStmt.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M shell/impala_shell.py
M tests/custom_cluster/test_set_and_unset.py
M tests/hs2/test_hs2.py
M tests/shell/test_shell_interactive.py
11 files changed, 132 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/18430/10
-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 10
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 11:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8203/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 11
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Wed, 08 Jun 2022 12:20:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.
Xiaoqing Gao has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................

IMPALA-11233: Unset all query option

When using jdbc connection pool, a connection set some query option,
after query finished, connection is closed and put back to the connection pool.
When connection used again, the last query option also come into affect.
We need a feature that a set statement can reset all query option without restart impalad.

Support UNSET statements in SQL dialect. UNSET ALL can unset all query option.

Testing:
  - add unset all query option in test_hs2.py

Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
---
M be/src/service/client-request-state.cc
M be/src/service/query-options.cc
M be/src/service/query-options.h
M common/thrift/Frontend.thrift
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/SetStmt.java
M shell/impala_shell.py
M tests/hs2/test_hs2.py
8 files changed, 68 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/18430/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 2
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Gabor Kaszab, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18430

to look at the new patch set (#5).

Change subject: IMPALA-11233: Unset all query option
......................................................................

IMPALA-11233: Unset all query option

When using jdbc connection pool, a connection set some query option,
after query finished, connection is closed and put back to the connection
pool. When connection used again, the last query option also come into
affect. We need a feature that a set statement can reset all query option
without restart impalad.

Support UNSET statements in SQL dialect. UNSET ALL can unset all query
option.

Testing:
  - add unset all query option in test_hs2.py

Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
---
M be/src/service/client-request-state.cc
M be/src/service/query-options.cc
M be/src/service/query-options.h
M common/thrift/Frontend.thrift
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/SetStmt.java
M shell/impala_shell.py
M tests/hs2/test_hs2.py
8 files changed, 72 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/18430/5
-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 5
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 13: Code-Review+1

> Patch Set 13: Verified-1
> 
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8224/

The failure is due to two flaky tests: IMPALA-10927 and IMPALA-11352.

This patch LGTM.


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 13
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Wed, 15 Jun 2022 02:32:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Jian Zhang, Gabor Kaszab, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18430

to look at the new patch set (#15).

Change subject: IMPALA-11233: Unset all query option
......................................................................

IMPALA-11233: Unset all query option

When using jdbc connection pool, a connection set some query options,
after query finished, connection is closed and put back to the connection
pool. When connection used again, the last query option also come into
effect. We need a feature that a set statement can reset all query option
without recreating a new connection.

Support UNSET statements in SQL dialect. UNSET ALL can unset all query
option.

Testing:
  - add unset all query option in test_hs2.py

Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
---
M be/src/service/client-request-state.cc
M be/src/service/query-options.cc
M be/src/service/query-options.h
M common/thrift/Frontend.thrift
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/SetStmt.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M shell/impala_shell.py
M tests/custom_cluster/test_set_and_unset.py
M tests/hs2/test_hs2.py
M tests/shell/test_shell_interactive.py
12 files changed, 132 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/18430/15
-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 15
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 15:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8257/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 15
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Jun 2022 07:55:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 14: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8251/


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 14
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 20 Jun 2022 17:20:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10468/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 3
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Apr 2022 10:08:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 12: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8207/


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 12
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Thu, 09 Jun 2022 08:01:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 11: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8203/


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 11
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Wed, 08 Jun 2022 17:04:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 12:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8207/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 12
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Thu, 09 Jun 2022 03:27:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 15: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 15
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Thu, 23 Jun 2022 01:14:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.
Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18430/6/fe/src/main/java/org/apache/impala/analysis/SetStmt.java
File fe/src/main/java/org/apache/impala/analysis/SetStmt.java:

http://gerrit.cloudera.org:8080/#/c/18430/6/fe/src/main/java/org/apache/impala/analysis/SetStmt.java@30
PS6, Line 30: private final String value_;
            :   private final TQueryOptionTy
> Seems like the `SetStmt` can only be one of the following modes:
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 8
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Anonymous Coward (339)
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 30 May 2022 08:54:10 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18430/7/be/src/service/query-options.cc
File be/src/service/query-options.cc:

http://gerrit.cloudera.org:8080/#/c/18430/7/be/src/service/query-options.cc@1295
PS7, Line 1295:   QUERY_OPTS_TABLE 
line has trailing whitespace



-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 7
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Anonymous Coward (339)
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 30 May 2022 08:51:57 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 8:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10661/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 8
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Anonymous Coward (339)
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 30 May 2022 09:12:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10648/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 5
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Fri, 27 May 2022 10:13:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Anonymous Coward (339) has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18430/6/fe/src/main/java/org/apache/impala/analysis/SetStmt.java
File fe/src/main/java/org/apache/impala/analysis/SetStmt.java:

http://gerrit.cloudera.org:8080/#/c/18430/6/fe/src/main/java/org/apache/impala/analysis/SetStmt.java@30
PS6, Line 30: private final boolean isSetAll_;
            :   private boolean isUnsetAll_;
Seems like the `SetStmt` can only be one of the following modes:
- set one (key, value)
- set all
- unset all

How about using an enum to indicate the modes, so that we can use `switch ... case ...` to replace the `if` statements in the `toSql()` and `toThrift()` functions. It can also help to improve the code readability and maintainability.

The enum can be designed to have three options:
- SetOne
- SetAll
- UnSetAll



-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 6
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Anonymous Coward (339)
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Fri, 27 May 2022 12:40:22 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................

IMPALA-11233: Unset all query option

When using jdbc connection pool, a connection set some query options,
after query finished, connection is closed and put back to the connection
pool. When connection used again, the last query option also come into
effect. We need a feature that a set statement can reset all query option
without recreating a new connection.

Support UNSET statements in SQL dialect. UNSET ALL can unset all query
option.

Testing:
  - add unset all query option in test_hs2.py

Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Reviewed-on: http://gerrit.cloudera.org:8080/18430
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/service/client-request-state.cc
M be/src/service/query-options.cc
M be/src/service/query-options.h
M common/thrift/Frontend.thrift
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/SetStmt.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M shell/impala_shell.py
M tests/custom_cluster/test_set_and_unset.py
M tests/hs2/test_hs2.py
M tests/shell/test_shell_interactive.py
12 files changed, 132 insertions(+), 17 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 17
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 7:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10660/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 7
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Anonymous Coward (339)
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 30 May 2022 09:11:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.
Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 11:

DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 11
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Wed, 08 Jun 2022 10:43:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.
Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 11:

(9 comments)

http://gerrit.cloudera.org:8080/#/c/18430/8//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18430/8//COMMIT_MSG@9
PS8, Line 9: options
> nit: options.
Done


http://gerrit.cloudera.org:8080/#/c/18430/8//COMMIT_MSG@12
PS8, Line 12: effect
> nit: effect?
Done


http://gerrit.cloudera.org:8080/#/c/18430/8//COMMIT_MSG@13
PS8, Line 13: recreating a ne
> I think users can re-create a connection instead of restarting the impalad.
Done


http://gerrit.cloudera.org:8080/#/c/18430/8/be/src/service/client-request-state.cc
File be/src/service/client-request-state.cc:

http://gerrit.cloudera.org:8080/#/c/18430/8/be/src/service/client-request-state.cc@284
PS8, Line 284:       } else if (exec_request_->set_query_option_request.__isset.query_option_type
> I think we should also check "exec_request_->set_query_option_request.__iss
Done


http://gerrit.cloudera.org:8080/#/c/18430/8/be/src/service/query-options.cc
File be/src/service/query-options.cc:

http://gerrit.cloudera.org:8080/#/c/18430/8/be/src/service/query-options.cc@1309
PS8, Line 1309: TQueryOptions* que
> I think this should be "DCHECK_GE(option, 0)". Query options generated in Q
Thanks for the great suggestion.


http://gerrit.cloudera.org:8080/#/c/18430/8/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java:

http://gerrit.cloudera.org:8080/#/c/18430/8/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@4639
PS8, Line 4639:     AnalyzesOk("set");
> Could you add a test here for "unset all"?
Done


http://gerrit.cloudera.org:8080/#/c/18430/8/shell/impala_shell.py
File shell/impala_shell.py:

http://gerrit.cloudera.org:8080/#/c/18430/8/shell/impala_shell.py@895
PS8, Line 895:     elif option == 'ALL':
> Let's print some info like the above cases.
Done


http://gerrit.cloudera.org:8080/#/c/18430/8/tests/custom_cluster/test_set_and_unset.py
File tests/custom_cluster/test_set_and_unset.py:

http://gerrit.cloudera.org:8080/#/c/18430/8/tests/custom_cluster/test_set_and_unset.py@86
PS8, Line 86: 
> Could you add some tests here? We need to test that if impala is launched w
Done


http://gerrit.cloudera.org:8080/#/c/18430/8/tests/shell/test_shell_interactive.py
File tests/shell/test_shell_interactive.py:

http://gerrit.cloudera.org:8080/#/c/18430/8/tests/shell/test_shell_interactive.py@686
PS8, Line 686:     assert "\tDEFAULT_FILE_FORMAT: avro" in result.stdout
> Can we add a test for "unset all" here? We currently don't have tests on im
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 11
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Wed, 08 Jun 2022 10:10:48 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/18430/1/be/src/service/query-options.cc
File be/src/service/query-options.cc:

http://gerrit.cloudera.org:8080/#/c/18430/1/be/src/service/query-options.cc@1301
PS1, Line 1301: Status impala::ResetAllQueryOptions(TQueryOptions* query_options, QueryOptionsMask* mask) {
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/18430/1/tests/hs2/test_hs2.py
File tests/hs2/test_hs2.py:

http://gerrit.cloudera.org:8080/#/c/18430/1/tests/hs2/test_hs2.py@147
PS1, Line 147:     
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/18430/1/tests/hs2/test_hs2.py@147
PS1, Line 147:     
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/18430/1/tests/hs2/test_hs2.py@148
PS1, Line 148: )
flake8: E999 IndentationError: unindent does not match any outer indentation level



-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 1
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Apr 2022 09:33:01 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 4:

(4 comments)

Thanks for taking care of this patch! It looks fine in general, I just left some minor comments.

http://gerrit.cloudera.org:8080/#/c/18430/4/be/src/service/query-options.h
File be/src/service/query-options.h:

http://gerrit.cloudera.org:8080/#/c/18430/4/be/src/service/query-options.h@344
PS4, Line 344: Status ResetAllQueryOptions(TQueryOptions* query_options, QueryOptionsMask* mask);
Could you please write some comment for this functions as you see for the others above?


http://gerrit.cloudera.org:8080/#/c/18430/4/be/src/service/query-options.cc
File be/src/service/query-options.cc:

http://gerrit.cloudera.org:8080/#/c/18430/4/be/src/service/query-options.cc@1301
PS4, Line 1301: mask
nit: I see at other functions that they call this param as 'set_query_options_mask'. I find it more verbose to know the purpose.


http://gerrit.cloudera.org:8080/#/c/18430/4/be/src/service/query-options.cc@1307
PS4, Line 1307:     query_options->__isset.NAME = defaults.__isset.NAME; \
is there a case when defaults.__isset.NAME is true? Can't we simply set query_options->__isset.NAME to false?


http://gerrit.cloudera.org:8080/#/c/18430/4/fe/src/main/java/org/apache/impala/analysis/SetStmt.java
File fe/src/main/java/org/apache/impala/analysis/SetStmt.java:

http://gerrit.cloudera.org:8080/#/c/18430/4/fe/src/main/java/org/apache/impala/analysis/SetStmt.java@55
PS4, Line 55:   public SetStmt(boolean isUnsetAll) {
At the callsite of this when you see "new SetStmt(true)" it's not really self descriptive what that true means.
I'd rather use the existing constructor and set the 'isUnsetAll_' member in a next step.



-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 4
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 03 May 2022 14:31:49 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 13: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8224/


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 13
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 13 Jun 2022 17:03:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Jian Zhang, Gabor Kaszab, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18430

to look at the new patch set (#13).

Change subject: IMPALA-11233: Unset all query option
......................................................................

IMPALA-11233: Unset all query option

When using jdbc connection pool, a connection set some query options,
after query finished, connection is closed and put back to the connection
pool. When connection used again, the last query option also come into
effect. We need a feature that a set statement can reset all query option
without recreating a new connection.

Support UNSET statements in SQL dialect. UNSET ALL can unset all query
option.

Testing:
  - add unset all query option in test_hs2.py

Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
---
M be/src/service/client-request-state.cc
M be/src/service/query-options.cc
M be/src/service/query-options.h
M common/thrift/Frontend.thrift
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/SetStmt.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M shell/impala_shell.py
M tests/custom_cluster/test_set_and_unset.py
M tests/hs2/test_hs2.py
M tests/shell/test_shell_interactive.py
12 files changed, 132 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/18430/13
-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 13
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 13:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10758/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 13
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 13 Jun 2022 12:49:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 14: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 14
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Mon, 20 Jun 2022 12:36:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 16: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 16
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Thu, 23 Jun 2022 01:16:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10467/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 1
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Apr 2022 09:52:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10469/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 4
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Apr 2022 10:22:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.
Xiaoqing Gao has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 5:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/18430/4/be/src/service/query-options.h
File be/src/service/query-options.h:

http://gerrit.cloudera.org:8080/#/c/18430/4/be/src/service/query-options.h@344
PS4, Line 344: /// Reset all query options to its default value if they are not equal to default value.
> Could you please write some comment for this functions as you see for the o
Done


http://gerrit.cloudera.org:8080/#/c/18430/4/be/src/service/query-options.cc
File be/src/service/query-options.cc:

http://gerrit.cloudera.org:8080/#/c/18430/4/be/src/service/query-options.cc@1301
PS4, Line 1301: set_
> nit: I see at other functions that they call this param as 'set_query_optio
Done


http://gerrit.cloudera.org:8080/#/c/18430/4/be/src/service/query-options.cc@1307
PS4, Line 1307:     query_options->NAME = defaults.NAME; \
> is there a case when defaults.__isset.NAME is true? Can't we simply set que
Done


http://gerrit.cloudera.org:8080/#/c/18430/4/fe/src/main/java/org/apache/impala/analysis/SetStmt.java
File fe/src/main/java/org/apache/impala/analysis/SetStmt.java:

http://gerrit.cloudera.org:8080/#/c/18430/4/fe/src/main/java/org/apache/impala/analysis/SetStmt.java@55
PS4, Line 55:   public SetStmt(String key, String value, boolean isSetAll, boolean isUnsetAll) {
> At the callsite of this when you see "new SetStmt(true)" it's not really se
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 5
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Fri, 27 May 2022 09:53:47 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18430/5/be/src/service/query-options.h
File be/src/service/query-options.h:

http://gerrit.cloudera.org:8080/#/c/18430/5/be/src/service/query-options.h@346
PS5, Line 346: Status ResetAllQueryOptions(TQueryOptions* query_options, QueryOptionsMask* set_query_options_mask);
line too long (100 > 90)


http://gerrit.cloudera.org:8080/#/c/18430/5/be/src/service/query-options.cc
File be/src/service/query-options.cc:

http://gerrit.cloudera.org:8080/#/c/18430/5/be/src/service/query-options.cc@1301
PS5, Line 1301: Status impala::ResetAllQueryOptions(TQueryOptions* query_options, QueryOptionsMask* set_query_options_mask)
line too long (107 > 90)



-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 5
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Fri, 27 May 2022 09:54:11 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Gabor Kaszab, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18430

to look at the new patch set (#6).

Change subject: IMPALA-11233: Unset all query option
......................................................................

IMPALA-11233: Unset all query option

When using jdbc connection pool, a connection set some query option,
after query finished, connection is closed and put back to the connection
pool. When connection used again, the last query option also come into
affect. We need a feature that a set statement can reset all query option
without restart impalad.

Support UNSET statements in SQL dialect. UNSET ALL can unset all query
option.

Testing:
  - add unset all query option in test_hs2.py

Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
---
M be/src/service/client-request-state.cc
M be/src/service/query-options.cc
M be/src/service/query-options.h
M common/thrift/Frontend.thrift
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/SetStmt.java
M shell/impala_shell.py
M tests/hs2/test_hs2.py
8 files changed, 71 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/18430/6
-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 6
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 8:

(9 comments)

Thanks for adding this useful feature! The solution LGTM. Asking for more tests.

http://gerrit.cloudera.org:8080/#/c/18430/8//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18430/8//COMMIT_MSG@9
PS8, Line 9: option,
nit: options.


http://gerrit.cloudera.org:8080/#/c/18430/8//COMMIT_MSG@12
PS8, Line 12: affect
nit: effect?


http://gerrit.cloudera.org:8080/#/c/18430/8//COMMIT_MSG@13
PS8, Line 13: restart impalad
I think users can re-create a connection instead of restarting the impalad. Maybe rework this to "without recreating a new connection"


http://gerrit.cloudera.org:8080/#/c/18430/8/be/src/service/client-request-state.cc
File be/src/service/client-request-state.cc:

http://gerrit.cloudera.org:8080/#/c/18430/8/be/src/service/client-request-state.cc@284
PS8, Line 284:       } else if (exec_request_->set_query_option_request.query_option_type
I think we should also check "exec_request_->set_query_option_request.__isset.query_option_type" here.


http://gerrit.cloudera.org:8080/#/c/18430/8/be/src/service/query-options.cc
File be/src/service/query-options.cc:

http://gerrit.cloudera.org:8080/#/c/18430/8/be/src/service/query-options.cc@1309
PS8, Line 1309: if (option >= 0) {
I think this should be "DCHECK_GE(option, 0)". Query options generated in QUERY_OPT_FN macro should be valid.


http://gerrit.cloudera.org:8080/#/c/18430/8/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java:

http://gerrit.cloudera.org:8080/#/c/18430/8/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@4639
PS8, Line 4639:     AnalyzesOk("set");
Could you add a test here for "unset all"?


http://gerrit.cloudera.org:8080/#/c/18430/8/shell/impala_shell.py
File shell/impala_shell.py:

http://gerrit.cloudera.org:8080/#/c/18430/8/shell/impala_shell.py@895
PS8, Line 895:     elif option == 'ALL':
Let's print some info like the above cases.


http://gerrit.cloudera.org:8080/#/c/18430/8/tests/custom_cluster/test_set_and_unset.py
File tests/custom_cluster/test_set_and_unset.py:

http://gerrit.cloudera.org:8080/#/c/18430/8/tests/custom_cluster/test_set_and_unset.py@86
PS8, Line 86: 
Could you add some tests here? We need to test that if impala is launched with customized default_query_options, "unset all" will reset query options to the customized ones.


http://gerrit.cloudera.org:8080/#/c/18430/8/tests/shell/test_shell_interactive.py
File tests/shell/test_shell_interactive.py:

http://gerrit.cloudera.org:8080/#/c/18430/8/tests/shell/test_shell_interactive.py@686
PS8, Line 686:     assert "\tDEFAULT_FILE_FORMAT: avro" in result.stdout
Can we add a test for "unset all" here? We currently don't have tests on impala-shell.



-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 8
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Tue, 31 May 2022 09:20:59 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Xiaoqing Gao (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Jian Zhang, Gabor Kaszab, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18430

to look at the new patch set (#11).

Change subject: IMPALA-11233: Unset all query option
......................................................................

IMPALA-11233: Unset all query option

When using jdbc connection pool, a connection set some query options,
after query finished, connection is closed and put back to the connection
pool. When connection used again, the last query option also come into
effect. We need a feature that a set statement can reset all query option
without recreating a new connection.

Support UNSET statements in SQL dialect. UNSET ALL can unset all query
option.

Testing:
  - add unset all query option in test_hs2.py

Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
---
M be/src/service/client-request-state.cc
M be/src/service/query-options.cc
M be/src/service/query-options.h
M common/thrift/Frontend.thrift
M fe/src/main/cup/sql-parser.cup
M fe/src/main/java/org/apache/impala/analysis/SetStmt.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java
M shell/impala_shell.py
M tests/custom_cluster/test_set_and_unset.py
M tests/hs2/test_hs2.py
M tests/shell/test_shell_interactive.py
11 files changed, 131 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/18430/11
-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 11
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 11:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10730/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 11
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Wed, 08 Jun 2022 10:28:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11233: Unset all query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18430 )

Change subject: IMPALA-11233: Unset all query option
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18430/9/be/src/service/query-options.cc
File be/src/service/query-options.cc:

http://gerrit.cloudera.org:8080/#/c/18430/9/be/src/service/query-options.cc@1301
PS9, Line 1301:   QUERY_OPTS_TABLE 
line has trailing whitespace



-- 
To view, visit http://gerrit.cloudera.org:8080/18430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf23622daab733ddab20dd3ca73af6c9bd5c250
Gerrit-Change-Number: 18430
Gerrit-PatchSet: 9
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jian Zhang <zj...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Wed, 08 Jun 2022 10:06:42 +0000
Gerrit-HasComments: Yes