You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/03/11 00:30:37 UTC

[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove more stray CDH references 

John Russell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6352

Change subject: IMPALA-3402: [DOCS] Remove more stray CDH references
......................................................................

IMPALA-3402: [DOCS] Remove more stray CDH references

A number of 'CDH' by itself were turned into substitution
variables resolving to 'Apache Hadoop'.

Also fixed some stray instances of CDH version numbers.

In some cases, 'CDH' or 'CDH 5' by itself was superfluous and was
just removed.

Change-Id: I979ea73ccaa5873d4108545f18f598072fb5e05f
---
M docs/impala.ditamap
M docs/impala_keydefs.ditamap
M docs/topics/impala_admission.xml
M docs/topics/impala_complex_types.xml
M docs/topics/impala_components.xml
M docs/topics/impala_compute_stats.xml
M docs/topics/impala_config_options.xml
M docs/topics/impala_config_performance.xml
M docs/topics/impala_date.xml
M docs/topics/impala_decimal.xml
D docs/topics/impala_errata.xml
M docs/topics/impala_grant.xml
M docs/topics/impala_isilon.xml
M docs/topics/impala_mem_limit.xml
M docs/topics/impala_parquet.xml
M docs/topics/impala_partitioning.xml
M docs/topics/impala_perf_cookbook.xml
M docs/topics/impala_perf_hdfs_caching.xml
M docs/topics/impala_perf_stats.xml
M docs/topics/impala_resource_management.xml
M docs/topics/impala_timeouts.xml
M docs/topics/impala_troubleshooting.xml
22 files changed, 34 insertions(+), 1,438 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/6352/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I979ea73ccaa5873d4108545f18f598072fb5e05f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>

[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove more stray CDH references

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-3402: [DOCS] Remove more stray CDH references
......................................................................


Patch Set 4:

Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/76/

-- 
To view, visit http://gerrit.cloudera.org:8080/6352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I979ea73ccaa5873d4108545f18f598072fb5e05f
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove more stray CDH references

Posted by "Ambreen Kazi (Code Review)" <ge...@cloudera.org>.
Ambreen Kazi has posted comments on this change.

Change subject: IMPALA-3402: [DOCS] Remove more stray CDH references
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/6352/1/docs/impala.ditamap
File docs/impala.ditamap:

PS1, Line 301: CDH 5
flagging this in case you want to remove it.


http://gerrit.cloudera.org:8080/#/c/6352/1/docs/topics/impala_config_options.xml
File docs/topics/impala_config_options.xml:

PS1, Line 252: DOCS-677
not a CDH ref but I thought this would've been removed in a previous gerrit that dealt with jira numbers.


http://gerrit.cloudera.org:8080/#/c/6352/1/docs/topics/impala_perf_hdfs_caching.xml
File docs/topics/impala_perf_hdfs_caching.xml:

PS1, Line 100: CDH 5.1
CDH ref


-- 
To view, visit http://gerrit.cloudera.org:8080/6352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I979ea73ccaa5873d4108545f18f598072fb5e05f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove more stray CDH references

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#3).

Change subject: IMPALA-3402: [DOCS] Remove more stray CDH references
......................................................................

IMPALA-3402: [DOCS] Remove more stray CDH references

A number of 'CDH' by itself were turned into substitution
variables resolving to 'Apache Hadoop'.

Also fixed some stray instances of CDH version numbers.

In some cases, 'CDH' or 'CDH 5' by itself was superfluous and was
just removed.

Change-Id: I979ea73ccaa5873d4108545f18f598072fb5e05f
---
M docs/impala.ditamap
M docs/impala_keydefs.ditamap
M docs/topics/impala_admission.xml
M docs/topics/impala_complex_types.xml
M docs/topics/impala_components.xml
M docs/topics/impala_compute_stats.xml
M docs/topics/impala_config_options.xml
M docs/topics/impala_config_performance.xml
M docs/topics/impala_date.xml
M docs/topics/impala_datetime_functions.xml
M docs/topics/impala_decimal.xml
D docs/topics/impala_errata.xml
M docs/topics/impala_grant.xml
M docs/topics/impala_intro.xml
M docs/topics/impala_isilon.xml
M docs/topics/impala_langref_unsupported.xml
M docs/topics/impala_mem_limit.xml
M docs/topics/impala_new_features.xml
D docs/topics/impala_noncm_installation.xml
M docs/topics/impala_parquet.xml
M docs/topics/impala_partitioning.xml
M docs/topics/impala_perf_cookbook.xml
M docs/topics/impala_perf_hdfs_caching.xml
M docs/topics/impala_perf_stats.xml
M docs/topics/impala_proxy.xml
M docs/topics/impala_resource_management.xml
M docs/topics/impala_timeouts.xml
M docs/topics/impala_troubleshooting.xml
M docs/topics/impala_tutorial.xml
M docs/topics/impala_upgrading.xml
30 files changed, 49 insertions(+), 1,658 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/6352/3
-- 
To view, visit http://gerrit.cloudera.org:8080/6352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I979ea73ccaa5873d4108545f18f598072fb5e05f
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>

[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove more stray CDH references

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.

Change subject: IMPALA-3402: [DOCS] Remove more stray CDH references
......................................................................


Patch Set 2:

I also deleted impala_noncm_installation.xml since there were no more references to it and it was inflating the count of 'CDH' and 'Cloudera' references.

-- 
To view, visit http://gerrit.cloudera.org:8080/6352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I979ea73ccaa5873d4108545f18f598072fb5e05f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove more stray CDH references

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.

Change subject: IMPALA-3402: [DOCS] Remove more stray CDH references
......................................................................


Patch Set 4: Code-Review+2

Just rebased against already +2'ed review of the Upgrading page.

-- 
To view, visit http://gerrit.cloudera.org:8080/6352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I979ea73ccaa5873d4108545f18f598072fb5e05f
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove more stray CDH references

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.

Change subject: IMPALA-3402: [DOCS] Remove more stray CDH references
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6352/2/docs/topics/impala_resource_management.xml
File docs/topics/impala_resource_management.xml:

PS2, Line 88: cdh
Might as well take 'cdh' out of this ID so it doesn't show up in the grep report.


-- 
To view, visit http://gerrit.cloudera.org:8080/6352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I979ea73ccaa5873d4108545f18f598072fb5e05f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove more stray CDH references

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-3402: [DOCS] Remove more stray CDH references
......................................................................


Patch Set 4: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/6352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I979ea73ccaa5873d4108545f18f598072fb5e05f
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove more stray CDH references

Posted by "Ambreen Kazi (Code Review)" <ge...@cloudera.org>.
Ambreen Kazi has posted comments on this change.

Change subject: IMPALA-3402: [DOCS] Remove more stray CDH references
......................................................................


Patch Set 3: Code-Review+1

lgtm.

-- 
To view, visit http://gerrit.cloudera.org:8080/6352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I979ea73ccaa5873d4108545f18f598072fb5e05f
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove more stray CDH references

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#2).

Change subject: IMPALA-3402: [DOCS] Remove more stray CDH references
......................................................................

IMPALA-3402: [DOCS] Remove more stray CDH references

A number of 'CDH' by itself were turned into substitution
variables resolving to 'Apache Hadoop'.

Also fixed some stray instances of CDH version numbers.

In some cases, 'CDH' or 'CDH 5' by itself was superfluous and was
just removed.

Change-Id: I979ea73ccaa5873d4108545f18f598072fb5e05f
---
M docs/impala.ditamap
M docs/impala_keydefs.ditamap
M docs/topics/impala_admission.xml
M docs/topics/impala_complex_types.xml
M docs/topics/impala_components.xml
M docs/topics/impala_compute_stats.xml
M docs/topics/impala_config_options.xml
M docs/topics/impala_config_performance.xml
M docs/topics/impala_date.xml
M docs/topics/impala_datetime_functions.xml
M docs/topics/impala_decimal.xml
D docs/topics/impala_errata.xml
M docs/topics/impala_grant.xml
M docs/topics/impala_isilon.xml
M docs/topics/impala_langref_unsupported.xml
M docs/topics/impala_mem_limit.xml
M docs/topics/impala_new_features.xml
D docs/topics/impala_noncm_installation.xml
M docs/topics/impala_parquet.xml
M docs/topics/impala_partitioning.xml
M docs/topics/impala_perf_cookbook.xml
M docs/topics/impala_perf_hdfs_caching.xml
M docs/topics/impala_perf_stats.xml
M docs/topics/impala_proxy.xml
M docs/topics/impala_resource_management.xml
M docs/topics/impala_timeouts.xml
M docs/topics/impala_troubleshooting.xml
M docs/topics/impala_tutorial.xml
M docs/topics/impala_upgrading.xml
29 files changed, 46 insertions(+), 1,655 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/6352/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I979ea73ccaa5873d4108545f18f598072fb5e05f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>

[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove more stray CDH references

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-3402: [DOCS] Remove more stray CDH references
......................................................................


IMPALA-3402: [DOCS] Remove more stray CDH references

A number of 'CDH' by itself were turned into substitution
variables resolving to 'Apache Hadoop'.

Also fixed some stray instances of CDH version numbers.

In some cases, 'CDH' or 'CDH 5' by itself was superfluous and was
just removed.

Change-Id: I979ea73ccaa5873d4108545f18f598072fb5e05f
Reviewed-on: http://gerrit.cloudera.org:8080/6352
Reviewed-by: John Russell <jr...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/impala.ditamap
M docs/impala_keydefs.ditamap
M docs/topics/impala_admission.xml
M docs/topics/impala_complex_types.xml
M docs/topics/impala_components.xml
M docs/topics/impala_compute_stats.xml
M docs/topics/impala_config_options.xml
M docs/topics/impala_config_performance.xml
M docs/topics/impala_date.xml
M docs/topics/impala_datetime_functions.xml
M docs/topics/impala_decimal.xml
D docs/topics/impala_errata.xml
M docs/topics/impala_grant.xml
M docs/topics/impala_intro.xml
M docs/topics/impala_isilon.xml
M docs/topics/impala_langref_unsupported.xml
M docs/topics/impala_mem_limit.xml
M docs/topics/impala_new_features.xml
D docs/topics/impala_noncm_installation.xml
M docs/topics/impala_parquet.xml
M docs/topics/impala_partitioning.xml
M docs/topics/impala_perf_cookbook.xml
M docs/topics/impala_perf_hdfs_caching.xml
M docs/topics/impala_perf_stats.xml
M docs/topics/impala_proxy.xml
M docs/topics/impala_resource_management.xml
M docs/topics/impala_timeouts.xml
M docs/topics/impala_troubleshooting.xml
M docs/topics/impala_tutorial.xml
29 files changed, 48 insertions(+), 1,652 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  John Russell: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/6352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I979ea73ccaa5873d4108545f18f598072fb5e05f
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>

[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove more stray CDH references

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.

Change subject: IMPALA-3402: [DOCS] Remove more stray CDH references
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/6352/1/docs/impala.ditamap
File docs/impala.ditamap:

PS1, Line 301: " for
> flagging this in case you want to remove it.
Done


http://gerrit.cloudera.org:8080/#/c/6352/1/docs/topics/impala_config_options.xml
File docs/topics/impala_config_options.xml:

PS1, Line 252: DOCS-677
> not a CDH ref but I thought this would've been removed in a previous gerrit
Since the DOCS- prefix is not so prominent the way 'CDH' or 'Cloudera' are, we haven't included removing that in our exit criteria. I see there are still a few instances. To avoid pulling more files into this review, I'm going to leave all those as-is for now.


http://gerrit.cloudera.org:8080/#/c/6352/1/docs/topics/impala_perf_hdfs_caching.xml
File docs/topics/impala_perf_hdfs_caching.xml:

PS1, Line 84: setup_h
I may as well change this prefix so this 'cdh' doesn't show up in our grep report.


-- 
To view, visit http://gerrit.cloudera.org:8080/6352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I979ea73ccaa5873d4108545f18f598072fb5e05f
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-3402: [DOCS] Remove more stray CDH references

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
Hello Ambreen Kazi,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6352

to look at the new patch set (#4).

Change subject: IMPALA-3402: [DOCS] Remove more stray CDH references
......................................................................

IMPALA-3402: [DOCS] Remove more stray CDH references

A number of 'CDH' by itself were turned into substitution
variables resolving to 'Apache Hadoop'.

Also fixed some stray instances of CDH version numbers.

In some cases, 'CDH' or 'CDH 5' by itself was superfluous and was
just removed.

Change-Id: I979ea73ccaa5873d4108545f18f598072fb5e05f
---
M docs/impala.ditamap
M docs/impala_keydefs.ditamap
M docs/topics/impala_admission.xml
M docs/topics/impala_complex_types.xml
M docs/topics/impala_components.xml
M docs/topics/impala_compute_stats.xml
M docs/topics/impala_config_options.xml
M docs/topics/impala_config_performance.xml
M docs/topics/impala_date.xml
M docs/topics/impala_datetime_functions.xml
M docs/topics/impala_decimal.xml
D docs/topics/impala_errata.xml
M docs/topics/impala_grant.xml
M docs/topics/impala_intro.xml
M docs/topics/impala_isilon.xml
M docs/topics/impala_langref_unsupported.xml
M docs/topics/impala_mem_limit.xml
M docs/topics/impala_new_features.xml
D docs/topics/impala_noncm_installation.xml
M docs/topics/impala_parquet.xml
M docs/topics/impala_partitioning.xml
M docs/topics/impala_perf_cookbook.xml
M docs/topics/impala_perf_hdfs_caching.xml
M docs/topics/impala_perf_stats.xml
M docs/topics/impala_proxy.xml
M docs/topics/impala_resource_management.xml
M docs/topics/impala_timeouts.xml
M docs/topics/impala_troubleshooting.xml
M docs/topics/impala_tutorial.xml
29 files changed, 48 insertions(+), 1,652 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/6352/4
-- 
To view, visit http://gerrit.cloudera.org:8080/6352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I979ea73ccaa5873d4108545f18f598072fb5e05f
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>