[jira] [Commented] (GEODE-9502) Eliminate templates used to work around now-obsolete MSVC compiler warning

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-9502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468081#comment-17468081 ] 

ASF GitHub Bot commented on GEODE-9502:
---------------------------------------

mreddington commented on a change in pull request #901:
URL: https://github.com/apache/geode-native/pull/901#discussion_r777568726



##########
File path: cppcache/integration/framework/Cluster.cpp
##########
@@ -146,7 +146,10 @@ void Locator::start() {
 }
 
 void Locator::stop() {
-  cluster_.getGfsh().stop().locator().withDir(name_).execute();
+  try {
+    cluster_.getGfsh().stop().locator().withDir(name_).execute();
+  } catch (...) {

Review comment:
       Destructors aren't supposed to throw. We throw an exception when BOOST_PROCESS tries to execute a command on a locator and the locator is already down. This has absolutely nothing to do with the test itself or the native client. We aren't testing the cluster, the testing framework itself, or the environment.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Eliminate templates used to work around now-obsolete MSVC compiler warning
> --------------------------------------------------------------------------
>
>                 Key: GEODE-9502
>                 URL: https://issues.apache.org/jira/browse/GEODE-9502
>             Project: Geode
>          Issue Type: Improvement
>          Components: native client
>            Reporter: Blake Bender
>            Priority: Major
>              Labels: pull-request-available
>
> CacheableBuiltins.hpp contains the following comment, followed by a bunch of very strange template definitions:
> // The following are defined as classes to avoid the issues with MSVC++
> // warning/erroring on C4503
> According to Microsoft (https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4503?view=msvc-160), this warning was obsolete as of VS2017.  We no longer support any pre-VS2017 compilers, so it should be safe to remove all this nonsense and replace it with the template(s) originally intended.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)