You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/18 01:43:13 UTC

[GitHub] [incubator-nuttx] btashton opened a new pull request #1836: input: STMPE811 GPIO interrupt bug fixes

btashton opened a new pull request #1836:
URL: https://github.com/apache/incubator-nuttx/pull/1836


   ## Summary
   This patch resolves to bugs in the GPIO interrupt logic:
   
   1. Any pins did not have STMPE811_GPIO_RISING in their pincfg would clear the rising edge interrupt enable flag for all pins due to a masking bug.
   
   2. Pins would never trigger a second interrupt.  There is an undocumented requirement that you have to clear both the GPIO interrupt status register __and__ also the edge detection status register.  Failure to clear either of these will result in no further interrupts being triggered. This requirement exists both for edge and level modes of operation.
   
   ## Impact
   
   ## Testing
   This was tested on the nRF52 arch using the Keyboard FeatherWing (modified to fix card detect pull-up bug)
   
   ```
   NuttShell (NSH) NuttX-9.1.0
   nsh> kb_int: Detected KBD
   kb_int: Detected KBD
   kb_carddet: Detected Card Change. Inserted: 0
   kb_carddet: Detected Card Change. Inserted: 1
   kb_int: Detected KBD
   kb_int: Detected KBD
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on pull request #1836: input: STMPE811 GPIO interrupt bug fixes

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1836:
URL: https://github.com/apache/incubator-nuttx/pull/1836#issuecomment-694600065


   @patacongo one more patch for this chip...  At this point I have the GPIO and SPI portions of the driver fairly well tested.
   
   The undocumented requirement to read the `STMPE811_GPIO_ED` register was unfortunate.  I suspect internally to the chip this register is attached to a state latch that is used to generate the signal to the interrupt controller and they just failed to document it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #1836: input: STMPE811 GPIO interrupt bug fixes

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #1836:
URL: https://github.com/apache/incubator-nuttx/pull/1836


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org