[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #4144: tools/version.sh: Fix version number to get on master branch

[GitBox <gi...@apache.org>]

Ouss4 commented on a change in pull request #4144:
URL: https://github.com/apache/incubator-nuttx/pull/4144#discussion_r668889242



##########
File path: tools/version.sh
##########
@@ -71,12 +71,12 @@ done
 OUTFILE=$1
 
 if [ -z ${VERSION} ] ; then
-  VERSION=`git -C ${WD} describe 2>/dev/null | tail -1 | cut -d'-' -f2`
+  VERSION=`git -C ${WD} describe --match "nuttx-*" 2>/dev/null | tail -1 | cut -d'-' -f2`

Review comment:
       > This command currently returns 8.2 on my environment. 
   
   That's because it's run from master.  8.2 is the last tag that's reachable from master. From 9.0 we started using release branches and tagging there instead from master.
   
   > The reason I added --match is just in case so that we can tag like v1.2.3 without "nuttx-" locally.
   
   @masayuki2009 changed the regex to accommodate something similar, but maybe this doesn't cover your use case.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org