You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/04 03:57:37 UTC
[GitHub] [beam] kennknowles opened a new issue, #19561: Remove duplicated null checks in Row.equals
kennknowles opened a new issue, #19561:
URL: https://github.com/apache/beam/issues/19561
After [BEAM-5866](https://issues.apache.org/jira/browse/BEAM-5866) and [BEAM-7125](https://issues.apache.org/jira/browse/BEAM-7125) Row has duplicated null value checks.
Imported from Jira [BEAM-7699](https://issues.apache.org/jira/browse/BEAM-7699). Original Jira may contain additional context.
Reported by: naheonk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jon-esperanza commented on issue #19561: Unit test for edge cases for null checks in Row.equals
Posted by "jon-esperanza (via GitHub)" <gi...@apache.org>.
jon-esperanza commented on issue #19561:
URL: https://github.com/apache/beam/issues/19561#issuecomment-1646378226
.take-issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn closed issue #19561: Unit test for edge cases for null checks in Row.equals
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn closed issue #19561: Unit test for edge cases for null checks in Row.equals
URL: https://github.com/apache/beam/issues/19561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] yyy1000 commented on issue #19561: Remove duplicated null checks in Row.equals
Posted by GitBox <gi...@apache.org>.
yyy1000 commented on issue #19561:
URL: https://github.com/apache/beam/issues/19561#issuecomment-1363922665
Want to help with this :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] yyy1000 commented on issue #19561: Remove duplicated null checks in Row.equals
Posted by GitBox <gi...@apache.org>.
yyy1000 commented on issue #19561:
URL: https://github.com/apache/beam/issues/19561#issuecomment-1363922726
.take-issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on issue #19561: Unit test for edge cases for null checks in Row.equals
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on issue #19561:
URL: https://github.com/apache/beam/issues/19561#issuecomment-1557270477
It was found the original nul checks were not duplicated, though there is still some thing could do for unit testing (see https://github.com/apache/beam/pull/24773#issuecomment-1374187076 for the context)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org