You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by acton393 <gi...@git.apache.org> on 2017/03/23 03:05:31 UTC
[GitHub] incubator-weex pull request #149: * [ios] support accessibility
GitHub user acton393 opened a pull request:
https://github.com/apache/incubator-weex/pull/149
* [ios] support accessibility
case: http://dotwe.org/weex/a1a89e2c1f82aaa1559cb9ceefd63f7f
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/acton393/incubator-weex 0.12-dev
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/149.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #149
----
commit 7ce648ab3c3a2f65adfae8a096859d51d4d38e43
Author: acton393 <zh...@gmail.com>
Date: 2017-03-21T06:16:25Z
Merge remote-tracking branch 'upstream/0.12-dev' into 0.12-dev
commit fa45c8e2d7b5c015b1e34d5a492b3542f403b12c
Author: acton393 <zh...@gmail.com>
Date: 2017-03-21T09:11:25Z
* [ios] support web accessibility standard about WAI
commit 6a2da1f75989d8f6bff6774c986e7a98b2ff10d8
Author: acton393 <zh...@gmail.com>
Date: 2017-03-21T09:12:17Z
* [ios] aria-label then string value
commit 896ffe83e556f0897745ec68a53cf4f986ee5bb2
Author: acton393 <zh...@gmail.com>
Date: 2017-03-22T09:20:21Z
* [ios] bugfix div accessibility
commit c8a25b942061b98dfbdc2051ddf721f01cefdbb0
Author: acton393 <zh...@gmail.com>
Date: 2017-03-22T09:20:44Z
Merge remote-tracking branch 'upstream/0.12-dev' into 0.12-dev
commit c33e6141302986731cafae5cc794e2b8cf70228a
Author: acton393 <zh...@gmail.com>
Date: 2017-03-23T03:03:03Z
* [ios] add example for accessibility
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #149: 0.12 feature support accessibility
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on the issue:
https://github.com/apache/incubator-weex/pull/149
update case: http://dotwe.org/weex/5b56a108a7748a56d58d1a715c08d4ab
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #149: 0.12 feature support accessibility
Posted by cxfeng1 <gi...@git.apache.org>.
Github user cxfeng1 commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/149#discussion_r108122527
--- Diff: ios/sdk/WeexSDK/Sources/Model/WXComponent.m ---
@@ -445,6 +448,23 @@ - (void)readyToRender
- (void)updateAttributes:(NSDictionary *)attributes
{
WXAssertMainThread();
+
+}
+
+- (void)_setWXComponentA11yInfo:(NSDictionary *)attributes
+{
+ if (attributes[@"role"]){
+ _role = [WXConvert WXUIAccessibilityTraits:attributes[@"role"]];
+ self.view.accessibilityTraits = _role;
--- End diff --
self.view maybe not ready here,
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #149: 0.12 feature support accessibility
Posted by cxfeng1 <gi...@git.apache.org>.
Github user cxfeng1 commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/149#discussion_r108122449
--- Diff: ios/sdk/WeexSDK/Sources/Layout/WXComponent+Layout.m ---
@@ -205,6 +205,10 @@ - (void)_layoutDidFinish
[self.ancestorScroller adjustSticky];
}
+ if (0 == [[self.view subviews] count]) {
+ self.view.isAccessibilityElement = YES;
+ self.view.accessibilityFrame = [[self.view superview] convertRect:self.calculatedFrame toView:nil];
+ }
--- End diff --
self.view maybe not ready here, please add this logic to [self view], too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #149: 0.12 feature support accessibility
Posted by cxfeng1 <gi...@git.apache.org>.
Github user cxfeng1 commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/149#discussion_r108164541
--- Diff: ios/sdk/WeexSDK/Sources/Layout/WXComponent+Layout.m ---
@@ -205,6 +205,10 @@ - (void)_layoutDidFinish
[self.ancestorScroller adjustSticky];
}
+ if (0 == [[self.view subviews] count]) {
+ self.view.isAccessibilityElement = YES;
+ self.view.accessibilityFrame = [[self.view superview] convertRect:self.calculatedFrame toView:nil];
+ }
--- End diff --
You do not have to set this property for an accessibility element that represents a subclass of UIView, because such an object\u2019s screen coordinates are already known.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #149: 0.12 feature support accessibility
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/149
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #149: 0.12 feature support accessibility
Posted by YorkShen <gi...@git.apache.org>.
Github user YorkShen commented on the issue:
https://github.com/apache/incubator-weex/pull/149
@sospartan Good to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---