You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@beam.apache.org by "sunjincheng (Jira)" <ji...@apache.org> on 2019/11/05 09:46:00 UTC

[jira] [Updated] (BEAM-8557) Clean up useless null check.

     [ https://issues.apache.org/jira/browse/BEAM-8557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

sunjincheng updated BEAM-8557:
------------------------------
        Parent: BEAM-7944
    Issue Type: Sub-task  (was: Improvement)

> Clean up useless null check.
> ----------------------------
>
>                 Key: BEAM-8557
>                 URL: https://issues.apache.org/jira/browse/BEAM-8557
>             Project: Beam
>          Issue Type: Sub-task
>          Components: runner-core, sdk-java-harness
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>            Priority: Major
>
> I think we do not need null check here:
> [https://github.com/apache/beam/blob/master/runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/FnApiControlClient.java#L151]
> Because before the the `onNext` call, the `Future` already put into the queue in `handle` method.
> What do you think?
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)