You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@yetus.apache.org by "Allen Wittenauer (JIRA)" <ji...@apache.org> on 2016/01/05 21:41:40 UTC

[jira] [Updated] (YETUS-267) use curl -L when given a patch URL

     [ https://issues.apache.org/jira/browse/YETUS-267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Allen Wittenauer updated YETUS-267:
-----------------------------------
    Summary: use curl -L when given a patch URL  (was: Default to `curl -L` to ensure redirects are followed when downloading a patch)

> use curl -L when given a patch URL
> ----------------------------------
>
>                 Key: YETUS-267
>                 URL: https://issues.apache.org/jira/browse/YETUS-267
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>    Affects Versions: 0.1.0
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Minor
>             Fix For: 0.2.0
>
>
> I went to try out a local {{test-patch}} build using the patch from a GH pull request.
> {code}
> test-patch --personality /usr/local/lib/yetus/lib/precommit/personality/accumulo.sh --branch=1.7 https://github.com/apache/accumulo/pull/61.patch --project=Accumulo
> {code}
> This failed with an error message that Yetus couldn't apply the patch. This is because Github was sending a redirect, so the resulting patch Yetus tried to apply actually contained:
> {noformat}
> <html><body>You are being <a href="https://patch-diff.githubusercontent.com/raw/apache/accumulo/pull/61.patch">redirected</a>.</body></html>
> {noformat}
> It seems like a simple change to just default to {{curl -L}} instead of {{curl}}, but I'm surprised this wasn't encountered by anyone else before (so I present it with an air of caution).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)