You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/04/14 08:42:01 UTC
[GitHub] [pulsar] tisonkun opened a new pull request, #20100: [fix][tool] ConnectorDocGenerator support Java 9+
tisonkun opened a new pull request, #20100:
URL: https://github.com/apache/pulsar/pull/20100
Java 9 changes ThreadContextClassLoader and SystemClassLoader to AppClassLoader from URLClassLoader.
We should use `java.class.path` instead to get the related URLs.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #20100: [fix][tool] ConnectorDocGenerator support Java 9+
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #20100:
URL: https://github.com/apache/pulsar/pull/20100#discussion_r1166504628
##########
pulsar-io/elastic-search/src/main/java/org/apache/pulsar/io/elasticsearch/ElasticSearchConfig.java:
##########
@@ -242,6 +242,11 @@ public class ElasticSearchConfig implements Serializable {
)
private String primaryFields = "";
+ @FieldDoc(
+ required = false,
+ defaultValue = "",
+ help = "The SSL config for elastic search."
+ )
private ElasticSearchSslConfig ssl = new ElasticSearchSslConfig();
Review Comment:
Nested configs should be supported to generate configs properly. But I'd like to postpone it to a follow-up. Printing an empty string doesn't hurt and no regression here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun merged pull request #20100: [fix][doc] ConnectorDocGenerator support Java 9+
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #20100:
URL: https://github.com/apache/pulsar/pull/20100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #20100: [fix][doc] ConnectorDocGenerator support Java 9+
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #20100:
URL: https://github.com/apache/pulsar/pull/20100#issuecomment-1510620903
Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org