You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/12/14 23:12:32 UTC

[GitHub] [helix] hivivo opened a new pull request, #2323: [helix-front] Add example and comment for using customized login

hivivo opened a new pull request, #2323:
URL: https://github.com/apache/helix/pull/2323

   ### Issues
   
   - NA
   
   ### Description
   
   - [x] Here are some details about my PR
   
   - Added an example to use a customized login provider in Helix UI. It would be quite useful if the user relies on a 3rd party login service.
   - Commented out the route by default, if the user is not going to use customized login
   - Updated the UI docs with some recent changes
   
   ### Tests
   
   - Manually tested locally.
   - The following is the result of the "mvn test" command on the appropriate module:
   ```
   ...
   [INFO] --- jacoco-maven-plugin:0.8.6:report (generate-code-coverage-report) @ helix-front ---
   [INFO] Skipping JaCoCo execution due to missing execution data file.
   [INFO] ------------------------------------------------------------------------
   [INFO] BUILD SUCCESS
   [INFO] ------------------------------------------------------------------------
   [INFO] Total time:  05:40 min
   [INFO] Finished at: 2022-12-14T23:12:09Z
   [INFO] ------------------------------------------------------------------------
   ```
   
   ### Commits
   
   - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


[GitHub] [helix] hivivo commented on pull request #2323: [helix-front] Comment out the unused example route by default

Posted by GitBox <gi...@apache.org>.
hivivo commented on PR #2323:
URL: https://github.com/apache/helix/pull/2323#issuecomment-1352358306

   This PR is ready to be merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


[GitHub] [helix] junkaixue merged pull request #2323: [helix-front] Comment out the unused example route by default

Posted by GitBox <gi...@apache.org>.
junkaixue merged PR #2323:
URL: https://github.com/apache/helix/pull/2323


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org