You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yuluo-yx (via GitHub)" <gi...@apache.org> on 2026/08/09 04:37:39 UTC
[PR] [ISSUE #10873] fix(remoting): handle empty broker address tables [rocketmq]
yuluo-yx opened a new pull request, #10883:
URL: https://github.com/apache/rocketmq/pull/10883
### Which Issue(s) This PR Fixes
- Fixes #10873
### Brief Description
BrokerData.selectBrokerAddr now returns null when the address table is null or empty. Existing master preference and slave fallback behavior are unchanged and covered alongside the new boundary cases.
### How Did You Test This Change?
- mise exec java@zulu-8.94.0.17 -- mvn -pl remoting -am -DskipITs -Dtest=BrokerDataTest -Dsurefire.failIfNoSpecifiedTests=false test (3 tests passed)
- Checkstyle and SpotBugs passed in the same Maven reactor.
- git diff --check and the 400-line scope gate passed.
- Not run: full repository build, container tests, or end-to-end tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #10873] fix(remoting): handle empty broker address tables [rocketmq]
Posted by "yuluo-yx (via GitHub)" <gi...@apache.org>.
yuluo-yx closed pull request #10883: [ISSUE #10873] fix(remoting): handle empty broker address tables
URL: https://github.com/apache/rocketmq/pull/10883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #10873] fix(remoting): handle empty broker address tables [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10883:
URL: https://github.com/apache/rocketmq/pull/10883#issuecomment-5229872879
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/10883?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.31%. Comparing base ([`fd0c959`](https://app.codecov.io/gh/apache/rocketmq/commit/fd0c95920e0deac96ce2ae27442747cc5e65e930?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4d38a02`](https://app.codecov.io/gh/apache/rocketmq/commit/4d38a02e54316c4293ca20c2dcf05e8839c28fa0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #10883 +/- ##
=============================================
- Coverage 48.39% 48.31% -0.09%
+ Complexity 13562 13529 -33
=============================================
Files 1380 1380
Lines 101165 101167 +2
Branches 13127 13127
=============================================
- Hits 48962 48881 -81
- Misses 46233 46294 +61
- Partials 5970 5992 +22
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/rocketmq/pull/10883?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org