You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/19 14:29:17 UTC

[GitHub] StefanRRichter commented on issue #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code

StefanRRichter commented on issue #7674: [FLINK-10043] [State Backends] Refactor RocksDBKeyedStateBackend object construction/initialization/restore code
URL: https://github.com/apache/flink/pull/7674#issuecomment-465149906
 
 
   So far, I think the comments have been well addressed. Only the introduction of `RocksDBNativeMetricMonitor::setRocksDB` looks like a step in the wrong direction for me. I think we can do better with the construction order to avoid the setter, similiar to how we could avoid `setDb` before. I had a couple more minor comments inline, but I think we are getting close to the end of this refactoring.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services