[GitHub] [pulsar-client-cpp] shibd commented on pull request #72: Add windows release artifacts

[GitBox <gi...@apache.org>]

shibd commented on PR #72:
URL: https://github.com/apache/pulsar-client-cpp/pull/72#issuecomment-1294725558

   > @merlimat The uploaded artifacts are release artifacts needed by users, and they don't need to build themself. The token is GITHUB_TOKEN which is a builtin token in GitHub action so that we can use it directly.
   > 
   > About GITHUB_TOKEN:
   > 
   > https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token
   
   I think we need to keep uploading the binaries to GH action artifacts. This is required for the current release process. You can refer to the following:
   
   - https://github.com/apache/pulsar-client-cpp/wiki/Committer-Release-Guide#sign-and-stage-the-artifacts
   - https://github.com/apache/pulsar-client-cpp/blob/main/build-support/stage-release.sh


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org