You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/12 13:22:02 UTC

[GitHub] [arrow] dragosmg commented on a diff in pull request #12757: ARROW-14944 [R] Implement `lubridate::make_difftime()`

dragosmg commented on code in PR #12757:
URL: https://github.com/apache/arrow/pull/12757#discussion_r848430272


##########
r/R/dplyr-funcs-datetime.R:
##########
@@ -330,3 +349,33 @@ binding_format_datetime <- function(x, format = "", tz = "", usetz = FALSE) {
 
   build_expr("strftime", x, options = list(format = format, locale = Sys.getlocale("LC_TIME")))
 }
+
+duration_from_chunks <- function(chunks) {

Review Comment:
   `lubridate::make_difftime()` creates a `difftime` object from various inputs. The role of the function is _not_ to control the output (i.e. units, which can only be seconds for Arrow), but to rather to take inputs the user might specify through the `...` and transform them into a single quantity.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org